)]}'
{"jenkins/scripts/common_translation_update.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"5cd76752e5a88b13450509f377a3385073e776b5","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        fi"},{"line_number":126,"context_line":"        if [ ${IS_RST} -eq 1 ] ; then"},{"line_number":127,"context_line":"            tox -e generatepot-rst -- ${DOCNAME}"},{"line_number":128,"context_line":"            git add ${DocFolder}/${DOCNAME}/source/locale/${DOCNAME}.pot"},{"line_number":129,"context_line":"            # Set auto-local"},{"line_number":130,"context_line":"            tx set --auto-local -r openstack-manuals-i18n.${DOCNAME} \\"},{"line_number":131,"context_line":"                \"${DocFolder}/${DOCNAME}/source/locale/\u003clang\u003e/LC_MESSAGES/${DOCNAME}.po\" \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"9a80dd14_97f7b58a","line":128,"updated":"2015-03-06 21:17:30.000000000","message":"My only comment is the old code added * under the locale dir and this is specific. Maybe we make both RST and docbook git adds do the same thing?","commit_id":"781e85926b463fefb8b6879461a58e8b99271294"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"49ed9f3a6f79398d9282ce6e761c06fa2b7063c4","unresolved":false,"context_lines":[{"line_number":119,"context_line":"            if [ ${SPECIAL_BOOKS[\"${DOCNAME}\"]} \u003d\u003d \"RST\" ] ; then"},{"line_number":120,"context_line":"                IS_RST\u003d1"},{"line_number":121,"context_line":"            fi"},{"line_number":122,"context_line":"            if [ ${SPECIAL_BOOKS[\"${DOCNAME}\"]} \u003d\u003d \"skip\" ] ; then"},{"line_number":123,"context_line":"                continue"},{"line_number":124,"context_line":"            fi"},{"line_number":125,"context_line":"        fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a80dd14_8b4208ac","line":122,"updated":"2015-03-09 13:35:25.000000000","message":"Seems like this could be an elif since it\u0027s mutually exclusive of the previous condition and thus unnecessary to check in cases where that already returned true. For that matter, you could use a case since you\u0027re switching on the same variable for both conditionals.","commit_id":"e8e61d610725193b8482260697c849d697332a56"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"49ed9f3a6f79398d9282ce6e761c06fa2b7063c4","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                continue"},{"line_number":124,"context_line":"            fi"},{"line_number":125,"context_line":"        fi"},{"line_number":126,"context_line":"        if [ ${IS_RST} -eq 1 ] ; then"},{"line_number":127,"context_line":"            tox -e generatepot-rst -- ${DOCNAME}"},{"line_number":128,"context_line":"            git add ${DocFolder}/${DOCNAME}/source/locale/${DOCNAME}.pot"},{"line_number":129,"context_line":"            # Set auto-local"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a80dd14_cba96025","line":126,"updated":"2015-03-09 13:35:25.000000000","message":"This only gets set \u003d1 in one place, so you could dispense with the flag altogether and just relocate this entire conditional block (ending it with a continue to short-circuit, and then you don\u0027t need the second part to be in an else clause that way).","commit_id":"e8e61d610725193b8482260697c849d697332a56"}]}
