)]}'
{"jenkins/scripts/merge_tags.sh":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bf92cc88fa2c059bfcc39a6e5e219f301d877ba4","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TAG\u003d$1"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Safety check, but this should never match the release pipeline trigger"},{"line_number":18,"context_line":"if ! echo $TAG_MINOR|grep \u0027^[0-9\\.]*$\u0027"},{"line_number":19,"context_line":"then"},{"line_number":20,"context_line":"    echo \"ERROR: Triggered on non-release $TAG tag.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3acd31a7_f11d31be","line":17,"updated":"2015-04-30 17:58:44.000000000","message":"Should comment say \"should never match a non release pipeline trigger\" ?","commit_id":"0a831e194288951510b11c12af52fcda002655cb"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"57b85429bb26e35133e422ba33449b90bdf3510f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"TAG\u003d$1"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Safety check, but this should never match the release pipeline trigger"},{"line_number":18,"context_line":"if ! echo $TAG_MINOR|grep \u0027^[0-9\\.]*$\u0027"},{"line_number":19,"context_line":"then"},{"line_number":20,"context_line":"    echo \"ERROR: Triggered on non-release $TAG tag.\""}],"source_content_type":"text/x-sh","patch_set":1,"id":"3acd31a7_d4634319","line":17,"in_reply_to":"3acd31a7_f11d31be","updated":"2015-04-30 18:10:55.000000000","message":"I forgot to use the word \"tag\" here. Thanks.","commit_id":"0a831e194288951510b11c12af52fcda002655cb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bf92cc88fa2c059bfcc39a6e5e219f301d877ba4","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TAG\u003d$1"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Safety check, but this should never match the release pipeline trigger"},{"line_number":18,"context_line":"if ! echo $TAG_MINOR|grep \u0027^[0-9\\.]*$\u0027"},{"line_number":19,"context_line":"then"},{"line_number":20,"context_line":"    echo \"ERROR: Triggered on non-release $TAG tag.\""},{"line_number":21,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3acd31a7_b17e99e2","line":18,"updated":"2015-04-30 17:58:44.000000000","message":"This variable isn\u0027t set yet.","commit_id":"0a831e194288951510b11c12af52fcda002655cb"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"57b85429bb26e35133e422ba33449b90bdf3510f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"TAG\u003d$1"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# Safety check, but this should never match the release pipeline trigger"},{"line_number":18,"context_line":"if ! echo $TAG_MINOR|grep \u0027^[0-9\\.]*$\u0027"},{"line_number":19,"context_line":"then"},{"line_number":20,"context_line":"    echo \"ERROR: Triggered on non-release $TAG tag.\""},{"line_number":21,"context_line":"    exit 1"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3acd31a7_f47e3fad","line":18,"in_reply_to":"3acd31a7_b17e99e2","updated":"2015-04-30 18:10:55.000000000","message":"Yeah, left over from an earlier refactor, should have just been $TAG instead.","commit_id":"0a831e194288951510b11c12af52fcda002655cb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bf92cc88fa2c059bfcc39a6e5e219f301d877ba4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"if [ \"$MASTER_MINOR\" \u003d \"$TAG_MINOR\" ]"},{"line_number":37,"context_line":"then"},{"line_number":38,"context_line":"    echo \"Skipping $TAG which shares master\u0027s $MASTER_MINOR version.\""},{"line_number":39,"context_line":"    exit 0"},{"line_number":40,"context_line":"fi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# If the tag is for an earlier version than master\u0027s, skip"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3acd31a7_7446af24","line":39,"updated":"2015-04-30 17:58:44.000000000","message":"Would it make sense to exit 1 to indicate we failed to merge the tag in? Its expected behavior but might be handy to distinguish between the sets of behaviors.","commit_id":"0a831e194288951510b11c12af52fcda002655cb"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"57b85429bb26e35133e422ba33449b90bdf3510f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"if [ \"$MASTER_MINOR\" \u003d \"$TAG_MINOR\" ]"},{"line_number":37,"context_line":"then"},{"line_number":38,"context_line":"    echo \"Skipping $TAG which shares master\u0027s $MASTER_MINOR version.\""},{"line_number":39,"context_line":"    exit 0"},{"line_number":40,"context_line":"fi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# If the tag is for an earlier version than master\u0027s, skip"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3acd31a7_545f3341","line":39,"in_reply_to":"3acd31a7_7446af24","updated":"2015-04-30 18:10:55.000000000","message":"Problem is that causes job failures in post. I suppose that\u0027s not harmful, just unsightly. Not merging a tag we don\u0027t want to merge (a no-op) seems successful to me?","commit_id":"0a831e194288951510b11c12af52fcda002655cb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bf92cc88fa2c059bfcc39a6e5e219f301d877ba4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"fi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# If the tag is for an earlier version than master\u0027s, skip"},{"line_number":43,"context_line":"if [ `echo \"$MASTER_MINOR\\n$TAG_MINOR\"|sort -n` \u003d \"$TAG_MINOR $MASTER_MINOR\" ]"},{"line_number":44,"context_line":"then"},{"line_number":45,"context_line":"    echo \"Skipping $TAG which sorts before master\u0027s $MASTER_MINOR version.\""},{"line_number":46,"context_line":"    exit 0"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3acd31a7_b4944737","line":43,"updated":"2015-04-30 17:58:44.000000000","message":"Testing this I don\u0027t think the results are quite what we want.\n\n  $ echo \"1.2\\n1.2\"|sort -n\n  1.2\\n1.2","commit_id":"0a831e194288951510b11c12af52fcda002655cb"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"57b85429bb26e35133e422ba33449b90bdf3510f","unresolved":false,"context_lines":[{"line_number":40,"context_line":"fi"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"# If the tag is for an earlier version than master\u0027s, skip"},{"line_number":43,"context_line":"if [ `echo \"$MASTER_MINOR\\n$TAG_MINOR\"|sort -n` \u003d \"$TAG_MINOR $MASTER_MINOR\" ]"},{"line_number":44,"context_line":"then"},{"line_number":45,"context_line":"    echo \"Skipping $TAG which sorts before master\u0027s $MASTER_MINOR version.\""},{"line_number":46,"context_line":"    exit 0"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3acd31a7_b4368701","line":43,"in_reply_to":"3acd31a7_b4944737","updated":"2015-04-30 18:10:55.000000000","message":"I hadn\u0027t yet tested this since it was just a rough sketch. I have working shell on the way in the next patch.","commit_id":"0a831e194288951510b11c12af52fcda002655cb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"bf92cc88fa2c059bfcc39a6e5e219f301d877ba4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"if [ `echo \"$MASTER_MINOR\\n$TAG_MINOR\"|sort -n` \u003d \"$TAG_MINOR $MASTER_MINOR\" ]"},{"line_number":44,"context_line":"then"},{"line_number":45,"context_line":"    echo \"Skipping $TAG which sorts before master\u0027s $MASTER_MINOR version.\""},{"line_number":46,"context_line":"    exit 0"},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"git merge --no-edit -s ours $TAG"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3acd31a7_b46327b1","line":46,"updated":"2015-04-30 17:58:44.000000000","message":"And we could exit 2 here (or also 1).","commit_id":"0a831e194288951510b11c12af52fcda002655cb"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"57b85429bb26e35133e422ba33449b90bdf3510f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"if [ `echo \"$MASTER_MINOR\\n$TAG_MINOR\"|sort -n` \u003d \"$TAG_MINOR $MASTER_MINOR\" ]"},{"line_number":44,"context_line":"then"},{"line_number":45,"context_line":"    echo \"Skipping $TAG which sorts before master\u0027s $MASTER_MINOR version.\""},{"line_number":46,"context_line":"    exit 0"},{"line_number":47,"context_line":"fi"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"git merge --no-edit -s ours $TAG"}],"source_content_type":"text/x-sh","patch_set":1,"id":"3acd31a7_f42cffac","line":46,"in_reply_to":"3acd31a7_b46327b1","updated":"2015-04-30 18:10:55.000000000","message":"We could, similar argument. If you feel strongly, we can come to some agreement on what success and failure mean in the scope of this job.","commit_id":"0a831e194288951510b11c12af52fcda002655cb"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"d42ff135bbe25f288a5366cf3cb6436e3325b28f","unresolved":false,"context_lines":[{"line_number":46,"context_line":"fi"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# If the tag is for an earlier version than master\u0027s, skip"},{"line_number":49,"context_line":"if [ \"$(echo $(echo -e \"$MASTER_MINOR\\n$TAG_MINOR\"|sort -n))\" \\"},{"line_number":50,"context_line":"    \u003d \"$TAG_MINOR $MASTER_MINOR\" ]"},{"line_number":51,"context_line":"then"},{"line_number":52,"context_line":"    echo \"Skipping $TAG which sorts before master\u0027s $MASTER_MINOR version.\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3acd31a7_673a8338","line":49,"updated":"2015-04-30 18:26:52.000000000","message":"This outer echo should not be wrapped in $(), doing so attempts to run the sorted list of versions as a command.","commit_id":"cb694af9406d0ba34fcccd8d91b38e0bd04dcf86"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2a799c68224f81b27a7a30f5c4123035d405d468","unresolved":false,"context_lines":[{"line_number":46,"context_line":"fi"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# If the tag is for an earlier version than master\u0027s, skip"},{"line_number":49,"context_line":"if [ \"$(echo $(echo -e \"$MASTER_MINOR\\n$TAG_MINOR\"|sort -n))\" \\"},{"line_number":50,"context_line":"    \u003d \"$TAG_MINOR $MASTER_MINOR\" ]"},{"line_number":51,"context_line":"then"},{"line_number":52,"context_line":"    echo \"Skipping $TAG which sorts before master\u0027s $MASTER_MINOR version.\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"3acd31a7_c7c71711","line":49,"in_reply_to":"3acd31a7_673a8338","updated":"2015-04-30 18:31:30.000000000","message":"Fungi has correctly pointed out that since this is run within [] the shell does not try to interpret these versions as a command.","commit_id":"cb694af9406d0ba34fcccd8d91b38e0bd04dcf86"}]}
