)]}'
{"nodepool/elements/cache-devstack/install.d/50-download-pkgs":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"36cfad4ebed5f5c11e1beccf2ed7c344b43d53f3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        if grep \"^CentOS release 6\" /etc/redhat-release ; then"},{"line_number":27,"context_line":"            # --downloadonly is provided by the yum-plugin-downloadonly"},{"line_number":28,"context_line":"            # package on CentOS 6.x"},{"line_number":29,"context_line":"            yum install -y yum-plugin-downloadonly"},{"line_number":30,"context_line":"            # some packages may depend on python-setuptools, which is not"},{"line_number":31,"context_line":"            # installed and cannot be reinstalled on CentOS 6.x once yum"},{"line_number":32,"context_line":"            # has erased them, so use --skip-broken to avoid aborting; also"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1aca2d91_c001ef07","line":29,"updated":"2015-05-09 07:07:11.000000000","message":"Should this really be inside the loop and not before as previously?","commit_id":"09e3d7b7cb2c5070f7c7a1652b2eeeb1910ee7ba"},{"author":{"_account_id":10035,"name":"greghaynes","email":"greg@greghaynes.net","username":"greghaynes"},"change_message_id":"6a09b5d44f29ccc57c8dfe10464aac17976b7363","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        if grep \"^CentOS release 6\" /etc/redhat-release ; then"},{"line_number":27,"context_line":"            # --downloadonly is provided by the yum-plugin-downloadonly"},{"line_number":28,"context_line":"            # package on CentOS 6.x"},{"line_number":29,"context_line":"            yum install -y yum-plugin-downloadonly"},{"line_number":30,"context_line":"            # some packages may depend on python-setuptools, which is not"},{"line_number":31,"context_line":"            # installed and cannot be reinstalled on CentOS 6.x once yum"},{"line_number":32,"context_line":"            # has erased them, so use --skip-broken to avoid aborting; also"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9af37de9_5d90b695","line":29,"in_reply_to":"1aca2d91_51b48f80","updated":"2015-05-11 07:12:51.000000000","message":"I think Andreas is right that this could be moved out though, otherwise were going to be running an extra yum-install per package we want to install (and yum is actually pretty inefficient per invocation due to it updating indexes).","commit_id":"09e3d7b7cb2c5070f7c7a1652b2eeeb1910ee7ba"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3fc3be4bafc420b121935fe69c0827a6aba7e425","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        if grep \"^CentOS release 6\" /etc/redhat-release ; then"},{"line_number":27,"context_line":"            # --downloadonly is provided by the yum-plugin-downloadonly"},{"line_number":28,"context_line":"            # package on CentOS 6.x"},{"line_number":29,"context_line":"            yum install -y yum-plugin-downloadonly"},{"line_number":30,"context_line":"            # some packages may depend on python-setuptools, which is not"},{"line_number":31,"context_line":"            # installed and cannot be reinstalled on CentOS 6.x once yum"},{"line_number":32,"context_line":"            # has erased them, so use --skip-broken to avoid aborting; also"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"1aca2d91_51b48f80","line":29,"in_reply_to":"1aca2d91_c001ef07","updated":"2015-05-09 14:38:12.000000000","message":"It was really only there to support CentOS 6.x but was safe to run everywhere so we didn\u0027t need the platform identification code for it. Now that we\u0027re stuck checking for CentOS 6.x we might as well only run this in the one place it\u0027s needed instead.","commit_id":"09e3d7b7cb2c5070f7c7a1652b2eeeb1910ee7ba"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"1e06a132b3ba8c8ef5744109f6dadbfa91937c76","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        if grep \"^CentOS release 6\" /etc/redhat-release ; then"},{"line_number":27,"context_line":"            # --downloadonly is provided by the yum-plugin-downloadonly"},{"line_number":28,"context_line":"            # package on CentOS 6.x"},{"line_number":29,"context_line":"            yum install -y yum-plugin-downloadonly"},{"line_number":30,"context_line":"            # some packages may depend on python-setuptools, which is not"},{"line_number":31,"context_line":"            # installed and cannot be reinstalled on CentOS 6.x once yum"},{"line_number":32,"context_line":"            # has erased them, so use --skip-broken to avoid aborting; also"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"5ad58531_8d5e0175","line":29,"in_reply_to":"9af37de9_5d90b695","updated":"2015-05-11 19:29:45.000000000","message":"Oh, whoops. Somehow I missed that we were inside a loop here.","commit_id":"09e3d7b7cb2c5070f7c7a1652b2eeeb1910ee7ba"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"00e9a2b7590be8ae7e43326f4f209dbd0483f882","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        # --ignore-missing conflicts with set -e, so force it to be ok"},{"line_number":30,"context_line":"        apt-get -y --ignore-missing -d install $line || true"},{"line_number":31,"context_line":"    else"},{"line_number":32,"context_line":"        if grep \"^CentOS release 6\" /etc/redhat-release ; then"},{"line_number":33,"context_line":"            # some packages may depend on python-setuptools, which is not"},{"line_number":34,"context_line":"            # installed and cannot be reinstalled on CentOS 6.x once yum"},{"line_number":35,"context_line":"            # has erased them, so use --skip-broken to avoid aborting; also"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"9a0c5dc1_8c770c02","line":32,"updated":"2015-05-12 15:25:49.000000000","message":"Should just set a flag for this earlier and not access the file over and over.","commit_id":"514db315043746d0e7800c7dafb9b7a522189c73"}],"nodepool/scripts/cache_devstack.py":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"36cfad4ebed5f5c11e1beccf2ed7c344b43d53f3","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            for uca in sorted(UCA_POCKETS):"},{"line_number":170,"context_line":"                cache_debs(branch_data[\u0027debs\u0027], uca)"},{"line_number":171,"context_line":"        elif branch_data.get(\u0027rpms\u0027):"},{"line_number":172,"context_line":"            if (os.path.exists(\u0027/etc/redhat-release\u0027) and"},{"line_number":173,"context_line":"                    open(\u0027/etc/redhat-release\u0027).read().startswith("},{"line_number":174,"context_line":"                    \"CentOS release 6\")):"},{"line_number":175,"context_line":"                # --downloadonly is provided by the yum-plugin-downloadonly"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_9b012608","line":172,"updated":"2015-05-09 07:07:11.000000000","message":"Same question: Inside the loop or better outside?","commit_id":"09e3d7b7cb2c5070f7c7a1652b2eeeb1910ee7ba"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3fc3be4bafc420b121935fe69c0827a6aba7e425","unresolved":false,"context_lines":[{"line_number":169,"context_line":"            for uca in sorted(UCA_POCKETS):"},{"line_number":170,"context_line":"                cache_debs(branch_data[\u0027debs\u0027], uca)"},{"line_number":171,"context_line":"        elif branch_data.get(\u0027rpms\u0027):"},{"line_number":172,"context_line":"            if (os.path.exists(\u0027/etc/redhat-release\u0027) and"},{"line_number":173,"context_line":"                    open(\u0027/etc/redhat-release\u0027).read().startswith("},{"line_number":174,"context_line":"                    \"CentOS release 6\")):"},{"line_number":175,"context_line":"                # --downloadonly is provided by the yum-plugin-downloadonly"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_31b9137a","line":172,"in_reply_to":"1aca2d91_9b012608","updated":"2015-05-09 14:38:12.000000000","message":"Same answer: only needed here anyway.","commit_id":"09e3d7b7cb2c5070f7c7a1652b2eeeb1910ee7ba"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"00e9a2b7590be8ae7e43326f4f209dbd0483f882","unresolved":false,"context_lines":[{"line_number":176,"context_line":"        elif branch_data.get(\u0027rpms\u0027):"},{"line_number":177,"context_line":"            if (os.path.exists(\u0027/etc/redhat-release\u0027) and"},{"line_number":178,"context_line":"                    open(\u0027/etc/redhat-release\u0027).read().startswith("},{"line_number":179,"context_line":"                    \"CentOS release 6\")):"},{"line_number":180,"context_line":"                # some packages may depend on python-setuptools, which is not"},{"line_number":181,"context_line":"                # installed and cannot be reinstalled on CentOS 6.x once yum"},{"line_number":182,"context_line":"                # has erased them, so use --skip-broken to avoid aborting; also"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0c5dc1_4c60f435","line":179,"updated":"2015-05-12 15:25:49.000000000","message":"Here too.","commit_id":"514db315043746d0e7800c7dafb9b7a522189c73"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"8e4b8cda173b5ea2492f3a7805fad2decb71f59f","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        centos6 \u003d True"},{"line_number":169,"context_line":"        run_local([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027yum-plugin-downloadonly\u0027])"},{"line_number":170,"context_line":"    else:"},{"line_number":171,"context_line":"        centos6 \u003d False"},{"line_number":172,"context_line":"    branches \u003d local_prep(distribution)"},{"line_number":173,"context_line":"    image_filenames \u003d []"},{"line_number":174,"context_line":"    for branch_data in branches:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a0c5dc1_ccb0648e","line":171,"updated":"2015-05-12 15:28:38.000000000","message":"Oh, I should also just leave this where it was originally!","commit_id":"3d5b04ed192e0b1f808de6b3a1b2402efd33b914"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"efb4d44d8df4091057fc93cdaf9eaa5e8f927859","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        centos6 \u003d True"},{"line_number":169,"context_line":"        run_local([\u0027sudo\u0027, \u0027yum\u0027, \u0027install\u0027, \u0027-y\u0027, \u0027yum-plugin-downloadonly\u0027])"},{"line_number":170,"context_line":"    else:"},{"line_number":171,"context_line":"        centos6 \u003d False"},{"line_number":172,"context_line":"    branches \u003d local_prep(distribution)"},{"line_number":173,"context_line":"    image_filenames \u003d []"},{"line_number":174,"context_line":"    for branch_data in branches:"}],"source_content_type":"text/x-python","patch_set":4,"id":"9a0c5dc1_479b2fca","line":171,"in_reply_to":"9a0c5dc1_ccb0648e","updated":"2015-05-12 15:31:20.000000000","message":"No, wait, this is cleaner if I want to avoid passing around the centos6 flag between functions.","commit_id":"3d5b04ed192e0b1f808de6b3a1b2402efd33b914"}]}