)]}'
{"jenkins/jobs/kolla.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"dd089e6da0372f766d5a6aab26521ae8683c1e17","unresolved":false,"context_lines":[{"line_number":6,"context_line":"      - link-logs"},{"line_number":7,"context_line":"      - net-info"},{"line_number":8,"context_line":"      - gerrit-git-prep"},{"line_number":9,"context_line":"      - shell: |"},{"line_number":10,"context_line":"          \u0027tools/pre-commit-hook\u0027"},{"line_number":11,"context_line":"          \u0027tox -e setupenv\u0027"},{"line_number":12,"context_line":"          \u0027tox -e images\u0027"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a016987_dfbec3fe","line":9,"updated":"2015-05-14 19:34:25.000000000","message":"I\u0027m assuming you want failures of any of the following commands to also fail the job. I\u0027d add a line here like:\n\n          #!/bin/bash -ex","commit_id":"7b83e376e523691821209663d0a779b98dd1159b"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"dd089e6da0372f766d5a6aab26521ae8683c1e17","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      - shell: |"},{"line_number":10,"context_line":"          \u0027tools/pre-commit-hook\u0027"},{"line_number":11,"context_line":"          \u0027tox -e setupenv\u0027"},{"line_number":12,"context_line":"          \u0027tox -e images\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    publishers:"},{"line_number":15,"context_line":"      - console-log"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a016987_df55a3c6","line":12,"updated":"2015-05-14 19:34:25.000000000","message":"This entire indented block is a raw shell script, so you need to remove the quoting.","commit_id":"7b83e376e523691821209663d0a779b98dd1159b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"194e2f4c15c2afcd7cb10545ae99ee75cfbf5a66","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      - shell: |"},{"line_number":10,"context_line":"          \u0027tools/pre-commit-hook\u0027"},{"line_number":11,"context_line":"          \u0027tox -e setupenv\u0027"},{"line_number":12,"context_line":"          \u0027tox -e images\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    publishers:"},{"line_number":15,"context_line":"      - console-log"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a016987_8430fe57","line":12,"updated":"2015-05-14 19:18:29.000000000","message":"This might work but it\u0027s the first time I see it this way.\n\nOther places have constructs like:\n      - shell: |\n          #!/bin/bash -xe\n          mkdir -p gerrit\n\nso, without the quotes and with a shebang line.\n\nAlso, I wonder why you really want three lines here, you could use a single tox environment for this - saves you setting up the environment another time.","commit_id":"7b83e376e523691821209663d0a779b98dd1159b"},{"author":{"_account_id":3098,"name":"Jeff Peeler","email":"jpeeler@redhat.com","username":"jpeeler-z"},"change_message_id":"3a20d7522d4c3d758fbd3422ef76a3007b974325","unresolved":false,"context_lines":[{"line_number":9,"context_line":"      - shell: |"},{"line_number":10,"context_line":"          \u0027tools/pre-commit-hook\u0027"},{"line_number":11,"context_line":"          \u0027tox -e setupenv\u0027"},{"line_number":12,"context_line":"          \u0027tox -e images\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"    publishers:"},{"line_number":15,"context_line":"      - console-log"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a016987_7f522f15","line":12,"in_reply_to":"7a016987_8430fe57","updated":"2015-05-14 19:33:24.000000000","message":"Ok, I like the -x and if -e is necessary, fine. I\u0027ll go ahead and remove the first tox invocation since all it does it call setup_docker.sh. Thanks for the fast review!","commit_id":"7b83e376e523691821209663d0a779b98dd1159b"},{"author":{"_account_id":2834,"name":"Steven Dake","email":"steven.dake@gmail.com","username":"sdake"},"change_message_id":"bc8f76be6314914c2723566148aced285b2eee1b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      - gerrit-git-prep"},{"line_number":9,"context_line":"      - shell: |"},{"line_number":10,"context_line":"          #!/bin/bash -xe"},{"line_number":11,"context_line":"          tools/pre-commit-hook"},{"line_number":12,"context_line":"          tests/setup_docker.sh"},{"line_number":13,"context_line":"          tox -e images"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a016987_5f5893fa","line":11,"updated":"2015-05-14 19:34:41.000000000","message":"we don\u0027t need pre-commit-hook that is already gated in pep8","commit_id":"c3d58183729794fc88b1d4709c3470d8031b2983"}]}
