)]}'
{"jenkins/jobs/networking-odl.yaml":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"57cf565f99a2d1f01f82a0e544bc4f3e2c0e2f6b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"              fi"},{"line_number":60,"context_line":"          }}"},{"line_number":61,"context_line":"          export -f post_test_hook"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":64,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_95ab191d","line":62,"updated":"2015-06-16 20:12:26.000000000","message":"The \"if -f\" reads funny.  Why make a hook if it\u0027s not going to be used?  You want it to fail silently?","commit_id":"8572f62dea44365f7c42ab0adc960b66c6396588"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"22670164cbe4fd3efc4d82c5ac5e086469c50e08","unresolved":false,"context_lines":[{"line_number":59,"context_line":"              fi"},{"line_number":60,"context_line":"          }}"},{"line_number":61,"context_line":"          export -f post_test_hook"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":64,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_d0144f45","line":62,"in_reply_to":"fa32b979_95ab191d","updated":"2015-06-16 20:15:29.000000000","message":"we either do that, or make this depends-on the patch that introduce these files, or we add the files first, either way, it\u0027s a safety net, but I agree it\u0027s a bit smelly, rather than funny.","commit_id":"8572f62dea44365f7c42ab0adc960b66c6396588"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"2c60ed963a6f4c208f7f1a781d27d74c7d6fe9d1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"              fi"},{"line_number":60,"context_line":"          }}"},{"line_number":61,"context_line":"          export -f post_test_hook"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":64,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa32b979_12db9c50","line":62,"in_reply_to":"fa32b979_d0144f45","updated":"2015-06-16 20:44:27.000000000","message":"For what it\u0027s worth, https://review.openstack.org/192432 adds the files, and https://review.openstack.org/192433 removes some config from here. I could insert this one in the middle.\n\nNote that we\u0027re not adding a post_test_hook.sh yet, though we certainly could. The \"if -f\" allows for that in any case.","commit_id":"8572f62dea44365f7c42ab0adc960b66c6396588"}]}
