)]}'
{"nodepool/elements/puppet/install.d/10-puppet":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"c111834826cc80c33a3d1914064de3a131243fb3","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# setup puppet environment"},{"line_number":31,"context_line":"if [ ! -f \"/etc/puppet/environments/production/environment.conf\" ]; then"},{"line_number":32,"context_line":"    sudo mkdir -p /etc/puppet/environemtns/production"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"   # output default contents"},{"line_number":35,"context_line":"   sudo tee /etc/puppet/environments/production/environment.conf \u003c\u003cEOF"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"1a7b0d38_67b649de","line":32,"range":{"start_line":32,"start_character":30,"end_line":32,"end_character":42},"updated":"2015-12-23 12:48:22.000000000","message":"Is that correct or should it be environments ?","commit_id":"88e578cdd9007131ddd23beb1dc2f61bfb727ca1"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"04b543b03b96c1212a71c1b98c730ea17ad86f9d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"manifest \u003d /opt/system-config/production/manifests/site.pp"},{"line_number":37,"context_line":"modulepath \u003d $basemodulepath:modules:/opt/system-config/production/modules"},{"line_number":38,"context_line":"EOF"},{"line_number":39,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"fa69d971_24130b5d","line":39,"updated":"2016-01-05 02:28:07.000000000","message":"Yolanda, can you explain why this was added? It seems strange that we need to prepare environment.conf here while puppet.conf, hiera.yaml, etc are managed elsewhere.","commit_id":"c0ff244602f312731809a7a4567af4b9a5ad9708"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"44aa86c60aad697574d9db18bc0c30ae6378b882","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# setup puppet environment"},{"line_number":31,"context_line":"if [ ! -f \"/etc/puppet/environments/production/environment.conf\" ]; then"},{"line_number":32,"context_line":"    sudo mkdir -p /etc/puppet/environemtns/production"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"   # output default contents"},{"line_number":35,"context_line":"   sudo tee /etc/puppet/environments/production/environment.conf \u003c\u003cEOF"}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"fa69d971_4802cd3e","line":32,"range":{"start_line":32,"start_character":30,"end_line":32,"end_character":42},"updated":"2016-01-05 07:55:40.000000000","message":"You reintroduce the typo again: It should be environments","commit_id":"1715800f98a05b625ddbd59ea81ae4ebf7c95d4c"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"925c1df11499466e81374e4fd337e873d6848fce","unresolved":false,"context_lines":[{"line_number":31,"context_line":"if [ ! -f \"/etc/puppet/environments/production/environment.conf\" ]; then"},{"line_number":32,"context_line":"    sudo mkdir -p /etc/puppet/environments/production"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"   # output default contents"},{"line_number":35,"context_line":"   sudo tee /etc/puppet/environments/production/environment.conf \u003c\u003cEOF"},{"line_number":36,"context_line":"manifest \u003d /opt/system-config/production/manifests/site.pp"},{"line_number":37,"context_line":"modulepath \u003d $basemodulepath:modules:/opt/system-config/production/modules"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"fa69d971_6b9d4b09","line":34,"range":{"start_line":34,"start_character":4,"end_line":34,"end_character":5},"updated":"2016-01-05 08:24:24.000000000","message":"Add extra indent of one space to align here - like I did in patch set 5 which you reverted...","commit_id":"73e3ff3ed4dc9de0d0d3e436198a0a107bc0206a"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"13fc1a9043d533d3fbc9872a2b38731c21307f3e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"manifest \u003d /opt/system-config/production/manifests/site.pp"},{"line_number":37,"context_line":"modulepath \u003d $basemodulepath:modules:/opt/system-config/production/modules"},{"line_number":38,"context_line":"EOF"},{"line_number":39,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"da6ed579_efcb151d","line":39,"updated":"2016-01-11 23:07:02.000000000","message":"I\u0027m still wondering why this was added?","commit_id":"6c1f35ffcd07ae9c8b4a5308e4e91d2c5e43b46d"}],"tools/build-image.sh":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"04b543b03b96c1212a71c1b98c730ea17ad86f9d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"export CONFIG_REF\u003d${CONFIG_REF:-master}"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"disk-image-create -x --no-tmpfs -o $IMAGE_NAME $DISTRO-minimal \\"},{"line_number":27,"context_line":"    vm simple-init nodepool-base node-devstack"}],"source_content_type":"text/x-sh","patch_set":5,"id":"fa69d971_a42dbb96","line":27,"updated":"2016-01-05 02:28:07.000000000","message":"If I\u0027m reading this correctly, this patch\u0027s parent patch renames this file to build-nodepool-image.sh, why is it now build-image.sh in these last two patchsets?","commit_id":"c0ff244602f312731809a7a4567af4b9a5ad9708"}]}