)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9ed2f6a8644170a3d9bf58b3dd1f10d1a0d55865","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable VPN DevStack plugin for neutron client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that VPN has a devstack plugin, we need to make sure that"},{"line_number":10,"context_line":"it is enabled for the python-neutronclient. Will do this in"},{"line_number":11,"context_line":"two steps. Here, we\u0027ll add a gate hook so that the needed"},{"line_number":12,"context_line":"customization can be done."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a4dcd0f_b60fc3de","line":9,"updated":"2015-08-13 15:04:13.000000000","message":"Which is commit 9e19dc4f80806a0c3d125e459bd1d0566d61d2e9 - but that\u0027s only on master, that\u0027s not on stable/kilo, so how does this help kilo at all, which is blocked:\n\nhttp://logs.openstack.org/36/207736/1/check/gate-neutron-vpnaas-dsvm-functional-sswan/e6076d8/console.html.gz#_2015-08-06_08_35_24_982","commit_id":"f2a90159c1280b18ef78af6e94b465ae9f68b42e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"330e014a4ec08c18bcd28d12fd0d3a203f6e25eb","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Enable VPN DevStack plugin for neutron client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that VPN has a devstack plugin, we need to make sure that"},{"line_number":10,"context_line":"it is enabled for the python-neutronclient. Will do this in"},{"line_number":11,"context_line":"two steps. Here, we\u0027ll add a gate hook so that the needed"},{"line_number":12,"context_line":"customization can be done."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1a4dcd0f_57a88bdb","line":9,"in_reply_to":"1a4dcd0f_b60fc3de","updated":"2015-08-14 11:50:58.000000000","message":"This fix is targeted to master to fix the problem that neutronclient tests were failing on master because VPN devstack plugin was missing. It doesn\u0027t address the stable/kilo issue.","commit_id":"f2a90159c1280b18ef78af6e94b465ae9f68b42e"}],"jenkins/jobs/neutron.yaml":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"463222d94e73754c0e9911b69b7f46b45aac63aa","unresolved":false,"context_lines":[{"line_number":227,"context_line":"          fi"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"          function gate_hook {{"},{"line_number":230,"context_line":"              bash -xe $BASE/new/neutron/neutron/tests/contrib/gate_hook.sh dsvm-functional"},{"line_number":231,"context_line":"          }}"},{"line_number":232,"context_line":"          export -f gate_hook"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1a4dcd0f_7d594f34","line":230,"updated":"2015-08-06 16:44:57.000000000","message":"cut \u0026 paste from neutron gate hook. Wrong path. Matching to what is used in this project for post test hook.","commit_id":"227286e60e82f60ab2d34e0b0e28e697f52a055f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5cf1c09517455268d82953ff2d67bb552606a1a2","unresolved":false,"context_lines":[{"line_number":229,"context_line":"          function gate_hook {{"},{"line_number":230,"context_line":"              bash -xe $BASE/new/python-neutronclient/neutronclient/tests/functional/hooks/gate_hook.sh dsvm-functional"},{"line_number":231,"context_line":"          }}"},{"line_number":232,"context_line":"          export -f gate_hook"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"          function post_test_hook {{"},{"line_number":235,"context_line":"              # Configure and run functional tests"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a4dcd0f_70ff1502","line":232,"updated":"2015-08-13 09:39:13.000000000","message":"DEVSTACK_LOCAL_CONFIG does not work to enable vpnaas?\nIt is used for ec2-api jobs.\n\nexport DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin neutron-vpnaas git://git.openstack.org/openstack/neutron-vpnaas\"\n\nIn my understanding, what we need to make gate-neutronclient-dsvm-functional work again is just to enable VPNaaS.\nI don\u0027t understand why we need gate_hook for neutronclient.","commit_id":"1acec9f30d56654952d6f258703eafe5abc2c12e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"ee3430ad0a7a70dd0ad0f3d59b500e6b609645fb","unresolved":false,"context_lines":[{"line_number":229,"context_line":"          function gate_hook {{"},{"line_number":230,"context_line":"              bash -xe $BASE/new/python-neutronclient/neutronclient/tests/functional/hooks/gate_hook.sh dsvm-functional"},{"line_number":231,"context_line":"          }}"},{"line_number":232,"context_line":"          export -f gate_hook"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"          function post_test_hook {{"},{"line_number":235,"context_line":"              # Configure and run functional tests"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1a4dcd0f_d554d3fe","line":232,"in_reply_to":"1a4dcd0f_70ff1502","updated":"2015-08-13 10:58:49.000000000","message":"Yes, just setting DEVSTACK_LOCAL_CONFIG would suffice. However, the desire from Doug W, was to add a gate hook, so that this enable could be managed by neutron client repo and not require additional changes in prioject-config, if anything else was needed. Essentially adding flexibility.","commit_id":"1acec9f30d56654952d6f258703eafe5abc2c12e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"86347d6dfa493e81038c4921720d5561967c8de5","unresolved":false,"context_lines":[{"line_number":227,"context_line":"          fi"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"          function gate_hook {{"},{"line_number":230,"context_line":"              bash -xe $BASE/new/python-neutronclient/neutronclient/tests/functional/hooks/gate_hook.sh dsvm-functional"},{"line_number":231,"context_line":"          }}"},{"line_number":232,"context_line":"          export -f gate_hook"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a4dcd0f_400bde2b","line":230,"updated":"2015-08-14 14:46:41.000000000","message":"It seems you have the depends-on backwards between Ieeaca1375d68705509f4e05f10cb35c0fa0b9582 and this change.  If we merge this project-config change, the gate-neutronclient-dsvm-functional job is borked until Ieeaca1375d68705509f4e05f10cb35c0fa0b9582 is merged.\n\nI guess the problem is Ieeaca1375d68705509f4e05f10cb35c0fa0b9582 won\u0027t pass that test until this change is merged, so it\u0027s a circular dependency.\n\nYou should probably at least point out Ieeaca1375d68705509f4e05f10cb35c0fa0b9582 in the commit message as the change that adds the gate_hook.sh script so that people reviewing this are aware of both and know they need to land in tandem.","commit_id":"f2a90159c1280b18ef78af6e94b465ae9f68b42e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3b9616cbd64ee78052c73662d6a13c722e0356b5","unresolved":false,"context_lines":[{"line_number":227,"context_line":"          fi"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"          function gate_hook {{"},{"line_number":230,"context_line":"              bash -xe $BASE/new/python-neutronclient/neutronclient/tests/functional/hooks/gate_hook.sh dsvm-functional"},{"line_number":231,"context_line":"          }}"},{"line_number":232,"context_line":"          export -f gate_hook"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1a4dcd0f_4b945f43","line":230,"in_reply_to":"1a4dcd0f_400bde2b","updated":"2015-08-14 14:54:45.000000000","message":"Maybe I should do 3 commits?  One that adds gate-hook to neutron client, one that adds the gatehook call in project-config, and one that uncomments the VPN tests in neutronclient to test the gate? This way there is no breakage?","commit_id":"f2a90159c1280b18ef78af6e94b465ae9f68b42e"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"49fc4a0eb7c868c3732b282c8b83a8f7aa6446cd","unresolved":false,"context_lines":[{"line_number":266,"context_line":"          fi"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"          function gate_hook {{"},{"line_number":269,"context_line":"              bash -xe $BASE/new/python-neutronclient/neutronclient/tests/functional/hooks/gate_hook.sh {whichtest}"},{"line_number":270,"context_line":"          }}"},{"line_number":271,"context_line":"          export -f gate_hook"},{"line_number":272,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa1b9901_fd2a037e","line":269,"updated":"2015-08-17 10:46:05.000000000","message":"Typo. Changed name and missed hyphen.","commit_id":"29f2e6b9a33215357d5a12a59a783b81144b4926"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d991552c29900124b5495cc70fa852540904345c","unresolved":false,"context_lines":[{"line_number":250,"context_line":"          fi"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"          function gate_hook {{"},{"line_number":253,"context_line":"              bash -xe $BASE/new/python-neutronclient/neutronclient/tests/functional/hooks/gate_hook.sh {which-test}"},{"line_number":254,"context_line":"          }}"},{"line_number":255,"context_line":"          export -f gate_hook"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba15a1d1_24c137e5","line":253,"updated":"2015-09-14 02:57:44.000000000","message":"be nice to make this consistent","commit_id":"fd77f4c0733f5f4398c4273d42b796b716e6761f"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"5807d55a4fcd7bf9ba55a25982dd4ea88f5aa789","unresolved":false,"context_lines":[{"line_number":250,"context_line":"          fi"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"          function gate_hook {{"},{"line_number":253,"context_line":"              bash -xe $BASE/new/python-neutronclient/neutronclient/tests/functional/hooks/gate_hook.sh {which-test}"},{"line_number":254,"context_line":"          }}"},{"line_number":255,"context_line":"          export -f gate_hook"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba15a1d1_650abfd4","line":253,"in_reply_to":"ba15a1d1_24c137e5","updated":"2015-09-14 11:37:17.000000000","message":"Do you mean to use (or not use) \"bash -xe ...\" on both the gate and post test hooks?\n\nI frankly am not sure which way is correct, can you advise?","commit_id":"fd77f4c0733f5f4398c4273d42b796b716e6761f"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"a93d1cecee4ecc7ff1a6cbae87fed6324eb452d7","unresolved":false,"context_lines":[{"line_number":250,"context_line":"          fi"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"          function gate_hook {{"},{"line_number":253,"context_line":"              bash -xe $BASE/new/python-neutronclient/neutronclient/tests/functional/hooks/gate_hook.sh {which-test}"},{"line_number":254,"context_line":"          }}"},{"line_number":255,"context_line":"          export -f gate_hook"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":10,"id":"ba15a1d1_c30a87d2","line":253,"in_reply_to":"ba15a1d1_650abfd4","updated":"2015-09-14 23:56:45.000000000","message":"it should not really be necessary, if the file is already executable","commit_id":"fd77f4c0733f5f4398c4273d42b796b716e6761f"}],"zuul/layout.yaml":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"7ad51be8b64c3cdf8fd501559342fe770a38ee76","unresolved":false,"context_lines":[{"line_number":3168,"context_line":"    experimental:"},{"line_number":3169,"context_line":"      - gate-grenade-dsvm-forward"},{"line_number":3170,"context_line":"      - gate-neutronclient-test-dsvm-functional"},{"line_number":3171,"context_line":"      - gate-neutronclient-test-dsvm-functional-vpn"},{"line_number":3172,"context_line":""},{"line_number":3173,"context_line":"  - name: openstack/python-novaclient"},{"line_number":3174,"context_line":"    template:"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fa1b9901_fda8118e","line":3171,"updated":"2015-08-20 12:15:25.000000000","message":"The neutron team needs to decide if they want to have one job to replace the existing job (only using plugins in the gate-hook.sh), have one job for each major advanced service (like what is proposed here), or have one job for core and another for all advanced services (implying a name change to job).","commit_id":"d37563c861b88013c4aec994678eda9a0cad50db"}]}