)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"dbb7460d93e6c849629967b560a671d79cae731e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     madhusudhan-kandadai \u003cmadhusudhan.openstack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-11 15:31:35 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set experimental gate for neutron-vpnaas api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add experimental gate job to run neutron-vpnaas api tests"},{"line_number":10,"context_line":"clean up job template so we can have only one"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_55dc9572","line":7,"updated":"2015-08-11 23:00:22.000000000","message":"nit: experimental job, not gate.","commit_id":"a924677f3d34f99d0171e271961392308ed7926d"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"a1e5275c772db39e0e5ae9e291de0fbf63f8dd9b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     madhusudhan-kandadai \u003cmadhusudhan.openstack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-11 15:31:35 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set experimental gate for neutron-vpnaas api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add experimental gate job to run neutron-vpnaas api tests"},{"line_number":10,"context_line":"clean up job template so we can have only one"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_f01a8f6e","line":7,"in_reply_to":"1a4dcd0f_55dc9572","updated":"2015-08-11 23:38:54.000000000","message":"thanks, noted :)","commit_id":"a924677f3d34f99d0171e271961392308ed7926d"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"dbb7460d93e6c849629967b560a671d79cae731e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set experimental gate for neutron-vpnaas api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add experimental gate job to run neutron-vpnaas api tests"},{"line_number":10,"context_line":"clean up job template so we can have only one"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id4614ea1103a9ecc9b069f0b9cd47c0e385f9eba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_75c75198","line":9,"updated":"2015-08-11 23:00:22.000000000","message":"nit: just \"add experimental job\", it\u0027s not in the gate.","commit_id":"a924677f3d34f99d0171e271961392308ed7926d"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"a1e5275c772db39e0e5ae9e291de0fbf63f8dd9b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set experimental gate for neutron-vpnaas api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add experimental gate job to run neutron-vpnaas api tests"},{"line_number":10,"context_line":"clean up job template so we can have only one"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id4614ea1103a9ecc9b069f0b9cd47c0e385f9eba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a4dcd0f_b02727b5","line":9,"in_reply_to":"1a4dcd0f_75c75198","updated":"2015-08-11 23:38:54.000000000","message":"ah, corrected :)","commit_id":"a924677f3d34f99d0171e271961392308ed7926d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"778ee196540e81845df2273d00de6f4124c77793","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set experimental job for neutron-vpnaas api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add experimental job to run neutron-vpnaas api tests"},{"line_number":10,"context_line":"clean up job template so we can have only one"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id4614ea1103a9ecc9b069f0b9cd47c0e385f9eba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_a9d80154","line":10,"updated":"2015-08-12 15:14:58.000000000","message":"Good idea about the cleanup, however I have one concern. As implemented in the neutron-vpnaas patch, there would be a time period where tests will fail (until this commit goes in).\n\nI suggest that this commit depend on the other, and that the other commit accept both the old and new VENV names, so that tests don\u0027t fail between the time that commit upstreams and this one upstreams.\n\nAlternatively (better), you could separate the two efforts.","commit_id":"b8576b086fa4a2fb4042684371f94e62256ef781"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"dae9096929b3ed59bba1709ae91eef3bb2e99a59","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set experimental job for neutron-vpnaas api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add experimental job to run neutron-vpnaas api tests"},{"line_number":10,"context_line":"clean up job template so we can have only one"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id4614ea1103a9ecc9b069f0b9cd47c0e385f9eba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_f87a4db9","line":10,"in_reply_to":"1a4dcd0f_0c2903e6","updated":"2015-08-12 16:49:52.000000000","message":"Just to be clear the neutron-vpnaas code should accept both names, then, once upstreamed, this change can upstream, and then the old names can be removed from the neutron-vpnaas hook code.","commit_id":"b8576b086fa4a2fb4042684371f94e62256ef781"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"88cbd716b24f118d6fcf252f2f8b90f8de7ed264","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set experimental job for neutron-vpnaas api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add experimental job to run neutron-vpnaas api tests"},{"line_number":10,"context_line":"clean up job template so we can have only one"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id4614ea1103a9ecc9b069f0b9cd47c0e385f9eba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_0c2903e6","line":10,"in_reply_to":"1a4dcd0f_a9d80154","updated":"2015-08-12 15:40:37.000000000","message":"+1 for your suggestion, I agree that this patch needs to be merged if we want to test the new VENV names and check if that is working.\n\nI can add a dependent of the other patch here. Thanks!","commit_id":"b8576b086fa4a2fb4042684371f94e62256ef781"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"806d549d8e3c5ad8889ada7900e245cdb7bb68b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set experimental job for neutron-vpnaas api tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add experimental job to run neutron-vpnaas api tests"},{"line_number":10,"context_line":"clean up job template so we can have only one"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id4614ea1103a9ecc9b069f0b9cd47c0e385f9eba"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a4dcd0f_95c2ea32","line":10,"in_reply_to":"1a4dcd0f_f87a4db9","updated":"2015-08-12 20:20:18.000000000","message":"Got you. For this patch, I marked all the new jobs as experimental and leaving the old jobs untouched so it should not affect the vpnaas hooks once this is in.\n\nOnce this new job is verified and tested, need to clean-up the job template and resubmit this patch","commit_id":"b8576b086fa4a2fb4042684371f94e62256ef781"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"b877a4a274867f2e4290005522da3805f22372d5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     madhusudhan-kandadai \u003cmadhusudhan.openstack@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-08-12 13:22:16 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set experimental job for all neutron-vpnaas tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Add experimental job to run neutron-vpnaas functional (openswan/strongswan)"},{"line_number":10,"context_line":"and api tests with one job template"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a4dcd0f_18f12f01","line":7,"updated":"2015-08-12 20:39:00.000000000","message":"nit: Set -\u003e Create","commit_id":"fb7368c05d152d5a878e95681b0c59406c6da424"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"b877a4a274867f2e4290005522da3805f22372d5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Set experimental job for all neutron-vpnaas tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Add experimental job to run neutron-vpnaas functional (openswan/strongswan)"},{"line_number":10,"context_line":"and api tests with one job template"},{"line_number":11,"context_line":"2. once this new job template verified and tested, clean up job template"},{"line_number":12,"context_line":"so we can have only one in future"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a4dcd0f_b8891b71","line":9,"updated":"2015-08-12 20:39:00.000000000","message":"nit Add experimental job -\u003e Add new experimental jobs","commit_id":"fb7368c05d152d5a878e95681b0c59406c6da424"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"b877a4a274867f2e4290005522da3805f22372d5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Add experimental job to run neutron-vpnaas functional (openswan/strongswan)"},{"line_number":10,"context_line":"and api tests with one job template"},{"line_number":11,"context_line":"2. once this new job template verified and tested, clean up job template"},{"line_number":12,"context_line":"so we can have only one in future"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note: This idea is chosen based on the community reviews so it should not affect"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a4dcd0f_38cbcba5","line":11,"updated":"2015-08-12 20:39:00.000000000","message":"clean up job template so we can have only one in future -\u003e remove old functional jobs and templates.","commit_id":"fb7368c05d152d5a878e95681b0c59406c6da424"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"dc48c0e1886e173281463262599d0059e1d94b3a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"vpn jobs in vpnaas repo and leaving them untouched"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id4614ea1103a9ecc9b069f0b9cd47c0e385f9eba"},{"line_number":18,"context_line":"Depends-On: I548ab4994582ee5f414796710a8a8845926455ed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_1fd81552","line":18,"updated":"2015-08-13 12:03:48.000000000","message":"I think the dependency is the other way around. This commit can be upstreamed w/o 211768, as the old jobs are still available, and then new jobs will be unused.\n\nOnce this is upstreamed and available, then 211768 review can run the experimental jobs to see if they (along with the hook changes) actually work.\n\nLatter commits can then remove the old jobs from project-config, and then the entries from the hook scripts.","commit_id":"8f1d427cbc13d5e6331156d04e1e310de81f0ab5"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"7b5362b16234d397498a6bb44f9e9e27605b70f1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"vpn jobs in vpnaas repo and leaving them untouched"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Id4614ea1103a9ecc9b069f0b9cd47c0e385f9eba"},{"line_number":18,"context_line":"Depends-On: I548ab4994582ee5f414796710a8a8845926455ed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1a4dcd0f_ca3dfbde","line":18,"in_reply_to":"1a4dcd0f_1fd81552","updated":"2015-08-13 17:56:04.000000000","message":"Yep. You are right. I just mentioned that info to help reviewers aware of that patch. Do I need to mention that commit in comment instead of Depends-On, so it can be useful?","commit_id":"8f1d427cbc13d5e6331156d04e1e310de81f0ab5"}],"jenkins/jobs/neutron-vpnaas.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"36ebf497a91bef8213da3a2a38d2f12a4ca7aedf","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":25,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":26,"context_line":"          fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"          function gate_hook {{"},{"line_number":29,"context_line":"              bash -xe $BASE/new/neutron-vpnaas/neutron_vpnaas/tests/contrib/gate_hook.sh dsvm-functional"},{"line_number":30,"context_line":"          }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a4dcd0f_90a28f4a","side":"PARENT","line":27,"updated":"2015-08-14 16:06:19.000000000","message":"nit: I prefer to keep these extra lines in, makes it easier to read - and that\u0027s what you did also with your new change.","commit_id":"9aa56dee8b64fb5bfbc3f3f35c0a74c23d8973e1"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"6e2cbed4c548bfb8a720f443804940f3682d7e59","unresolved":false,"context_lines":[{"line_number":24,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":25,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":26,"context_line":"          fi"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"          function gate_hook {{"},{"line_number":29,"context_line":"              bash -xe $BASE/new/neutron-vpnaas/neutron_vpnaas/tests/contrib/gate_hook.sh dsvm-functional"},{"line_number":30,"context_line":"          }}"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1a4dcd0f_932379a7","side":"PARENT","line":27,"in_reply_to":"1a4dcd0f_90a28f4a","updated":"2015-08-14 16:10:37.000000000","message":"sure. Thanks for the suggestion Andreas. Will take a note when submitting a new patch on this again in future!","commit_id":"9aa56dee8b64fb5bfbc3f3f35c0a74c23d8973e1"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"55bea3985a61c7fc0e619d887026ff822be4fd7d","unresolved":false,"context_lines":[{"line_number":108,"context_line":"          fi"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"          function gate_hook {{"},{"line_number":111,"context_line":"              bash -xe $BASE/new/neutron-vpnaas/neutron_vpnaas/tests/contrib/gate_hook.sh {vpnaastest}"},{"line_number":112,"context_line":"          }}"},{"line_number":113,"context_line":"          export -f gate_hook"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa1b9901_cbe5d1a8","line":111,"updated":"2015-08-18 02:14:31.000000000","message":"nit: since gate_hook.sh is a script, it should be executable and able to pick its own interpreter and shell args.","commit_id":"b707bead1b58cdab0365e29c451507dd92a84a33"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"55bea3985a61c7fc0e619d887026ff822be4fd7d","unresolved":false,"context_lines":[{"line_number":113,"context_line":"          export -f gate_hook"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"          function post_test_hook {{"},{"line_number":116,"context_line":"             bash -xe $BASE/new/neutron-vpnaas/neutron_vpnaas/tests/contrib/post_test_hook.sh {vpnaastest}"},{"line_number":117,"context_line":"          }}"},{"line_number":118,"context_line":"          export -f post_test_hook"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa1b9901_0bdc29e3","line":116,"updated":"2015-08-18 02:14:31.000000000","message":"Why three templates? Didn\u0027t you merge them all into one with a variable replacement?","commit_id":"b707bead1b58cdab0365e29c451507dd92a84a33"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3b2ffa559060428fe1d58999f626c6f9e96255a5","unresolved":false,"context_lines":[{"line_number":113,"context_line":"          export -f gate_hook"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"          function post_test_hook {{"},{"line_number":116,"context_line":"             bash -xe $BASE/new/neutron-vpnaas/neutron_vpnaas/tests/contrib/post_test_hook.sh {vpnaastest}"},{"line_number":117,"context_line":"          }}"},{"line_number":118,"context_line":"          export -f post_test_hook"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa1b9901_93636bdc","line":116,"in_reply_to":"fa1b9901_0bdc29e3","updated":"2015-08-18 17:45:27.000000000","message":"This new job would use different arguments for the hook scripts. If we remove the existing two templates, then tests will immediately fail, until the gate hook is updated.\n\nThe thought was to do the following:\n- Create new \u0027variable arg\u0027 template and new jobs (this commit).\n- Update hook scripts in VPN to support new args and test all 3 jobs\n- Once working, remove the two older jobs and make the new one voting.\n\nAlternately, could do this:\n- Add new variable args to hook scripts\n- Do this commit with new template (and remove 2 older templates)\n- Create a dummy VPN commit to test out the change and verify all 3 work\n\nThis has a bit more risk, IMHO, because we won\u0027t know if it breaks existing jobs, until step 3.","commit_id":"b707bead1b58cdab0365e29c451507dd92a84a33"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"612fa9cd742ed442279f35e280a63be22e474c74","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"          function post_test_hook {{"},{"line_number":116,"context_line":"             bash -xe $BASE/new/neutron-vpnaas/neutron_vpnaas/tests/contrib/post_test_hook.sh {vpnaastest}"},{"line_number":117,"context_line":"          }}"},{"line_number":118,"context_line":"          export -f post_test_hook"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa1b9901_47e626b1","line":117,"updated":"2015-08-19 22:15:06.000000000","message":"that\u0027s fine, but below the three templated jobs are added, which will be voting, and broken if the hooks aren\u0027t ready. was that an oversight?","commit_id":"b707bead1b58cdab0365e29c451507dd92a84a33"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"43ce71528ddf2cafc1fb4a3f11ef9166a769ca72","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"          function post_test_hook {{"},{"line_number":116,"context_line":"             bash -xe $BASE/new/neutron-vpnaas/neutron_vpnaas/tests/contrib/post_test_hook.sh {vpnaastest}"},{"line_number":117,"context_line":"          }}"},{"line_number":118,"context_line":"          export -f post_test_hook"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa1b9901_b280a2c1","line":117,"in_reply_to":"fa1b9901_47e626b1","updated":"2015-08-19 22:42:17.000000000","message":"I believe the three new jobs in this template are experimental and once this goes in, will leave \u0027check experimental\u0027 in: https://review.openstack.org/#/c/211768/\n\nPlease correct me if I am understanding wrongly.","commit_id":"b707bead1b58cdab0365e29c451507dd92a84a33"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"481adb95d1731476b8fa250a13f6c12e143580dd","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    publishers:"},{"line_number":124,"context_line":"      - test-results"},{"line_number":125,"context_line":"      - devstack-logs"},{"line_number":126,"context_line":"      - console-log"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa1b9901_f2e05a98","line":126,"updated":"2015-08-19 22:43:49.000000000","message":"btw am not sure why this has changed. Could you suggest what I am doing wrong here? need to have a new line after L126?","commit_id":"b707bead1b58cdab0365e29c451507dd92a84a33"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"41383e4a7929777d7ac3a87e5356935c89068a4c","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    publishers:"},{"line_number":124,"context_line":"      - test-results"},{"line_number":125,"context_line":"      - devstack-logs"},{"line_number":126,"context_line":"      - console-log"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba15a1d1_a9ad2233","line":126,"in_reply_to":"fa1b9901_f2e05a98","updated":"2015-09-14 01:46:49.000000000","message":"yes it seems you\u0027ve just dropped the newline at the end of the file","commit_id":"b707bead1b58cdab0365e29c451507dd92a84a33"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"612fa9cd742ed442279f35e280a63be22e474c74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fa1b9901_67eb2a79","line":127,"updated":"2015-08-19 22:15:06.000000000","message":"nit?","commit_id":"b707bead1b58cdab0365e29c451507dd92a84a33"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"b5bcc39d72d79b2ed11bbfc4e77bcad8b57319c3","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":39,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    publishers:"},{"line_number":42,"context_line":"      - test-results"},{"line_number":43,"context_line":"      - devstack-logs"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba15a1d1_5c65d1de","side":"PARENT","line":40,"updated":"2015-09-15 16:37:23.000000000","message":"I think you were asked to not remove these newlines.","commit_id":"a84eec902d86a438c50d8022e9de781246a9b714"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"891511ab13596eac3b3b951e9eb6042a4822af1e","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":39,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    publishers:"},{"line_number":42,"context_line":"      - test-results"},{"line_number":43,"context_line":"      - devstack-logs"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba15a1d1_bc4bcd86","side":"PARENT","line":40,"in_reply_to":"ba15a1d1_5c65d1de","updated":"2015-09-15 16:48:42.000000000","message":"Done","commit_id":"a84eec902d86a438c50d8022e9de781246a9b714"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"b5bcc39d72d79b2ed11bbfc4e77bcad8b57319c3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    publishers:"},{"line_number":124,"context_line":"      - test-results"},{"line_number":125,"context_line":"      - devstack-logs"},{"line_number":126,"context_line":"      - console-log"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba15a1d1_1c5f590f","line":126,"updated":"2015-09-15 16:37:23.000000000","message":"Similarly, the newline got removed from the end of this file.","commit_id":"426e96d1a0ec4c8778a7385141367e7afc3a5ea9"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"891511ab13596eac3b3b951e9eb6042a4822af1e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    publishers:"},{"line_number":124,"context_line":"      - test-results"},{"line_number":125,"context_line":"      - devstack-logs"},{"line_number":126,"context_line":"      - console-log"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ba15a1d1_dc4ec195","line":126,"in_reply_to":"ba15a1d1_1c5f590f","updated":"2015-09-15 16:48:42.000000000","message":"Done","commit_id":"426e96d1a0ec4c8778a7385141367e7afc3a5ea9"}],"jenkins/jobs/projects.yaml":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"dbb7460d93e6c849629967b560a671d79cae731e","unresolved":false,"context_lines":[{"line_number":988,"context_line":"      - \u0027{pipeline}-neutron-vpnaas-{vpnaastest}{branch-designator}\u0027:"},{"line_number":989,"context_line":"          pipeline: gate"},{"line_number":990,"context_line":"          node: \u0027devstack-precise || devstack-trusty\u0027"},{"line_number":991,"context_line":"          {vpnaastest}: dsvm-functional"},{"line_number":992,"context_line":"          branch-designator: \u0027\u0027"},{"line_number":993,"context_line":"          branch-override: default"},{"line_number":994,"context_line":"      - \u0027{pipeline}-neutron-vpnaas-{vpnaastest}{branch-designator}\u0027:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a4dcd0f_158b6d69","line":991,"updated":"2015-08-11 23:00:22.000000000","message":"no brackets here, or the two below.  also, don\u0027t put dsvm as part of the variable.","commit_id":"a924677f3d34f99d0171e271961392308ed7926d"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"a1e5275c772db39e0e5ae9e291de0fbf63f8dd9b","unresolved":false,"context_lines":[{"line_number":988,"context_line":"      - \u0027{pipeline}-neutron-vpnaas-{vpnaastest}{branch-designator}\u0027:"},{"line_number":989,"context_line":"          pipeline: gate"},{"line_number":990,"context_line":"          node: \u0027devstack-precise || devstack-trusty\u0027"},{"line_number":991,"context_line":"          {vpnaastest}: dsvm-functional"},{"line_number":992,"context_line":"          branch-designator: \u0027\u0027"},{"line_number":993,"context_line":"          branch-override: default"},{"line_number":994,"context_line":"      - \u0027{pipeline}-neutron-vpnaas-{vpnaastest}{branch-designator}\u0027:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1a4dcd0f_303c77c7","line":991,"in_reply_to":"1a4dcd0f_158b6d69","updated":"2015-08-11 23:38:54.000000000","message":"agreed. corrected!","commit_id":"a924677f3d34f99d0171e271961392308ed7926d"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"55bea3985a61c7fc0e619d887026ff822be4fd7d","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"          node: \u0027devstack-precise || devstack-trusty\u0027"},{"line_number":1013,"context_line":"          vpnaastest: api"},{"line_number":1014,"context_line":"          branch-designator: \u0027\u0027"},{"line_number":1015,"context_line":"          branch-override: default"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"- project:"},{"line_number":1018,"context_line":"    name: nova"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fa1b9901_6beda58a","line":1015,"updated":"2015-08-18 02:14:31.000000000","message":"And here I see you using one template, but there are three defined in the other file?","commit_id":"b707bead1b58cdab0365e29c451507dd92a84a33"},{"author":{"_account_id":14556,"name":"Madhusudhan Kandadai","email":"madhusudhan.openstack@gmail.com","username":"madhusudhan-kandadai"},"change_message_id":"9ba641287304640a396a2729bd89d32baa9c266d","unresolved":false,"context_lines":[{"line_number":1012,"context_line":"          node: \u0027devstack-precise || devstack-trusty\u0027"},{"line_number":1013,"context_line":"          vpnaastest: api"},{"line_number":1014,"context_line":"          branch-designator: \u0027\u0027"},{"line_number":1015,"context_line":"          branch-override: default"},{"line_number":1016,"context_line":""},{"line_number":1017,"context_line":"- project:"},{"line_number":1018,"context_line":"    name: nova"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ba15a1d1_3e07b41d","line":1015,"in_reply_to":"fa1b9901_6beda58a","updated":"2015-09-15 16:33:27.000000000","message":"commented in the other file - neutron-vpnaas.yaml\n\nHope that comment helps.","commit_id":"b707bead1b58cdab0365e29c451507dd92a84a33"}]}
