)]}'
{"jenkins/jobs/dragonflow.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"f388472c81a9bb0108050310d96b988b262bb871","unresolved":false,"context_lines":[{"line_number":79,"context_line":"          export KEEP_LOCALRC\u003d1"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"          function pre_test_hook {{"},{"line_number":82,"context_line":"              if [ -f $BASE/new/dragonflow/devstack/pre_test_hook.sh ] ; then"},{"line_number":83,"context_line":"                  . $BASE/new/dragonflow/devstack/pre_test_hook.sh"},{"line_number":84,"context_line":"              fi"},{"line_number":85,"context_line":"          }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da20952f_d9741d69","line":82,"updated":"2015-09-07 04:51:34.000000000","message":"I\u0027ve -1\u0027d changes for this before and I\u0027d prefer us not to do this\n\nThe reason why is that it introduces a point of potential silent failure.  If the pre_test_hook.sh goes missing, then we just continue on with no warning at all.  yes this is a small chance, but this type of idiom continues and silent failures are the *worst* possible outcome\n\nI\u0027d much rather see the jobs be robust and guard against this sort of thing; if it is not there now, don\u0027t call it -- if it is, then we should fail if it is not there","commit_id":"4cab3727b399e2deb5f740b584d2a3baf12fee95"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"36d791c59a39ec80057321254038940cb9f68cd1","unresolved":false,"context_lines":[{"line_number":79,"context_line":"          export KEEP_LOCALRC\u003d1"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"          function pre_test_hook {{"},{"line_number":82,"context_line":"              if [ -f $BASE/new/dragonflow/devstack/pre_test_hook.sh ] ; then"},{"line_number":83,"context_line":"                  . $BASE/new/dragonflow/devstack/pre_test_hook.sh"},{"line_number":84,"context_line":"              fi"},{"line_number":85,"context_line":"          }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da20952f_d5e8427d","line":82,"in_reply_to":"da20952f_14fc9c70","updated":"2015-09-08 02:23:17.000000000","message":"Well this is just my opinion too :)  I realise this is not the only place this is done; I\u0027ve brought it up on the infra list [1]\n\nI don\u0027t buy arguments that this is more robust or better, etc.  It boils down to the correctness of the job relying on assumptions about the behaviour of other parts of the testing (i.e. if this fails, the other part should fail).  That may be correct now but over time may not be.  \n\nThe line between devstack, devstack-gate, plugins, hooks, etc as pretty blurry.  All we can do is make our best efforts at building something robust.  That\u0027s why I propose we be defensive and follow KISS; if you need it, source it \u0026 fail if its not there; if you don\u0027t, leave it out until you do.\n\n\n[1] http://lists.openstack.org/pipermail/openstack-infra/2015-September/003158.html","commit_id":"4cab3727b399e2deb5f740b584d2a3baf12fee95"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"802f72923467df99a72f2f6081b7cc5452005208","unresolved":false,"context_lines":[{"line_number":79,"context_line":"          export KEEP_LOCALRC\u003d1"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"          function pre_test_hook {{"},{"line_number":82,"context_line":"              if [ -f $BASE/new/dragonflow/devstack/pre_test_hook.sh ] ; then"},{"line_number":83,"context_line":"                  . $BASE/new/dragonflow/devstack/pre_test_hook.sh"},{"line_number":84,"context_line":"              fi"},{"line_number":85,"context_line":"          }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da20952f_14fc9c70","line":82,"in_reply_to":"da20952f_992d45aa","updated":"2015-09-07 06:10:34.000000000","message":"Of course that if you insist, i will change this :)\nJust my opinion anyway..","commit_id":"4cab3727b399e2deb5f740b584d2a3baf12fee95"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"429b2d57676bb03bd796aa7d73b58eef626e0078","unresolved":false,"context_lines":[{"line_number":79,"context_line":"          export KEEP_LOCALRC\u003d1"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"          function pre_test_hook {{"},{"line_number":82,"context_line":"              if [ -f $BASE/new/dragonflow/devstack/pre_test_hook.sh ] ; then"},{"line_number":83,"context_line":"                  . $BASE/new/dragonflow/devstack/pre_test_hook.sh"},{"line_number":84,"context_line":"              fi"},{"line_number":85,"context_line":"          }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da20952f_0e15379a","line":82,"in_reply_to":"da20952f_d5e8427d","updated":"2015-09-08 11:53:41.000000000","message":"Ok, i removed this.","commit_id":"4cab3727b399e2deb5f740b584d2a3baf12fee95"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"40ededa378754736090150d160f7c815b80a8a6f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"          export KEEP_LOCALRC\u003d1"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"          function pre_test_hook {{"},{"line_number":82,"context_line":"              if [ -f $BASE/new/dragonflow/devstack/pre_test_hook.sh ] ; then"},{"line_number":83,"context_line":"                  . $BASE/new/dragonflow/devstack/pre_test_hook.sh"},{"line_number":84,"context_line":"              fi"},{"line_number":85,"context_line":"          }}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da20952f_992d45aa","line":82,"in_reply_to":"da20952f_d9741d69","updated":"2015-09-07 05:39:53.000000000","message":"I could always add an empty pre_test_hook.sh and always have it there, this helps the tested repository (Dragonflow) be agile and fast and not have to wait for Infrastructure patches to get merged in order to perform changes in the tests.\n\nWe dont have it now, but we plan to add it in the future. what good will it do to wait again until the infrastructure patch is merged? seems you guys have alot of load anyway.\n\nI dont see why this makes the job less robust, on the contrary it makes it more robust. and i think the potential silent failure is really not there, if the tests need this pre test hook then they should fail if its not there.\nIf the tests pass, it means either the test is not correct or the pre_test_hook.sh is not correct.","commit_id":"4cab3727b399e2deb5f740b584d2a3baf12fee95"}],"zuul/layout.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"41991ebbd049d0aaf4bdd00869d2ec3700f45896","unresolved":false,"context_lines":[{"line_number":869,"context_line":"    voting: false"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"  - name: ^gate-tempest-dsvm-dragonflow"},{"line_number":872,"context_line":"    branch: ^(?!stable)"},{"line_number":873,"context_line":"    voting: false"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"  - name: ^gate-install-dsvm-dragonflow"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da20952f_d8c037e3","line":872,"updated":"2015-09-02 12:23:41.000000000","message":"You might consider blacklisting stable/juno and stable/kilo, since blacklisting all stable branches means this also won\u0027t run on stable/liberty in a couple months without even more changes to the layout.","commit_id":"4cab3727b399e2deb5f740b584d2a3baf12fee95"}]}
