)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"13021686fdddc466efb08905149c47b43c01f362","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This job should run in the diskimage-builder gate and for that we need"},{"line_number":10,"context_line":"to be able to build diskimage-builder from source instead of installing"},{"line_number":11,"context_line":"it via pip."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Depends-On: I43ae22dffa704b70f30a4fa7c4d22bc49d66c485"},{"line_number":14,"context_line":"Related-Bug: #1490864"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"da20952f_35885022","line":11,"updated":"2015-09-02 16:24:22.000000000","message":"You also changed that job template to {pipeline}-tempest-dsvm-ironic-pxe_ipa-full{branch-designator}, is it worth mentioning that here?","commit_id":"5cb91b0350ba12a7c2c0c510b02f7fdf69998adf"}],"jenkins/jobs/devstack-gate.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"663dc1959e49478371ba38168cab5952eba67deb","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":"          export DIB_FROM_SOURCE\u003d{dib-from-source}"},{"line_number":715,"context_line":"          if [ \"$DIB_FROM_SOURCE\" \u003d\u003d \"1\" ]; then"},{"line_number":716,"context_line":"              if [ -z \"$DEVSTACK_PROJECT_FROM_GIT\" ]; then"},{"line_number":717,"context_line":"                  export DEVSTACK_PROJECT_FROM_GIT\u003d$DEVSTACK_PROJECT_FROM_GIT,diskimage-builder"},{"line_number":718,"context_line":"              else"},{"line_number":719,"context_line":"                  export DEVSTACK_PROJECT_FROM_GIT\u003d\"diskimage-builder\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da20952f_564ae556","line":716,"updated":"2015-09-01 17:08:17.000000000","message":"This check should be -n as the code block here acts as if DEVSTACK_PROJECT_FROM_GIT has content.","commit_id":"9ebfcb5d3d75e89408bb81ca9ff0cad161472289"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a7e653be9c7b679e1e8c298757da2c2a0464c458","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":"          export DIB_FROM_SOURCE\u003d{dib-from-source}"},{"line_number":715,"context_line":"          if [ \"$DIB_FROM_SOURCE\" \u003d\u003d \"1\" ]; then"},{"line_number":716,"context_line":"              if [ -z \"$DEVSTACK_PROJECT_FROM_GIT\" ]; then"},{"line_number":717,"context_line":"                  export DEVSTACK_PROJECT_FROM_GIT\u003d$DEVSTACK_PROJECT_FROM_GIT,diskimage-builder"},{"line_number":718,"context_line":"              else"},{"line_number":719,"context_line":"                  export DEVSTACK_PROJECT_FROM_GIT\u003d\"diskimage-builder\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"da20952f_b6d90186","line":716,"in_reply_to":"da20952f_564ae556","updated":"2015-09-01 17:10:38.000000000","message":"Good catch! Thanks I will update the patch","commit_id":"9ebfcb5d3d75e89408bb81ca9ff0cad161472289"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"82265b623bfc0596390ed6c81dd938d6c55ff7ff","unresolved":false,"context_lines":[{"line_number":789,"context_line":"          client-from-source: 0"},{"line_number":790,"context_line":"          branch-override: \u0027{branch-override}\u0027"},{"line_number":791,"context_line":"          tempest-env: \u0027DEVSTACK_GATE_TEMPEST_REGEX\u003dbaremetal\u0027"},{"line_number":792,"context_line":"          devstack-timeout: 120"},{"line_number":793,"context_line":"    publishers:"},{"line_number":794,"context_line":"      - devstack-logs"},{"line_number":795,"context_line":"      - console-log"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da20952f_765120d8","line":792,"updated":"2015-09-01 20:17:38.000000000","message":"I think you need to put \u0027dib-from-source: 0\u0027 here and in all the other places that use devstack-virtual-ironic.","commit_id":"3ee42c983d934bc66554158e7f3927f677080a7a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a6b9c40a8a4dc2ef4c2f585f775a2491a2f394cc","unresolved":false,"context_lines":[{"line_number":789,"context_line":"          client-from-source: 0"},{"line_number":790,"context_line":"          branch-override: \u0027{branch-override}\u0027"},{"line_number":791,"context_line":"          tempest-env: \u0027DEVSTACK_GATE_TEMPEST_REGEX\u003dbaremetal\u0027"},{"line_number":792,"context_line":"          devstack-timeout: 120"},{"line_number":793,"context_line":"    publishers:"},{"line_number":794,"context_line":"      - devstack-logs"},{"line_number":795,"context_line":"      - console-log"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"da20952f_f6e0d0fc","line":792,"in_reply_to":"da20952f_765120d8","updated":"2015-09-01 20:20:00.000000000","message":"Oh, thanks for that! Adding...","commit_id":"3ee42c983d934bc66554158e7f3927f677080a7a"},{"author":{"_account_id":10343,"name":"Jim Rollenhagen","email":"jim@jimrollenhagen.com","username":"jimrollenhagen"},"change_message_id":"597314220eaaafa5f4bc05ccefa71c736a4ffa02","unresolved":false,"context_lines":[{"line_number":796,"context_line":"      - console-log"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"- job-template:"},{"line_number":799,"context_line":"    name: \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{branch-designator}\u0027"},{"line_number":800,"context_line":"    node: \u0027{node}\u0027"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da20952f_a4721948","line":799,"updated":"2015-09-01 23:16:43.000000000","message":"Should we change the dib job to actually use this, I assume?","commit_id":"bd2c19072344ad032594ce745185fd1a94a69507"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ed2999a6243332217d73eacac534c68484cb0c20","unresolved":false,"context_lines":[{"line_number":796,"context_line":"      - console-log"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"- job-template:"},{"line_number":799,"context_line":"    name: \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{branch-designator}\u0027"},{"line_number":800,"context_line":"    node: \u0027{node}\u0027"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da20952f_4c5ead46","line":799,"in_reply_to":"da20952f_7ba01ba6","updated":"2015-09-02 10:43:27.000000000","message":"I thought it was already? [1]\n\nBut hey, I don\u0027t understand much the structure of this file\n\n[1] https://github.com/openstack-infra/project-config/blob/master/zuul/layout.yaml#L4049-L4067","commit_id":"bd2c19072344ad032594ce745185fd1a94a69507"},{"author":{"_account_id":6618,"name":"Ruby Loo","email":"opensrloo@gmail.com","username":"rloo"},"change_message_id":"16e3e9cf1969c245a59c60f1f317904e0ef65754","unresolved":false,"context_lines":[{"line_number":796,"context_line":"      - console-log"},{"line_number":797,"context_line":""},{"line_number":798,"context_line":"- job-template:"},{"line_number":799,"context_line":"    name: \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{branch-designator}\u0027"},{"line_number":800,"context_line":"    node: \u0027{node}\u0027"},{"line_number":801,"context_line":""},{"line_number":802,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"da20952f_7ba01ba6","line":799,"in_reply_to":"da20952f_a4721948","updated":"2015-09-02 02:04:03.000000000","message":"Oh, guess we need to add it, way way down in this file :-)","commit_id":"bd2c19072344ad032594ce745185fd1a94a69507"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"5210860c5374e604e71dbcc5055c20447866aa2e","unresolved":false,"context_lines":[{"line_number":727,"context_line":""},{"line_number":728,"context_line":"          export IRONIC_LIB_FROM_SOURCE\u003d{ironic-lib-from-source}"},{"line_number":729,"context_line":"          if [ \"$IRONIC_LIB_FROM_SOURCE\" \u003d\u003d \"1\" ]; then"},{"line_number":730,"context_line":"              export DEVSTACK_PROJECT_FROM_GIT\u003d\"ironic-lib\""},{"line_number":731,"context_line":"          fi"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"          export DIB_FROM_SOURCE\u003d{dib-from-source}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"da6ed579_92d87df1","line":730,"updated":"2016-01-12 03:18:15.000000000","message":"nit: better to also add export DEVSTACK_PROJECT_FROM_GIT\u003d$DEVSTACK_PROJECT_FROM_GIT,ironic-lib like L736?","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3a51786b1d8595428609a77582f3dd264ee6d04c","unresolved":false,"context_lines":[{"line_number":727,"context_line":""},{"line_number":728,"context_line":"          export IRONIC_LIB_FROM_SOURCE\u003d{ironic-lib-from-source}"},{"line_number":729,"context_line":"          if [ \"$IRONIC_LIB_FROM_SOURCE\" \u003d\u003d \"1\" ]; then"},{"line_number":730,"context_line":"              export DEVSTACK_PROJECT_FROM_GIT\u003d\"ironic-lib\""},{"line_number":731,"context_line":"          fi"},{"line_number":732,"context_line":""},{"line_number":733,"context_line":"          export DIB_FROM_SOURCE\u003d{dib-from-source}"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"da6ed579_669dd558","line":730,"in_reply_to":"da6ed579_92d87df1","updated":"2016-01-18 11:23:56.000000000","message":"This is a bit outside the scope of this patch, can be fixed in a following patch","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"5210860c5374e604e71dbcc5055c20447866aa2e","unresolved":false,"context_lines":[{"line_number":801,"context_line":""},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"- job-template:"},{"line_number":804,"context_line":"    name: \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh{job-suffix}\u0027"},{"line_number":805,"context_line":"    node: \u0027{node}\u0027"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"da6ed579_15a0f7f3","line":804,"updated":"2016-01-12 03:18:15.000000000","message":"is it necessary to test patch with DIB for both of from pip and from git?","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3a51786b1d8595428609a77582f3dd264ee6d04c","unresolved":false,"context_lines":[{"line_number":801,"context_line":""},{"line_number":802,"context_line":""},{"line_number":803,"context_line":"- job-template:"},{"line_number":804,"context_line":"    name: \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh{job-suffix}\u0027"},{"line_number":805,"context_line":"    node: \u0027{node}\u0027"},{"line_number":806,"context_line":""},{"line_number":807,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"da6ed579_46fd316d","line":804,"in_reply_to":"da6ed579_15a0f7f3","updated":"2016-01-18 11:23:56.000000000","message":"I think so, we should use the git version only at DIB\u0027s own gate, so we can test the changes submitted to DIB. The rest should install it from pip","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"}],"jenkins/jobs/projects.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f6330522bca3fc0102052d827bdd960e125a195a","unresolved":false,"context_lines":[{"line_number":1162,"context_line":"      - \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{job-suffix}\u0027:"},{"line_number":1163,"context_line":"          pipeline: gate"},{"line_number":1164,"context_line":"          node: devstack-trusty"},{"line_number":1165,"context_line":"          job-suffix: \u0027-nv\u0027"},{"line_number":1166,"context_line":"          branch-override: default"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"- project:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"fa69d971_cbd9c157","line":1165,"range":{"start_line":1165,"start_character":26,"end_line":1165,"end_character":27},"updated":"2016-01-11 12:51:02.000000000","message":"This job is not used anywhere, you can remove it.","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"ff66a2bc9ba8a147d52fa3721112e5ad31a97466","unresolved":false,"context_lines":[{"line_number":1162,"context_line":"      - \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{job-suffix}\u0027:"},{"line_number":1163,"context_line":"          pipeline: gate"},{"line_number":1164,"context_line":"          node: devstack-trusty"},{"line_number":1165,"context_line":"          job-suffix: \u0027-nv\u0027"},{"line_number":1166,"context_line":"          branch-override: default"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"- project:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"da6ed579_fc6163d4","line":1165,"range":{"start_line":1165,"start_character":26,"end_line":1165,"end_character":27},"in_reply_to":"da6ed579_77f8537d","updated":"2016-01-18 07:21:49.000000000","message":"Thanks, Andreas :)","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"d73c9ced0749a4712a5d9c6ac19ec769c1f73434","unresolved":false,"context_lines":[{"line_number":1162,"context_line":"      - \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{job-suffix}\u0027:"},{"line_number":1163,"context_line":"          pipeline: gate"},{"line_number":1164,"context_line":"          node: devstack-trusty"},{"line_number":1165,"context_line":"          job-suffix: \u0027-nv\u0027"},{"line_number":1166,"context_line":"          branch-override: default"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"- project:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"da6ed579_c1610bd5","line":1165,"range":{"start_line":1165,"start_character":26,"end_line":1165,"end_character":27},"in_reply_to":"da6ed579_a6642d49","updated":"2016-01-18 11:31:18.000000000","message":"I explained to Tan that -nv stands for non-voting. Lucas, no need for any change here from my side.","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"a5c5a6d1b6fbde6eeb54b36430e98f30b0fb7473","unresolved":false,"context_lines":[{"line_number":1162,"context_line":"      - \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{job-suffix}\u0027:"},{"line_number":1163,"context_line":"          pipeline: gate"},{"line_number":1164,"context_line":"          node: devstack-trusty"},{"line_number":1165,"context_line":"          job-suffix: \u0027-nv\u0027"},{"line_number":1166,"context_line":"          branch-override: default"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"- project:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"da6ed579_c1b82b2d","line":1165,"range":{"start_line":1165,"start_character":26,"end_line":1165,"end_character":27},"in_reply_to":"da6ed579_c1610bd5","updated":"2016-01-18 11:32:21.000000000","message":"Rephrase: Remove it if it\u0027s really unused. The declaration is fine otherwise.","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"b2d5e339fa16d37e6913f175868838231dc75ba4","unresolved":false,"context_lines":[{"line_number":1162,"context_line":"      - \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{job-suffix}\u0027:"},{"line_number":1163,"context_line":"          pipeline: gate"},{"line_number":1164,"context_line":"          node: devstack-trusty"},{"line_number":1165,"context_line":"          job-suffix: \u0027-nv\u0027"},{"line_number":1166,"context_line":"          branch-override: default"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"- project:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"da6ed579_77f8537d","line":1165,"range":{"start_line":1165,"start_character":26,"end_line":1165,"end_character":27},"in_reply_to":"da6ed579_d5afbf92","updated":"2016-01-12 07:00:46.000000000","message":"non-voting\n\nhttp://docs.openstack.org/infra/manual/creators.html#non-voting-jobs","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3a51786b1d8595428609a77582f3dd264ee6d04c","unresolved":false,"context_lines":[{"line_number":1162,"context_line":"      - \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{job-suffix}\u0027:"},{"line_number":1163,"context_line":"          pipeline: gate"},{"line_number":1164,"context_line":"          node: devstack-trusty"},{"line_number":1165,"context_line":"          job-suffix: \u0027-nv\u0027"},{"line_number":1166,"context_line":"          branch-override: default"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"- project:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"da6ed579_a6642d49","line":1165,"range":{"start_line":1165,"start_character":26,"end_line":1165,"end_character":27},"in_reply_to":"da6ed579_fc6163d4","updated":"2016-01-18 11:23:56.000000000","message":"Hi Andreas, you mean the job \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{job-suffix}\u0027 ? Because that\u0027s what I\u0027m trying to use.\n\nOr you mean the job-suffix thing ?","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"},{"author":{"_account_id":13362,"name":"Tan Lin","email":"lin.tan@intel.com","username":"zero"},"change_message_id":"5210860c5374e604e71dbcc5055c20447866aa2e","unresolved":false,"context_lines":[{"line_number":1162,"context_line":"      - \u0027{pipeline}-tempest-dsvm-ironic-pxe_ssh-dib{job-suffix}\u0027:"},{"line_number":1163,"context_line":"          pipeline: gate"},{"line_number":1164,"context_line":"          node: devstack-trusty"},{"line_number":1165,"context_line":"          job-suffix: \u0027-nv\u0027"},{"line_number":1166,"context_line":"          branch-override: default"},{"line_number":1167,"context_line":""},{"line_number":1168,"context_line":"- project:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"da6ed579_d5afbf92","line":1165,"range":{"start_line":1165,"start_character":26,"end_line":1165,"end_character":27},"in_reply_to":"fa69d971_cbd9c157","updated":"2016-01-12 03:18:15.000000000","message":"my dump question, what\u0027s meaning of \u0027nv\u0027?","commit_id":"b0ef99c0013a18e1ca72c888df84ad95302b8bf7"}]}
