)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e51b0a48aa28ca8716dc4c7f2990cb2ff8e3acaa","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that the VPN functional tests have been verified on a working and"},{"line_number":10,"context_line":"a broken (test) commit, we can move the corresponding jobs from the"},{"line_number":11,"context_line":"experimental queue to check queue as non-voting for the neutron project."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, these jobs:"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a2fa921_fb7a5c87","line":11,"updated":"2015-10-08 18:28:31.000000000","message":"can you provide a reference to such an example?","commit_id":"70206941797cf28ab640a7eac5cb10a628744e75"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3ea431f9d3fb15b696dc936265703e36d589487f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now that the VPN functional tests have been verified on a working and"},{"line_number":10,"context_line":"a broken (test) commit, we can move the corresponding jobs from the"},{"line_number":11,"context_line":"experimental queue to check queue as non-voting for the neutron project."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"However, these jobs:"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a2fa921_18b39bea","line":11,"in_reply_to":"7a2fa921_fb7a5c87","updated":"2015-10-08 19:18:56.000000000","message":"Review 196127 added the job to the experimental queue. There is a test commits that I used for checking both good and bad cases - 196149. PS14 shows failure, PS12 shows working (for these functional tests).","commit_id":"70206941797cf28ab640a7eac5cb10a628744e75"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e51b0a48aa28ca8716dc4c7f2990cb2ff8e3acaa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Once verified, this can be made non-voting for neutron and neutron-vpnaas,"},{"line_number":31,"context_line":"and the old jobs removed."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The end goal here is to be able to detect cross project breakages."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: Ieea93753e352ccb09f65aac12c8c81c1d96593ac"},{"line_number":36,"context_line":"Partial-bug: 1495584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a2fa921_db2d2047","line":33,"updated":"2015-10-08 18:28:31.000000000","message":"I understand that there is a desire for preventing cross-project breakages but if we keep going down this path, the split seems kinda pointless. After this change we\u0027ll be running more jobs that we were prior to the split (1 full + 2 for lbaas, and now 2 for vpn). If we then end up adding fwaas, this balloons to 6+, and it\u0027s clearly not sustainable.\n\nI appreciate the intent, but do we really want to go down this path? I am even thinking that we should reconsider having lbaas in the list of jobs for the check queue, we can\u0027t keep adding jobs like this otherwise we\u0027ll cripple our ability to merge stuff quickly and use more resources than are strictly necessary. After all, nodes are cheap, but are not free.","commit_id":"70206941797cf28ab640a7eac5cb10a628744e75"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"5e1281a8205a70f51d6ac5de078592004e62ba8f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Once verified, this can be made non-voting for neutron and neutron-vpnaas,"},{"line_number":31,"context_line":"and the old jobs removed."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The end goal here is to be able to detect cross project breakages."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: Ieea93753e352ccb09f65aac12c8c81c1d96593ac"},{"line_number":36,"context_line":"Partial-bug: 1495584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a2fa921_db4afd25","line":33,"in_reply_to":"7a2fa921_988ecbce","updated":"2015-10-08 19:29:22.000000000","message":"Don\u0027t get me wrong: I am not advocating for suffering the breakage, and I don\u0027t have a clear answer right now...but this is something that can\u0027t go on like this and a better approach must be identified. I am sure we\u0027ll talk more in the forthcoming days/weeks.","commit_id":"70206941797cf28ab640a7eac5cb10a628744e75"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3ea431f9d3fb15b696dc936265703e36d589487f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Once verified, this can be made non-voting for neutron and neutron-vpnaas,"},{"line_number":31,"context_line":"and the old jobs removed."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The end goal here is to be able to detect cross project breakages."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: Ieea93753e352ccb09f65aac12c8c81c1d96593ac"},{"line_number":36,"context_line":"Partial-bug: 1495584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a2fa921_988ecbce","line":33,"in_reply_to":"7a2fa921_db2d2047","updated":"2015-10-08 19:18:56.000000000","message":"It was something that Doug was championing (and I agreed to, as we were seeing breakages on a weekly basis for a while).\n\nJust let me know the decision, whether this is nixed, and advanced services just suffers during breakages, it is setup as experimental queue only and we rely on due diligence of developers to check if they think there is breakage, or this test load is applied... until a proper internal API is created.","commit_id":"70206941797cf28ab640a7eac5cb10a628744e75"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"d0ec8bbdd1534b403328005090a153bd655d78fa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"Once verified, this can be made non-voting for neutron and neutron-vpnaas,"},{"line_number":31,"context_line":"and the old jobs removed."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"The end goal here is to be able to detect cross project breakages."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"Change-Id: Ieea93753e352ccb09f65aac12c8c81c1d96593ac"},{"line_number":36,"context_line":"Partial-bug: 1495584"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a2fa921_5af80ac3","line":33,"in_reply_to":"7a2fa921_db4afd25","updated":"2015-10-09 10:58:34.000000000","message":"Just FYI, I had made a script a few months ago, that goes through a repo and identifies all the Neutron imports and the corresponding usage of the imports in the repo, sorting them by Neutron module. I collected output at that time (about 5 months ago) for LB, FW, and VPN and included in the repo I made.\n\nhttps://github.com/pmichali/openstack/tree/master/scanner","commit_id":"70206941797cf28ab640a7eac5cb10a628744e75"}],"zuul/layout.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"1763c75ce5510696ed39f22c932a56dfeaff73e2","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"    check:"},{"line_number":2859,"context_line":"      - gate-tempest-dsvm-neutron-full"},{"line_number":2860,"context_line":"      - gate-neutron-vpnaas-dsvm-functional"},{"line_number":2861,"context_line":"      - gate-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":2862,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional"},{"line_number":2863,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional-sswan"},{"line_number":2864,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_2bb9fae9","line":2861,"updated":"2015-09-25 00:51:12.000000000","message":"are these two jobs not doing exactly the same thing as the job below?  i.e. calling the hook scripts with the argment \"functional\"?","commit_id":"74ae01dd2d0a6fb0aac4781bd354cdfb04087828"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"0960f504dc2189c3c1cb38a62d329b8295968242","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"    check:"},{"line_number":2859,"context_line":"      - gate-tempest-dsvm-neutron-full"},{"line_number":2860,"context_line":"      - gate-neutron-vpnaas-dsvm-functional"},{"line_number":2861,"context_line":"      - gate-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":2862,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional"},{"line_number":2863,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional-sswan"},{"line_number":2864,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_b17a94bb","line":2861,"in_reply_to":"9a1a9d01_117020a3","updated":"2015-09-30 18:32:13.000000000","message":"Let me try to rephrase what I\u0027m trying to do here...\n\nOriginally, there were a pair of (different) voting jobs that ran (only) in the neutron-vpnaas repo:\n\n- gate-neutron-vpnaas-dsvm-functional\n- gate-neutron-vpnaas-dsvm-functional-sswan\n\nThere was a desire to run these two neutron-vpnaas jobs for neutron commits, but this required some modifications. So, two new jobs (using one template with parameters) were created that would work for neutron repo:\n\n- gate-neutron-vpnaas-test-dsvm-functional\n- gate-neutron-vpnaas-test-dsvm-functional-sswan\n\nModifications were made so that the neutron changeset would be used, if present, in the jobs, which run in the neutron-vpnaas repo. In addition, instead of having two separate job templates (as the old jobs use) there is one template that is parameterized with either \"functional\" or \"functional-sswan\", which is passed to the hook scripts to control the jobs. This change was, under a previous commit, done as an experimental job.\n\nUpon success, we now want these two jobs running in the check queue (non-voting) for neutron. L962-968 and L2787-2788 accomplish that goal.\n\nHowever, these new jobs would also work for neutron-vpnaas commits. So, the intent on L2862-2863 is to add them as non-voting to neutron-vpnaas repo. Granted, the same jobs are effectively running twice for neutron-vpnaas, but this is intended to be for a small period of time.\n\nThe thought being, that once checked out, we can remove the old jobs (gate-neutron-vpnaas-dsvm-functional*) and then switch the new jobs to voting.\n\nThese two jobs are not quite identical to the old jobs, in that they are parameterized, using one template.\n\nIs there another way that would be better than this plan?\nAm I missing some issue with doing it the way outlined here?","commit_id":"74ae01dd2d0a6fb0aac4781bd354cdfb04087828"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3466fe4f83cf323c83097da61be921bafc048cdb","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"    check:"},{"line_number":2859,"context_line":"      - gate-tempest-dsvm-neutron-full"},{"line_number":2860,"context_line":"      - gate-neutron-vpnaas-dsvm-functional"},{"line_number":2861,"context_line":"      - gate-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":2862,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional"},{"line_number":2863,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional-sswan"},{"line_number":2864,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_00a243fd","line":2861,"in_reply_to":"9a1a9d01_2530cbe7","updated":"2015-09-29 17:43:11.000000000","message":"Let me know if this is detailed enough in the commit message.","commit_id":"74ae01dd2d0a6fb0aac4781bd354cdfb04087828"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"a3f6dd0bae77ef542cdb7ac5cce678f807e7a2cb","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"    check:"},{"line_number":2859,"context_line":"      - gate-tempest-dsvm-neutron-full"},{"line_number":2860,"context_line":"      - gate-neutron-vpnaas-dsvm-functional"},{"line_number":2861,"context_line":"      - gate-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":2862,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional"},{"line_number":2863,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional-sswan"},{"line_number":2864,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_117020a3","line":2861,"in_reply_to":"9a1a9d01_2530cbe7","updated":"2015-09-30 18:12:21.000000000","message":"Paul, if you have identical jobs and want one voting and the other non-voting, name the non-voting one \"-nv\" - that\u0027s how we use branch-designator","commit_id":"74ae01dd2d0a6fb0aac4781bd354cdfb04087828"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"d517e01f274957159697b9b0f6e7c3ecc82d7ccc","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"    check:"},{"line_number":2859,"context_line":"      - gate-tempest-dsvm-neutron-full"},{"line_number":2860,"context_line":"      - gate-neutron-vpnaas-dsvm-functional"},{"line_number":2861,"context_line":"      - gate-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":2862,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional"},{"line_number":2863,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional-sswan"},{"line_number":2864,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_c16dbf33","line":2861,"in_reply_to":"9a1a9d01_26405156","updated":"2015-09-25 03:10:26.000000000","message":"So I\u0027m fairly sure this is doing exactly the same thing; i think the two options are either just swap them here, or propose a follow-on change to this (even if left WIP) so it\u0027s clear what the plan is","commit_id":"74ae01dd2d0a6fb0aac4781bd354cdfb04087828"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"292ff79f9f0762c6df1b57329afc1767a898db4a","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"    check:"},{"line_number":2859,"context_line":"      - gate-tempest-dsvm-neutron-full"},{"line_number":2860,"context_line":"      - gate-neutron-vpnaas-dsvm-functional"},{"line_number":2861,"context_line":"      - gate-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":2862,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional"},{"line_number":2863,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional-sswan"},{"line_number":2864,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_26405156","line":2861,"in_reply_to":"9a1a9d01_26edb18b","updated":"2015-09-25 02:24:06.000000000","message":"Ian, I think he\u0027s trying to transition with no holes in the coverage. Phase in the non-voting jobs, remove the old ones when voting.","commit_id":"74ae01dd2d0a6fb0aac4781bd354cdfb04087828"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"ba922d725f61edc9095fbee186690c8ffa738acd","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"    check:"},{"line_number":2859,"context_line":"      - gate-tempest-dsvm-neutron-full"},{"line_number":2860,"context_line":"      - gate-neutron-vpnaas-dsvm-functional"},{"line_number":2861,"context_line":"      - gate-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":2862,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional"},{"line_number":2863,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional-sswan"},{"line_number":2864,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_4b122eb6","line":2861,"in_reply_to":"9a1a9d01_2bb9fae9","updated":"2015-09-25 01:06:22.000000000","message":"The content of functional tests is same for openswan (functional) and strongswan (functional-sswan), but devstack setup is different and\nwe cannot install both at the same time because Ubuntu deb packaging does not allow it.","commit_id":"74ae01dd2d0a6fb0aac4781bd354cdfb04087828"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"12aa5061f8087b3439ba60abbfd7728ec9d1ae85","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"    check:"},{"line_number":2859,"context_line":"      - gate-tempest-dsvm-neutron-full"},{"line_number":2860,"context_line":"      - gate-neutron-vpnaas-dsvm-functional"},{"line_number":2861,"context_line":"      - gate-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":2862,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional"},{"line_number":2863,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional-sswan"},{"line_number":2864,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_26edb18b","line":2861,"in_reply_to":"9a1a9d01_4b122eb6","updated":"2015-09-25 02:13:57.000000000","message":"that\u0027s ok but i think i\u0027m saying\n\n gate-neutron-vpnaas-dsvm-functional \u003d\u003d gate-neutron-vpnaas-test-dsvm-functional\n\nso what\u0027s the point of running both?","commit_id":"74ae01dd2d0a6fb0aac4781bd354cdfb04087828"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"a8f1ca48002f5cd4326e9fa3b478e4d787086bff","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"    check:"},{"line_number":2859,"context_line":"      - gate-tempest-dsvm-neutron-full"},{"line_number":2860,"context_line":"      - gate-neutron-vpnaas-dsvm-functional"},{"line_number":2861,"context_line":"      - gate-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":2862,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional"},{"line_number":2863,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional-sswan"},{"line_number":2864,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_349e72b9","line":2861,"in_reply_to":"9a1a9d01_b17a94bb","updated":"2015-09-30 18:35:20.000000000","message":"@Andreas so the short answer is that I didn\u0027t want to just use a suffix on the original job names (for these new jobs), because I\u0027m trying to rename the jobs so that they can be parameterized and use one template.","commit_id":"74ae01dd2d0a6fb0aac4781bd354cdfb04087828"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"4f34370f3b8d79f17c6c5c06491ffdc5c5983369","unresolved":false,"context_lines":[{"line_number":2858,"context_line":"    check:"},{"line_number":2859,"context_line":"      - gate-tempest-dsvm-neutron-full"},{"line_number":2860,"context_line":"      - gate-neutron-vpnaas-dsvm-functional"},{"line_number":2861,"context_line":"      - gate-neutron-vpnaas-dsvm-functional-sswan"},{"line_number":2862,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional"},{"line_number":2863,"context_line":"      - gate-neutron-vpnaas-test-dsvm-functional-sswan"},{"line_number":2864,"context_line":"    gate:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9a1a9d01_2530cbe7","line":2861,"in_reply_to":"9a1a9d01_c16dbf33","updated":"2015-09-29 11:37:15.000000000","message":"@Ian, so the intent is to take two experimental jobs for Neutron L2790 in original, and make them non-voting in check queue.\n\nBy just doing that, though, it would make the same two voting jobs non-voting for neutron-vpnaas repo - L2869-2861 and we\u0027d lose the protection.\n\nTo prevent this, I\u0027m using the new job names for Neutron (L2787-2788). I added the new jobs to neutron-vpnaas too, with the thought that once this has run for a while in both repos, and we are happy with the new jobs, I can make them voting and remove the old voting jobs (L2860-2861).\n\nI felt there was less risk to test these new jobs as non-voting in neutron-vpnaas at the same time as checking them for neutron (as there are subtle differences with change-sets being tested), rather than switch neutron-vpnaas over to the new jobs when they are voting.\n\nDoes that make sense?","commit_id":"74ae01dd2d0a6fb0aac4781bd354cdfb04087828"}]}