)]}'
{"tools/check_valid_gerrit_projects.py":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"2e230aa18bb7d60112dad6310e2f89c1eaf256c6","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            print(\"    %s\" % tag)"},{"line_number":44,"context_line":"    else:"},{"line_number":45,"context_line":"        print(\"  Found no tags.\")"},{"line_number":46,"context_line":"    shutil.rmtree(\u0027repo\u0027)"},{"line_number":47,"context_line":"    # Just an empty line for nicer formatting"},{"line_number":48,"context_line":"    print(\"\")"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_e095c486","line":46,"updated":"2015-10-21 18:23:55.000000000","message":"I would use the python-fixtures tmpdir fixture context manager to make a tmpdir that we can clone into and will have deleted automagically when we exit that scope. This will handle exceptions which may happen when cloning the repo or doing other repo operations.","commit_id":"396e8d0ac8a7215c8795d725c1bed5cb84a69541"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"1245436e6b517aa5e1cc19ebf6f87904c350ffa9","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def check_repo(repo_path):"},{"line_number":39,"context_line":"    global found_errors"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    print(\"Checking git repo \u0027%s\u0027:\" % repo_path)"},{"line_number":42,"context_line":"    with tempdir() as repopath:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_6198c46a","line":39,"updated":"2015-10-22 08:53:16.000000000","message":"i\u0027m not a fan of globals, can you pass them by argument?","commit_id":"106f6b80e23be6f39e0fc175cfc9d208909e550f"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8ce5bbe5e2a879467de9692d823cdbd519f43ef0","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"def check_repo(repo_path):"},{"line_number":39,"context_line":"    global found_errors"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    print(\"Checking git repo \u0027%s\u0027:\" % repo_path)"},{"line_number":42,"context_line":"    with tempdir() as repopath:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_b385cf5a","line":39,"in_reply_to":"3a29b11f_6198c46a","updated":"2015-10-22 08:56:42.000000000","message":"Let me do that as followup, ok?","commit_id":"106f6b80e23be6f39e0fc175cfc9d208909e550f"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"1245436e6b517aa5e1cc19ebf6f87904c350ffa9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            print(\"  Master branch exists.\")"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            found_errors +\u003d 1"},{"line_number":53,"context_line":"            print(\"  Error: No master branch exists\")"},{"line_number":54,"context_line":"        if repo.tags:"},{"line_number":55,"context_line":"            print(\"  Found the following tags:\")"},{"line_number":56,"context_line":"            for tag in repo.tags:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_a1633c41","line":53,"updated":"2015-10-22 08:53:16.000000000","message":"in downstream, we can have repos without master branches, sounds weird but we have that use case. How can we deal with that if we want to use that check? maybe you can add an option to check for that? like \"list of branches that need to be present\" . Some constant like you do with VALID_LABELS, VALID_SCHEMES, that will be clear to override.","commit_id":"106f6b80e23be6f39e0fc175cfc9d208909e550f"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"8ce5bbe5e2a879467de9692d823cdbd519f43ef0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"            print(\"  Master branch exists.\")"},{"line_number":51,"context_line":"        else:"},{"line_number":52,"context_line":"            found_errors +\u003d 1"},{"line_number":53,"context_line":"            print(\"  Error: No master branch exists\")"},{"line_number":54,"context_line":"        if repo.tags:"},{"line_number":55,"context_line":"            print(\"  Found the following tags:\")"},{"line_number":56,"context_line":"            for tag in repo.tags:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_f38fc772","line":53,"in_reply_to":"3a29b11f_a1633c41","updated":"2015-10-22 08:56:42.000000000","message":"See IRC discussion from yesterday evening, - gerrit itself needs master. The OpenStack infrastructure breaks if there is no master...","commit_id":"106f6b80e23be6f39e0fc175cfc9d208909e550f"}]}
