)]}'
{"nodepool/elements/nodepool-base/install.d/92-venv-os-performance-tools":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"157e32ec1a6fc4ffdde277ef86edb4811af380a3","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":13,"context_line":"# implied."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# dib-lint: disable\u003dsetu setpipefail"},{"line_number":16,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":17,"context_line":"    set -x"},{"line_number":18,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"da85f559_9f53956c","line":15,"updated":"2015-11-13 03:02:03.000000000","message":"why not have these?","commit_id":"5bf6e47905a3a46a9ead56b40ce9a2230a14b88e"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"76fbb028dbb89ca62b68eeda4e93efe23020a26e","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":13,"context_line":"# implied."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# dib-lint: disable\u003dsetu setpipefail"},{"line_number":16,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":17,"context_line":"    set -x"},{"line_number":18,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"ba8a016a_a0642649","line":15,"in_reply_to":"da85f559_9f53956c","updated":"2015-11-20 22:53:18.000000000","message":"cargo cult.. removed and added set -u and set -o pipefail as they don\u0027t hurt.","commit_id":"5bf6e47905a3a46a9ead56b40ce9a2230a14b88e"}],"nodepool/scripts/prepare_node.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"157e32ec1a6fc4ffdde277ef86edb4811af380a3","unresolved":false,"context_lines":[{"line_number":254,"context_line":"# Create a virtualenv for os-performance-tools (which contains"},{"line_number":255,"context_line":"# os-collect-counters)"},{"line_number":256,"context_line":"# this is in /usr instead of /usr/loca/ due to this bug on precise:"},{"line_number":257,"context_line":"# https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/839588"},{"line_number":258,"context_line":"sudo -H virtualenv /usr/os-performance-tools"},{"line_number":259,"context_line":"sudo -H /usr/os-performance-tools/bin/pip install os-performance-tools"},{"line_number":260,"context_line":"sudo -H /usr/os-performance-tools/bin/pip install os-performance-tools"}],"source_content_type":"text/x-sh","patch_set":2,"id":"da85f559_5f768d07","line":257,"updated":"2015-11-13 03:02:03.000000000","message":"I know you\u0027re just copying this, but surely this doesn\u0027t apply any more?","commit_id":"5bf6e47905a3a46a9ead56b40ce9a2230a14b88e"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"76fbb028dbb89ca62b68eeda4e93efe23020a26e","unresolved":false,"context_lines":[{"line_number":254,"context_line":"# Create a virtualenv for os-performance-tools (which contains"},{"line_number":255,"context_line":"# os-collect-counters)"},{"line_number":256,"context_line":"# this is in /usr instead of /usr/loca/ due to this bug on precise:"},{"line_number":257,"context_line":"# https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/839588"},{"line_number":258,"context_line":"sudo -H virtualenv /usr/os-performance-tools"},{"line_number":259,"context_line":"sudo -H /usr/os-performance-tools/bin/pip install os-performance-tools"},{"line_number":260,"context_line":"sudo -H /usr/os-performance-tools/bin/pip install os-performance-tools"}],"source_content_type":"text/x-sh","patch_set":2,"id":"ba8a016a_20511663","line":257,"in_reply_to":"da85f559_5f768d07","updated":"2015-11-20 22:53:18.000000000","message":"Lucid and Oneiric.. yeah.. I think we\u0027re good. ;-) Removed","commit_id":"5bf6e47905a3a46a9ead56b40ce9a2230a14b88e"},{"author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"change_message_id":"544bac2d8793306aed9238181f32fe4091e89e79","unresolved":false,"context_lines":[{"line_number":250,"context_line":"# this is in /usr instead of /usr/loca/ due to this bug on precise:"},{"line_number":251,"context_line":"# https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/839588"},{"line_number":252,"context_line":"sudo -H virtualenv /usr/os-testr-env"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"sudo -H pip install os-performance-tools"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"sync"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a740942_2dfb0dc3","line":253,"updated":"2015-12-05 22:40:19.000000000","message":"I\u0027m not sure this is installing things where you want?","commit_id":"57dabb6d6ade8fe2d9d20e228c324769a008dfde"},{"author":{"_account_id":6488,"name":"Clint Byrum","email":"clint@fewbar.com","username":"clint-fewbar"},"change_message_id":"7e1c83dbbea6aad13c0e5dbf5cb5a7f757c0227b","unresolved":false,"context_lines":[{"line_number":250,"context_line":"# this is in /usr instead of /usr/loca/ due to this bug on precise:"},{"line_number":251,"context_line":"# https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/839588"},{"line_number":252,"context_line":"sudo -H virtualenv /usr/os-testr-env"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"sudo -H pip install os-performance-tools"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"sync"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a740942_71eb2bb1","line":253,"in_reply_to":"7a740942_2dfb0dc3","updated":"2015-12-06 16:50:53.000000000","message":"In previous reviews the suggestoin was since that bug referenced above is not relevant, we should just install it in system python.","commit_id":"57dabb6d6ade8fe2d9d20e228c324769a008dfde"}]}