)]}'
{"jenkins/jobs/diskimage-builder.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"b6e8335b0a126c4c62277ff25dec2e7d7cda3759","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          export PATH\u003d$PATH:$(pwd)/openstack/dib-utils/bin"},{"line_number":84,"context_line":"          export PATH\u003d$PATH:$(pwd)/openstack/diskimage-builder/bin"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"          ./openstack/diskimage-builder/tests/install_test_deps.sh"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"          DIB_RELEASE\u003d\"jessie\" diskimage-builder \\"},{"line_number":89,"context_line":"            -o ~/debian-jessie-simple-init \\"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_fffc52b9","line":86,"updated":"2015-12-08 19:20:35.000000000","message":"I feel like you\u0027d be better off installing these into a virtualenv...","commit_id":"a5aaaf7b31eac0fbe9a1d38624f11a036bf67a74"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"94dd7b52b9538e9a88ef782bede998db92615c50","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          export PATH\u003d$PATH:$(pwd)/openstack/dib-utils/bin"},{"line_number":84,"context_line":"          export PATH\u003d$PATH:$(pwd)/openstack/diskimage-builder/bin"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"          ./openstack/diskimage-builder/tests/install_test_deps.sh"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"          DIB_RELEASE\u003d\"jessie\" diskimage-builder \\"},{"line_number":89,"context_line":"            -o ~/debian-jessie-simple-init \\"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a7e1126_3025d9aa","line":86,"in_reply_to":"5a710552_0b1cfe75","updated":"2015-12-17 09:56:17.000000000","message":"Ahh, I understand now.  I still think that would add un-necessary disk IO and CPU cycles since both packages are purely just collections of bash scripts, so installation is really... un-necessary since explicit script calls will occur anyway.  Besides, the use of the PATH export conforms with the test job, so if that is ever refactored, it is easy to identify if an additional change is required as part of refactoring.\n\nI can look at refactoring, but I suspect Greg will be unhappy if I muck with  the dib gate functional tests.","commit_id":"a5aaaf7b31eac0fbe9a1d38624f11a036bf67a74"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"787a579d3503cc3b1f4793f4cc9d798dae7b1dfc","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          export PATH\u003d$PATH:$(pwd)/openstack/dib-utils/bin"},{"line_number":84,"context_line":"          export PATH\u003d$PATH:$(pwd)/openstack/diskimage-builder/bin"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"          ./openstack/diskimage-builder/tests/install_test_deps.sh"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"          DIB_RELEASE\u003d\"jessie\" diskimage-builder \\"},{"line_number":89,"context_line":"            -o ~/debian-jessie-simple-init \\"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a710552_0b1cfe75","line":86,"in_reply_to":"7a740942_d0a4e34b","updated":"2015-12-16 04:34:30.000000000","message":"sorry, this comment was actually referring to the above two lines where the PATH is modified to call them directly.  it seems like it would be better if diskimage-builder was installed in a venv, then it could bring in dib-utils and we wouldn\u0027t have to run the scripts directly","commit_id":"a5aaaf7b31eac0fbe9a1d38624f11a036bf67a74"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"20495b8d0825d9270478b2ec9fb39d4781adb6fa","unresolved":false,"context_lines":[{"line_number":83,"context_line":"          export PATH\u003d$PATH:$(pwd)/openstack/dib-utils/bin"},{"line_number":84,"context_line":"          export PATH\u003d$PATH:$(pwd)/openstack/diskimage-builder/bin"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"          ./openstack/diskimage-builder/tests/install_test_deps.sh"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"          DIB_RELEASE\u003d\"jessie\" diskimage-builder \\"},{"line_number":89,"context_line":"            -o ~/debian-jessie-simple-init \\"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_d0a4e34b","line":86,"in_reply_to":"7a740942_fffc52b9","updated":"2015-12-08 20:33:49.000000000","message":"Those dependencies are OS level packages via a script maintained in the DIB repository.  Honestly since the build slaves are, as far as I\u0027m aware, single use disposable instances, I\u0027m not sure even if they were python packages, that it would really matter.","commit_id":"a5aaaf7b31eac0fbe9a1d38624f11a036bf67a74"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"5d78bea4788de7bdeede3afa7a28fd2df31f365a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      - scp:"},{"line_number":65,"context_line":"          site: \u0027tarballs.openstack.org\u0027"},{"line_number":66,"context_line":"          files:"},{"line_number":67,"context_line":"            - source: \u0027~/debian-jessie-ironic-agent.vmlinuz\u0027"},{"line_number":68,"context_line":"              target: \u003e"},{"line_number":69,"context_line":"                \u0027tarballs/diskimage-builder/images/ironic-agent/debian-jessie/\u0027"},{"line_number":70,"context_line":"              keep-hierarchy: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a7e1126_4343536c","line":67,"range":{"start_line":67,"start_character":22,"end_line":67,"end_character":25},"updated":"2015-12-21 17:53:49.000000000","message":"No need for the \"~/\" in both places, please remove.","commit_id":"50345f3dbaa422392bd7f84ed34ff3fc30a6d4cd"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"68931d4f999950b80ae685f8901e37006474cbc7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      - scp:"},{"line_number":65,"context_line":"          site: \u0027tarballs.openstack.org\u0027"},{"line_number":66,"context_line":"          files:"},{"line_number":67,"context_line":"            - source: \u0027~/debian-jessie-ironic-agent.vmlinuz\u0027"},{"line_number":68,"context_line":"              target: \u003e"},{"line_number":69,"context_line":"                \u0027tarballs/diskimage-builder/images/ironic-agent/debian-jessie/\u0027"},{"line_number":70,"context_line":"              keep-hierarchy: false"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3a7e1126_7ce06ccd","line":67,"range":{"start_line":67,"start_character":22,"end_line":67,"end_character":25},"in_reply_to":"3a7e1126_4343536c","updated":"2015-12-21 19:03:09.000000000","message":"Well, what I could find in failed job logs was that the files could not be found.  The files should be written out to ~/, would $WORKSPACE be best to execute from?","commit_id":"50345f3dbaa422392bd7f84ed34ff3fc30a6d4cd"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"db8724cbfb3567960d21b00176154d378e211236","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                \u0027tarballs/diskimage-builder/images/ironic-agent/debian-jessie/\u0027"},{"line_number":75,"context_line":"              keep-hierarchy: false"},{"line_number":76,"context_line":"              copy-after-failure: false"},{"line_number":77,"context_line":"            - source: \u0027~/debian-jessie-simple-init.qcow2\u0027"},{"line_number":78,"context_line":"              target: \u003e"},{"line_number":79,"context_line":"                \u0027tarballs/diskimage-builder/images/simple-init/debian-jessie/\u0027"},{"line_number":80,"context_line":"              keep-hierarchy: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a7e1126_185a91f2","line":77,"range":{"start_line":77,"start_character":22,"end_line":77,"end_character":25},"updated":"2015-12-21 20:14:23.000000000","message":"Still ~/","commit_id":"97dd5274adf910d113fb7e4c23d742936e6588c9"},{"author":{"_account_id":11655,"name":"Julia Kreger","email":"juliaashleykreger@gmail.com","username":"jkreger","status":"Flying to the moon with a Jetpack!"},"change_message_id":"4b42c17620b222fe36288a6940d4df33018116e6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                \u0027tarballs/diskimage-builder/images/ironic-agent/debian-jessie/\u0027"},{"line_number":75,"context_line":"              keep-hierarchy: false"},{"line_number":76,"context_line":"              copy-after-failure: false"},{"line_number":77,"context_line":"            - source: \u0027~/debian-jessie-simple-init.qcow2\u0027"},{"line_number":78,"context_line":"              target: \u003e"},{"line_number":79,"context_line":"                \u0027tarballs/diskimage-builder/images/simple-init/debian-jessie/\u0027"},{"line_number":80,"context_line":"              keep-hierarchy: false"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a7e1126_a2230355","line":77,"range":{"start_line":77,"start_character":22,"end_line":77,"end_character":25},"in_reply_to":"3a7e1126_185a91f2","updated":"2015-12-22 01:48:40.000000000","message":"Doh, will fix upon rebasing.","commit_id":"97dd5274adf910d113fb7e4c23d742936e6588c9"}]}
