)]}'
{"jenkins/jobs/kuryr.yaml":[{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"bd705a73b224f09af3b0b184a93b85d0a57cd819","unresolved":false,"context_lines":[{"line_number":58,"context_line":"          export DEVSTACK_GATE_NEUTRON\u003d1"},{"line_number":59,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":60,"context_line":"          export BRANCH_OVERRIDE\u003d{branch-override}"},{"line_number":61,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":62,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":63,"context_line":"          fi"},{"line_number":64,"context_line":"          export PROJECTS\u003d\"openstack/kuryr $PROJECTS\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_74810efb","line":61,"updated":"2015-12-10 07:29:03.000000000","message":"It seems there\u0027s no coding standard for shell script in OpenStack community. I think using [[ ]] is better in general but that\u0027s just my preference.\n\nhttps://google.github.io/styleguide/shell.xml#Test,_%5B_and_%5B%5B","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"9c1bcd73f41dd88f707895b2e5576d30cc085810","unresolved":false,"context_lines":[{"line_number":58,"context_line":"          export DEVSTACK_GATE_NEUTRON\u003d1"},{"line_number":59,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":60,"context_line":"          export BRANCH_OVERRIDE\u003d{branch-override}"},{"line_number":61,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":62,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":63,"context_line":"          fi"},{"line_number":64,"context_line":"          export PROJECTS\u003d\"openstack/kuryr $PROJECTS\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_cf7dcbe8","line":61,"in_reply_to":"7a740942_74810efb","updated":"2015-12-10 07:43:36.000000000","message":"This syntax is used in most jobs that i saw, i can replace it if its really needed","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"6d8baebd7927d2c51c4494d697126a4911480851","unresolved":false,"context_lines":[{"line_number":58,"context_line":"          export DEVSTACK_GATE_NEUTRON\u003d1"},{"line_number":59,"context_line":"          export DEVSTACK_GATE_TEMPEST\u003d1"},{"line_number":60,"context_line":"          export BRANCH_OVERRIDE\u003d{branch-override}"},{"line_number":61,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":62,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":63,"context_line":"          fi"},{"line_number":64,"context_line":"          export PROJECTS\u003d\"openstack/kuryr $PROJECTS\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_faac078e","line":61,"in_reply_to":"7a740942_cf7dcbe8","updated":"2015-12-10 08:22:18.000000000","message":"Ok, I don\u0027t have a strong opinion on this but it suggested my preference.","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"bd705a73b224f09af3b0b184a93b85d0a57cd819","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          export PROJECTS\u003d\"openstack/rally $PROJECTS\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin kuryr http://git.openstack.org/openstack/kuryr\""},{"line_number":68,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_plugin rally git://git.openstack.org/openstack/rally\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"          export OVERRIDE_ENABLED_SERVICES\u003dkuryr,etcd-server,docker-engine,q-svc,q-dhcp,q-agt,q-l3,key,mysql,rabbit"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_a9715fe2","line":68,"updated":"2015-12-10 07:29:03.000000000","message":"What are $ \u0027\\n\u0027 hat follow +\u003d for in this line?","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"9c1bcd73f41dd88f707895b2e5576d30cc085810","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          export PROJECTS\u003d\"openstack/rally $PROJECTS\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin kuryr http://git.openstack.org/openstack/kuryr\""},{"line_number":68,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_plugin rally git://git.openstack.org/openstack/rally\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"          export OVERRIDE_ENABLED_SERVICES\u003dkuryr,etcd-server,docker-engine,q-svc,q-dhcp,q-agt,q-l3,key,mysql,rabbit"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_af5f1f74","line":68,"in_reply_to":"7a740942_a9715fe2","updated":"2015-12-10 07:43:36.000000000","message":"Its needed to put these in new lines.\n\nthis basically is written to the local.conf of this job devstack","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"6d8baebd7927d2c51c4494d697126a4911480851","unresolved":false,"context_lines":[{"line_number":65,"context_line":"          export PROJECTS\u003d\"openstack/rally $PROJECTS\""},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin kuryr http://git.openstack.org/openstack/kuryr\""},{"line_number":68,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_plugin rally git://git.openstack.org/openstack/rally\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"          export OVERRIDE_ENABLED_SERVICES\u003dkuryr,etcd-server,docker-engine,q-svc,q-dhcp,q-agt,q-l3,key,mysql,rabbit"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_3572a07d","line":68,"in_reply_to":"7a740942_af5f1f74","updated":"2015-12-10 08:22:18.000000000","message":"Ok, it seems like the special macro or something expanded to the new line.\n\nhttps://github.com/openstack-infra/project-config/blob/b7923f48323c7377e082d1604905e564db33836c/jenkins/jobs/networking-ofagent.yaml#L25","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"bd705a73b224f09af3b0b184a93b85d0a57cd819","unresolved":false,"context_lines":[{"line_number":67,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin kuryr http://git.openstack.org/openstack/kuryr\""},{"line_number":68,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_plugin rally git://git.openstack.org/openstack/rally\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"          export OVERRIDE_ENABLED_SERVICES\u003dkuryr,etcd-server,docker-engine,q-svc,q-dhcp,q-agt,q-l3,key,mysql,rabbit"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"          function post_test_hook {{"},{"line_number":73,"context_line":"              $BASE/new/rally/tests/ci/rally-gate.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_7456ee07","line":70,"updated":"2015-12-10 07:29:03.000000000","message":"I think it\u0027s better to wrap this with the double quotes.","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"6d8baebd7927d2c51c4494d697126a4911480851","unresolved":false,"context_lines":[{"line_number":67,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin kuryr http://git.openstack.org/openstack/kuryr\""},{"line_number":68,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_plugin rally git://git.openstack.org/openstack/rally\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"          export OVERRIDE_ENABLED_SERVICES\u003dkuryr,etcd-server,docker-engine,q-svc,q-dhcp,q-agt,q-l3,key,mysql,rabbit"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"          function post_test_hook {{"},{"line_number":73,"context_line":"              $BASE/new/rally/tests/ci/rally-gate.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_ba875f11","line":70,"in_reply_to":"7a740942_4f51db61","updated":"2015-12-10 08:22:18.000000000","message":"I found they\u0027re were not quoted in local.conf, so never mind.","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"9c1bcd73f41dd88f707895b2e5576d30cc085810","unresolved":false,"context_lines":[{"line_number":67,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin kuryr http://git.openstack.org/openstack/kuryr\""},{"line_number":68,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"enable_plugin rally git://git.openstack.org/openstack/rally\""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"          export OVERRIDE_ENABLED_SERVICES\u003dkuryr,etcd-server,docker-engine,q-svc,q-dhcp,q-agt,q-l3,key,mysql,rabbit"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"          function post_test_hook {{"},{"line_number":73,"context_line":"              $BASE/new/rally/tests/ci/rally-gate.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_4f51db61","line":70,"in_reply_to":"7a740942_7456ee07","updated":"2015-12-10 07:43:36.000000000","message":"Not sure why its needed, it is working for other jobs that i saw and also for Kuryr devstack job above..","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"bd705a73b224f09af3b0b184a93b85d0a57cd819","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"          export OVERRIDE_ENABLED_SERVICES\u003dkuryr,etcd-server,docker-engine,q-svc,q-dhcp,q-agt,q-l3,key,mysql,rabbit"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"          function post_test_hook {{"},{"line_number":73,"context_line":"              $BASE/new/rally/tests/ci/rally-gate.sh"},{"line_number":74,"context_line":"          }}"},{"line_number":75,"context_line":"          export -f post_test_hook"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_0f3193ec","line":72,"updated":"2015-12-10 07:29:03.000000000","message":"I don\u0027t think this is the valid syntax in bash.\n\n  bash-3.2$ function foo {{ echo \"bar\" }}\n  bash: syntax error near unexpected token `{{\u0027","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"9c1bcd73f41dd88f707895b2e5576d30cc085810","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"          export OVERRIDE_ENABLED_SERVICES\u003dkuryr,etcd-server,docker-engine,q-svc,q-dhcp,q-agt,q-l3,key,mysql,rabbit"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"          function post_test_hook {{"},{"line_number":73,"context_line":"              $BASE/new/rally/tests/ci/rally-gate.sh"},{"line_number":74,"context_line":"          }}"},{"line_number":75,"context_line":"          export -f post_test_hook"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_efe447ad","line":72,"in_reply_to":"7a740942_0f3193ec","updated":"2015-12-10 07:43:36.000000000","message":"Something i took from the other rally jobs, and since the job parsing pass i assume this is correct.","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"},{"author":{"_account_id":12069,"name":"Taku Fukushima","email":"f.tac.mac@gmail.com","username":"tfukushima"},"change_message_id":"6d8baebd7927d2c51c4494d697126a4911480851","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"          export OVERRIDE_ENABLED_SERVICES\u003dkuryr,etcd-server,docker-engine,q-svc,q-dhcp,q-agt,q-l3,key,mysql,rabbit"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"          function post_test_hook {{"},{"line_number":73,"context_line":"              $BASE/new/rally/tests/ci/rally-gate.sh"},{"line_number":74,"context_line":"          }}"},{"line_number":75,"context_line":"          export -f post_test_hook"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_3a77efd5","line":72,"in_reply_to":"7a740942_efe447ad","updated":"2015-12-10 08:22:18.000000000","message":"Yeah, it seems the double curly braces are substituted by the single one. Anyways it\u0027s the valid syntax in the YAML files of infra-config.\n\nhttps://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/neutron.yaml#L30-L32","commit_id":"7d5555027d4f556ab8855781ba1f8ac277b3996a"}],"zuul/layout.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"cadbccc685f28376c791ef83a61866c805ee9f06","unresolved":false,"context_lines":[{"line_number":1449,"context_line":""},{"line_number":1450,"context_line":"  - name: gate-install-dsvm-kuryr-nv"},{"line_number":1451,"context_line":""},{"line_number":1452,"context_line":"  - name: gate-kuryr-dsvm-rally-nv"},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"  - name: gate-python-keystoneclient-tox-bandit"},{"line_number":1455,"context_line":"    branch: ^(?!stable/kilo).*$"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a740942_10adaf9a","line":1452,"updated":"2015-12-13 10:02:36.000000000","message":"No need for this entry at all, remove it completely","commit_id":"d1e907bf0bcfd6976f1d98e6db8263c9db3dddd9"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"1800076261b3ed31b7ad72883f721e34945c92a6","unresolved":false,"context_lines":[{"line_number":1446,"context_line":"    voting: false"},{"line_number":1447,"context_line":""},{"line_number":1448,"context_line":"  - name: gate-install-dsvm-kuryr-nv"},{"line_number":1449,"context_line":"    branch: ^(?!stable/(juno|kilo|liberty)).*$"},{"line_number":1450,"context_line":""},{"line_number":1451,"context_line":"  - name: gate-python-keystoneclient-tox-bandit"},{"line_number":1452,"context_line":"    branch: ^(?!stable/kilo).*$"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a740942_701d13bd","side":"PARENT","line":1449,"updated":"2015-12-13 10:25:00.000000000","message":"Thanks for removing this. Add this to your commit message as well...","commit_id":"3192f513a7d6e85e9516fd7dee2e9aa8102264d6"}]}