)]}'
{"jenkins/jobs/ansible-role-jobs.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"d98f1fa5b80e8457c64b4e599544e17379fc77d3","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      - zuul-git-prep"},{"line_number":22,"context_line":"      - shell: |"},{"line_number":23,"context_line":"          # Allow Jenkins user to ssh into localhost"},{"line_number":24,"context_line":"          ssh-keygen -t rsa -b 4096 -f ~/.ssh/id_rsa -P \"\""},{"line_number":25,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":26,"context_line":"          cat ~/.ssh/id_rsa.pub \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":27,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_3a689af4","line":24,"updated":"2015-12-14 17:18:56.000000000","message":"A tad excessive given these are untrusted, disposable machines. If the job spends too long on key generation, I think you can safely turn this all the way down to the minimum supported keysize for OpenSSH. Especially since the key isn\u0027t even being encrypted to begin with. Also this invocation is broken--you should be using -N not -P (the latter is for providing the old passphrase when updating an existing key, see the ssh-keygen manpage for details). And your -t and -f values are the defaults, so also not needed.","commit_id":"e5b26f1dd3db235edd22eae580c07aac59c2c07d"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"3ff16a462ace4a812932b3bfca70095b17c96755","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      - zuul-git-prep"},{"line_number":22,"context_line":"      - shell: |"},{"line_number":23,"context_line":"          # Allow Jenkins user to ssh into localhost"},{"line_number":24,"context_line":"          ssh-keygen -t rsa -b 4096 -f ~/.ssh/id_rsa -P \"\""},{"line_number":25,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":26,"context_line":"          cat ~/.ssh/id_rsa.pub \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":27,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a710552_70daae7a","line":24,"updated":"2015-12-14 17:37:46.000000000","message":"Oh, one minor correction, you do need -f to prevent it from prompting, unless you run it in a noninteractive process by passing a null stdin.","commit_id":"e5b26f1dd3db235edd22eae580c07aac59c2c07d"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"564a942ed54cdc18ccc0f0e8bc3840415487de85","unresolved":false,"context_lines":[{"line_number":21,"context_line":"      - zuul-git-prep"},{"line_number":22,"context_line":"      - shell: |"},{"line_number":23,"context_line":"          # Allow Jenkins user to ssh into localhost"},{"line_number":24,"context_line":"          ssh-keygen -t rsa -b 4096 -f ~/.ssh/id_rsa -P \"\""},{"line_number":25,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":26,"context_line":"          cat ~/.ssh/id_rsa.pub \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":27,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5a710552_5072127e","line":24,"in_reply_to":"7a740942_3a689af4","updated":"2015-12-14 17:40:07.000000000","message":"agree with everything, except if I don\u0027t use -f, ssh-keygen will prompt user for input","commit_id":"e5b26f1dd3db235edd22eae580c07aac59c2c07d"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"d98f1fa5b80e8457c64b4e599544e17379fc77d3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"      - shell: |"},{"line_number":23,"context_line":"          # Allow Jenkins user to ssh into localhost"},{"line_number":24,"context_line":"          ssh-keygen -t rsa -b 4096 -f ~/.ssh/id_rsa -P \"\""},{"line_number":25,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":26,"context_line":"          cat ~/.ssh/id_rsa.pub \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":27,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":28,"context_line":"          chmod 0600 ~/.ssh/authorized_keys"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_da6ab6ec","line":25,"updated":"2015-12-14 17:18:56.000000000","message":"These blank lines aren\u0027t really necessary.","commit_id":"e5b26f1dd3db235edd22eae580c07aac59c2c07d"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"d98f1fa5b80e8457c64b4e599544e17379fc77d3","unresolved":false,"context_lines":[{"line_number":25,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":26,"context_line":"          cat ~/.ssh/id_rsa.pub \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":27,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":28,"context_line":"          chmod 0600 ~/.ssh/authorized_keys"},{"line_number":29,"context_line":"          ssh-keyscan -H localhost \u003e\u003e ~/.ssh/known_hosts"},{"line_number":30,"context_line":"          ssh-keyscan -H 127.0.0.1 \u003e\u003e ~/.ssh/known_hosts"},{"line_number":31,"context_line":"      - tox:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_fa6d3203","line":28,"updated":"2015-12-14 17:18:56.000000000","message":"What\u0027s the point? Not only as I mentioned earlier is this machine\u0027s security posture not worth protecting, this file is already guaranteed to exist since the Jenkins master installs the slave agent via RSA auth over SSH as this account. And if you\u0027re attempting to set a good example, you should chmod the file _before_ you add things to it, or better still, adjust the umask before ever opening the file in the first place so you don\u0027t introduce chown-based races at all.","commit_id":"e5b26f1dd3db235edd22eae580c07aac59c2c07d"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"d98f1fa5b80e8457c64b4e599544e17379fc77d3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"          cat ~/.ssh/id_rsa.pub \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":27,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":28,"context_line":"          chmod 0600 ~/.ssh/authorized_keys"},{"line_number":29,"context_line":"          ssh-keyscan -H localhost \u003e\u003e ~/.ssh/known_hosts"},{"line_number":30,"context_line":"          ssh-keyscan -H 127.0.0.1 \u003e\u003e ~/.ssh/known_hosts"},{"line_number":31,"context_line":"      - tox:"},{"line_number":32,"context_line":"          envlist: ansible-functional"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_9a798eca","line":29,"updated":"2015-12-14 17:18:56.000000000","message":"-H is unnecessary here, since there\u0027s little point in obscuring the hostnames to which we\u0027re connecting for this.","commit_id":"e5b26f1dd3db235edd22eae580c07aac59c2c07d"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"d98f1fa5b80e8457c64b4e599544e17379fc77d3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"          echo \"\" \u003e\u003e ~/.ssh/authorized_keys"},{"line_number":28,"context_line":"          chmod 0600 ~/.ssh/authorized_keys"},{"line_number":29,"context_line":"          ssh-keyscan -H localhost \u003e\u003e ~/.ssh/known_hosts"},{"line_number":30,"context_line":"          ssh-keyscan -H 127.0.0.1 \u003e\u003e ~/.ssh/known_hosts"},{"line_number":31,"context_line":"      - tox:"},{"line_number":32,"context_line":"          envlist: ansible-functional"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a740942_ba748ace","line":30,"updated":"2015-12-14 17:18:56.000000000","message":"And yet you\u0027re not chmod\u0027ing this file, which likely didn\u0027t exist before here.","commit_id":"e5b26f1dd3db235edd22eae580c07aac59c2c07d"}]}
