)]}'
{"tools/layout-checks.py":[{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0307d11fc965352e599b60adba4673370c9a6cbf","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        if p.match(line):"},{"line_number":99,"context_line":"            found \u003d True"},{"line_number":100,"context_line":"            break"},{"line_number":101,"context_line":"    return found"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"def check_jobs():"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_a844d51a","line":101,"updated":"2015-12-16 00:35:47.000000000","message":"Personally, I find the below easier to read just because it is shorter, but yours is just as correct\n\ndef grep(source, pattern):\n    p \u003d re.compile(pattern)\n    for line in open(source, \"r\").readlines():\n        if p.match(line):\n            return True\n    return False","commit_id":"302e6c643815708a0369883c9482958aa5620660"},{"author":{"_account_id":11809,"name":"Craig Bryant","email":"craig.bryant@hpe.com","username":"craig-bryant"},"change_message_id":"0307d11fc965352e599b60adba4673370c9a6cbf","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        if not found:"},{"line_number":123,"context_line":"            print (\"Regex %s has no matches in job list\" % jobs[\u0027name\u0027])"},{"line_number":124,"context_line":"            errors \u003d True"},{"line_number":125,"context_line":"            count \u003d count + 1"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    return errors"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a710552_48b0d143","line":125,"updated":"2015-12-16 00:35:47.000000000","message":"count is set but never used","commit_id":"302e6c643815708a0369883c9482958aa5620660"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"d3625d971a3c03ca21735a9ddd0310b2d64d65e7","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def grep(source, pattern):"},{"line_number":95,"context_line":"    found \u003d False"},{"line_number":96,"context_line":"    p \u003d re.compile(pattern)"},{"line_number":97,"context_line":"    for line in open(source, \"r\").readlines():"},{"line_number":98,"context_line":"        if p.match(line):"},{"line_number":99,"context_line":"            found \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_eb8abbbe","line":96,"updated":"2015-12-16 12:48:42.000000000","message":"why not use a with open... and read the whole content? that way the file will be closed properly","commit_id":"4b7fd514d81b2a007bcc780a3d89e9ceacf47ea9"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"b5a4da47a7026857a7a570c1d9ecd92afb750044","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def grep(source, pattern):"},{"line_number":95,"context_line":"    found \u003d False"},{"line_number":96,"context_line":"    p \u003d re.compile(pattern)"},{"line_number":97,"context_line":"    for line in open(source, \"r\").readlines():"},{"line_number":98,"context_line":"        if p.match(line):"},{"line_number":99,"context_line":"            found \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"5a710552_ecf97181","line":96,"in_reply_to":"5a710552_eb8abbbe","updated":"2015-12-16 13:30:08.000000000","message":"Done with the followup patch by ian.","commit_id":"4b7fd514d81b2a007bcc780a3d89e9ceacf47ea9"}],"tools/run-layout.sh":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2559987494bd0831d0978dfc5f4225a9c1c0abcc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"tox -e compare-xml-new"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Note that the job-list.txt file is also used by"},{"line_number":48,"context_line":"# tools/layout-checks.py, if this file gets changed, we need to adopt"},{"line_number":49,"context_line":"# the test as well."},{"line_number":50,"context_line":"cd .."},{"line_number":51,"context_line":"find jenkins-job-builder/.test/new/out/ -printf \"%f\\n\" \u003e job-list.txt"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a710552_d5944be3","line":48,"updated":"2015-12-16 09:35:39.000000000","message":"s/adopt/adapt","commit_id":"2f371f0279bd7c65bb29f1a0c59e96c7d6fa5a7d"}]}
