)]}'
{"jenkins/scripts/copy_puppet_logs.sh":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"2f14cf8c04a6b85c3cb8b17066e57c80698531c4","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Make sure jenkins can read all the logs and configs"},{"line_number":168,"context_line":"find $LOG_DIR -type d -execdir chmod 755 \u0027{}\u0027 \\;"},{"line_number":169,"context_line":"find $LOG_DIR -type f -execdir chmod 644 \u0027{}\u0027 \\;"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# rename files to .txt; this is so that when displayed via"},{"line_number":172,"context_line":"# logs.openstack.org clicking results in the browser shows the"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6ed579_755ca125","line":169,"updated":"2016-01-12 19:34:53.000000000","message":"The above lines use sudo to run, yours do not.\nThe second line change is unnecessary, and broader in scope that the original.","commit_id":"de5015992c6a8676a2b37240519cac95cef6a258"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"9053f5fc51071fe355c2204f3d4f40214168de61","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"# Make sure jenkins can read all the logs and configs"},{"line_number":168,"context_line":"find $LOG_DIR -type d -execdir chmod 755 \u0027{}\u0027 \\;"},{"line_number":169,"context_line":"find $LOG_DIR -type f -execdir chmod 644 \u0027{}\u0027 \\;"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"# rename files to .txt; this is so that when displayed via"},{"line_number":172,"context_line":"# logs.openstack.org clicking results in the browser shows the"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da6ed579_d5b9cd2f","line":169,"in_reply_to":"da6ed579_755ca125","updated":"2016-01-12 19:38:18.000000000","message":"Good point about sudo. Will fix. Re: files - last I know puppet managed permissions on some files and folders (i.e, sensitive files being but in 600) however this might not be the case anymore. I can drop this but felt it was a safe addition.","commit_id":"de5015992c6a8676a2b37240519cac95cef6a258"}]}