)]}'
{"tools/check_valid_gerrit_projects.py":[{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"cb5836fe218dcf0fe4189f5a5a6d1a4d248b306a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        \u0027infile\u0027,"},{"line_number":74,"context_line":"        help\u003d\u0027Path to gerrit/projects.yaml\u0027,"},{"line_number":75,"context_line":"    )"},{"line_number":76,"context_line":"    parser.add_argument("},{"line_number":77,"context_line":"        \u0027acldir\u0027,"},{"line_number":78,"context_line":"        help\u003d\u0027Path to gerrit/acl\u0027,"},{"line_number":79,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_2e779b3b","line":76,"range":{"start_line":76,"start_character":4,"end_line":76,"end_character":24},"updated":"2016-04-11 14:42:47.000000000","message":"(nit) this could be optional","commit_id":"92b74e10eb9973baa39c3f74292a667d0cd61a8f"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"cb5836fe218dcf0fe4189f5a5a6d1a4d248b306a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        # Check redundant acl-config"},{"line_number":159,"context_line":"        acl_config \u003d p.get(\u0027acl-config\u0027)"},{"line_number":160,"context_line":"        if acl_config:"},{"line_number":161,"context_line":"            if acl_config.endswith(name + \u0027.config\u0027):"},{"line_number":162,"context_line":"                found_errors +\u003d 1"},{"line_number":163,"context_line":"                print(\"Error: Project %s has redundant acl_config line, \""},{"line_number":164,"context_line":"                      \"remove it.\" % name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_ee3f6323","line":161,"range":{"start_line":161,"start_character":12,"end_line":161,"end_character":53},"updated":"2016-04-11 14:42:47.000000000","message":"We might want to check for the full path, eg \u0027/home/gerrit2/acls/{name}.config\u0027 in case there is \u0027subteam-project.config\u0027 as an acl (which would be odd).","commit_id":"92b74e10eb9973baa39c3f74292a667d0cd61a8f"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f6f8165f40fbfe1e9b6b287d2a88fa45d4272f50","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        # Check redundant acl-config"},{"line_number":159,"context_line":"        acl_config \u003d p.get(\u0027acl-config\u0027)"},{"line_number":160,"context_line":"        if acl_config:"},{"line_number":161,"context_line":"            if acl_config.endswith(name + \u0027.config\u0027):"},{"line_number":162,"context_line":"                found_errors +\u003d 1"},{"line_number":163,"context_line":"                print(\"Error: Project %s has redundant acl_config line, \""},{"line_number":164,"context_line":"                      \"remove it.\" % name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_699b4dca","line":161,"range":{"start_line":161,"start_character":12,"end_line":161,"end_character":53},"in_reply_to":"7a1b2928_ee3f6323","updated":"2016-04-11 14:47:05.000000000","message":"I\u0027m not sure I understand the problem you see. name is \"openstack-infra/project-config\", so this should not cause any issues.","commit_id":"92b74e10eb9973baa39c3f74292a667d0cd61a8f"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"cb5836fe218dcf0fe4189f5a5a6d1a4d248b306a","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                found_errors +\u003d 1"},{"line_number":167,"context_line":"                print(\"Error: Project %s has wrong acl_config line, \""},{"line_number":168,"context_line":"                      \"fix the path.\" % name)"},{"line_number":169,"context_line":"            acl_file \u003d (args.acldir + \"/\" +"},{"line_number":170,"context_line":"                        acl_config[len(\u0027/home/gerrit2/acls/\u0027):])"},{"line_number":171,"context_line":"            if not os.path.isfile(acl_file):"},{"line_number":172,"context_line":"                found_errors +\u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_ce238704","line":169,"range":{"start_line":169,"start_character":24,"end_line":169,"end_character":28},"updated":"2016-04-11 14:42:47.000000000","message":"Should use os.path.join","commit_id":"92b74e10eb9973baa39c3f74292a667d0cd61a8f"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f6f8165f40fbfe1e9b6b287d2a88fa45d4272f50","unresolved":false,"context_lines":[{"line_number":166,"context_line":"                found_errors +\u003d 1"},{"line_number":167,"context_line":"                print(\"Error: Project %s has wrong acl_config line, \""},{"line_number":168,"context_line":"                      \"fix the path.\" % name)"},{"line_number":169,"context_line":"            acl_file \u003d (args.acldir + \"/\" +"},{"line_number":170,"context_line":"                        acl_config[len(\u0027/home/gerrit2/acls/\u0027):])"},{"line_number":171,"context_line":"            if not os.path.isfile(acl_file):"},{"line_number":172,"context_line":"                found_errors +\u003d 1"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_a9f3a509","line":169,"range":{"start_line":169,"start_character":24,"end_line":169,"end_character":28},"in_reply_to":"7a1b2928_ce238704","updated":"2016-04-11 14:47:05.000000000","message":"Done","commit_id":"92b74e10eb9973baa39c3f74292a667d0cd61a8f"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"cb5836fe218dcf0fe4189f5a5a6d1a4d248b306a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                      name)"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            # Check that default file exists"},{"line_number":177,"context_line":"            acl_file \u003d (args.acldir + \"/\" + name + \".config\")"},{"line_number":178,"context_line":"            if not os.path.isfile(acl_file):"},{"line_number":179,"context_line":"                found_errors +\u003d 1"},{"line_number":180,"context_line":"                print(\"Error: Project %s has no default acl-config file\" %"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_2e4f9bbe","line":177,"range":{"start_line":177,"start_character":24,"end_line":177,"end_character":28},"updated":"2016-04-11 14:42:47.000000000","message":"ditto","commit_id":"92b74e10eb9973baa39c3f74292a667d0cd61a8f"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f6f8165f40fbfe1e9b6b287d2a88fa45d4272f50","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                      name)"},{"line_number":175,"context_line":"        else:"},{"line_number":176,"context_line":"            # Check that default file exists"},{"line_number":177,"context_line":"            acl_file \u003d (args.acldir + \"/\" + name + \".config\")"},{"line_number":178,"context_line":"            if not os.path.isfile(acl_file):"},{"line_number":179,"context_line":"                found_errors +\u003d 1"},{"line_number":180,"context_line":"                print(\"Error: Project %s has no default acl-config file\" %"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a1b2928_c9da6178","line":177,"range":{"start_line":177,"start_character":24,"end_line":177,"end_character":28},"in_reply_to":"7a1b2928_2e4f9bbe","updated":"2016-04-11 14:47:05.000000000","message":"Done","commit_id":"92b74e10eb9973baa39c3f74292a667d0cd61a8f"},{"author":{"_account_id":7069,"name":"Joshua Hesketh","email":"josh@nitrotech.org","username":"jhesketh"},"change_message_id":"52605994229ede5b95f35850db283ffa92ab2aa2","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                found_errors +\u003d 1"},{"line_number":180,"context_line":"                print(\"Error: Project %s has no default acl-config file\" %"},{"line_number":181,"context_line":"                      name)"},{"line_number":182,"context_line":"            "},{"line_number":183,"context_line":"    if found_errors:"},{"line_number":184,"context_line":"        print(\"Found %d error(s) in %s\" % (found_errors, args.infile))"},{"line_number":185,"context_line":"        sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a1b2928_69dd0d14","line":182,"range":{"start_line":182,"start_character":0,"end_line":182,"end_character":12},"updated":"2016-04-11 14:51:23.000000000","message":"eww","commit_id":"7d6c737beca2f97b69e6d7e545944813a53afa5e"}]}
