)]}'
{"id":"openstack%2Fproject-config~308708","triplet_id":"openstack%2Fproject-config~master~Ie5e7d2318a510a5811c9131d56594e856da9dcc5","project":"openstack/project-config","branch":"master","topic":"fix-req-failure-msg","hashtags":[],"change_id":"Ie5e7d2318a510a5811c9131d56594e856da9dcc5","subject":"Fix comment on requirements job","status":"MERGED","created":"2016-04-21 01:48:10.000000000","updated":"2016-04-21 09:56:31.000000000","submitted":"2016-04-21 09:56:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"cf2fbae0e011737bdfcf96a941801be1799dec97","_number":308708,"virtual_id_number":308708,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-04-21 09:56:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":0,"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-04-21 07:02:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":2,"date":"2016-04-21 09:45:55.000000000","_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"value":1,"date":"2016-04-21 09:45:55.000000000","_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-21 07:02:47.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2016-04-21 09:45:55.000000000","updated_by":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"reviewer":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"state":"REVIEWER"},{"updated":"2016-04-21 09:56:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"6de9369d783156e278f30fd5eb3e18981c6a27ce","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-04-21 01:48:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e2500927583dabae5b508cc053b1499a2276ffa4","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-04-21 01:56:23.000000000","message":"Patch Set 1:\n\n- foo http://foo.com : bar blah \n- foo http://foo.com : http://foo.com","accounts_in_message":[],"_revision_number":1},{"id":"c158e6a18ad0c6d20516f2b38643f17881cfd5c8","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-04-21 01:58:11.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"14e912db95f4d813f9bb77eee0ed8c1ab5e03c2d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-21 02:07:31.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-project-config-layout http://logs.openstack.org/08/308708/2/check/gate-project-config-layout/2431248/ : SUCCESS in 6m 03s\n- gate-project-config-linters http://logs.openstack.org/08/308708/2/check/gate-project-config-linters/edaf05f/ : SUCCESS in 1m 46s","accounts_in_message":[],"_revision_number":2},{"id":"632b67f5de89155ff70c144a3649109727be2944","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-04-21 02:25:00.000000000","message":"Patch Set 2: Workflow-1\n\ndamn it, firebug is turning the result around on me.  chrome shows the actual html and explains why the target\u003d\"_blank\" is last.  so i think it\u0027s our regex","accounts_in_message":[],"_revision_number":2},{"id":"bc14093b0af396a42d8d644aa4d208a4ee4877ad","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-04-21 04:01:09.000000000","message":"Uploaded patch set 3: Commit message was updated.","accounts_in_message":[],"_revision_number":3},{"id":"60c2b3b976bde0e83ae21b9cf513512784c681b8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-21 04:08:21.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-project-config-layout http://logs.openstack.org/08/308708/3/check/gate-project-config-layout/c1e0f68/ : SUCCESS in 6m 51s\n- gate-project-config-linters http://logs.openstack.org/08/308708/3/check/gate-project-config-linters/b1a51fc/ : SUCCESS in 1m 55s","accounts_in_message":[],"_revision_number":3},{"id":"2670797dd619d91a4b0e50ab45c87cd1214a7f79","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2016-04-21 07:02:47.000000000","message":"Patch Set 3: Code-Review+2\n\nGood idea, thanks!","accounts_in_message":[],"_revision_number":3},{"id":"0ece143768c1c0aae00b606364dab89d53069e5f","author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"date":"2016-04-21 09:45:55.000000000","message":"Patch Set 3: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":3},{"id":"d8e4a3c02b30779795e89126e67e876401010a2b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-21 09:46:00.000000000","message":"Patch Set 3: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"accec8618963cc436138dbcdf1e0d92f5a9aa244","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-21 09:56:30.000000000","message":"Patch Set 3: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-project-config-layout http://logs.openstack.org/08/308708/3/gate/gate-project-config-layout/6876cfd/ : SUCCESS in 6m 15s\n- gate-project-config-linters http://logs.openstack.org/08/308708/3/gate/gate-project-config-linters/b172aaf/ : SUCCESS in 2m 53s","accounts_in_message":[],"_revision_number":3},{"id":"7e18598c1fd12ed886e7a7da67f0849b02b765d7","date":"2016-04-21 09:56:31.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"4f96b2727c2afd3c3d6b888c21c8d18ba1cb7376","revisions":{"e5f68d0a6f3ac9029104753db623bfe688be16d4":{"kind":"REWORK","_number":1,"created":"2016-04-21 01:48:10.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/08/308708/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/08/308708/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/08/308708/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/08/308708/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/08/308708/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/08/308708/1"}}},"commit":{"parents":[{"commit":"4e80ebfbab780110e5cfb40597602127ec777bfe","subject":"Merge \"Slowly turn rax-ord back on in nodepool\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4e80ebfbab780110e5cfb40597602127ec777bfe"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2016-04-21 00:37:22.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2016-04-21 01:47:14.000000000","tz":600},"subject":"Fix comment on requirements job","message":"Fix comment on requirements job\n\nFor reasons I don\u0027t want to even think about, somewhere in gerrit\u0027s\ncomment-\u003eHTML logic it seems if you put in\n\n- foo http://foo.com : bar blah\n- foo http://foo.com : http://foo.com\n\nthe \"linkify\" bits takes two different paths.  In the first one, you\nget\n\n \u003cli\u003e\u003ca href\u003d\"http://foo.com\" target\u003d\"_blank\"\u003efoo.com\u003c/a\u003e : bar blah\u003c/li\u003e\n\nand in the second\n\n \u003cli\u003e\u003ca target\u003d\"_blank\" href\u003d\"http://foo.com\"\u003efoo.com : ...\n\ni.e. if there\u0027s a second link in the line, the the \"target\" gets\nturned around before the href.  I think it somewhere in [2].\n\nThus comments like this then fails the regex at [3], which then\nfurther makes the UI javascript stuff we have not recognise the\nfailure.\n\nAdditionally, that regex doesn\u0027t match if there\u0027s links in the\ncomments anyway, for other reasons I don\u0027t want to think about either,\nso even if gerrit was consistent I don\u0027t think it would work.\n\nThe end result is that you get a jenkins failure but the test doesn\u0027t\ncome up in the CI list, like at [2].\n\nJust give this test a standard failure message, and put the link in\nthe script if it fails.  This way you get the same info in the logs\nanyway.\n\n[1] http://git.openstack.org/cgit/openstack-infra/system-config/tree/modules/openstack_project/manifests/gerrit.pp#n166\n[2] https://gerrit.googlesource.com/gerrit/+/master/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtml.java#128\n[3] https://review.openstack.org/#/c/292193/\n\nChange-Id: Ie5e7d2318a510a5811c9131d56594e856da9dcc5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/e5f68d0a6f3ac9029104753db623bfe688be16d4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/e5f68d0a6f3ac9029104753db623bfe688be16d4"}]},"branch":"refs/heads/master"},"f7dc9f5bf4e348f5647c6e3f7c86923bf1e4cad3":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-04-21 01:58:11.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/08/308708/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/08/308708/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/08/308708/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/08/308708/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/08/308708/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/08/308708/2"}}},"commit":{"parents":[{"commit":"4e80ebfbab780110e5cfb40597602127ec777bfe","subject":"Merge \"Slowly turn rax-ord back on in nodepool\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4e80ebfbab780110e5cfb40597602127ec777bfe"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2016-04-21 00:37:22.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2016-04-21 01:57:15.000000000","tz":600},"subject":"Fix comment on requirements job","message":"Fix comment on requirements job\n\nFor reasons I don\u0027t want to even think about, somewhere in gerrit\u0027s\ncomment-\u003eHTML logic it seems if you put in\n\n- foo http://foo.com : bar blah\n- foo http://foo.com : http://foo.com\n\nthe \"linkify\" bits takes two different paths.  In the first one, you\nget\n\n \u003cli\u003e\u003ca href\u003d\"http://foo.com\" target\u003d\"_blank\"\u003efoo.com\u003c/a\u003e : bar blah\u003c/li\u003e\n\nand in the second\n\n \u003cli\u003e\u003ca target\u003d\"_blank\" href\u003d\"http://foo.com\"\u003efoo.com : ...\n\ni.e. if there\u0027s a second link in the line, the the \"target\" gets\nturned around before the href.  I think it somewhere in [1].\n\nThus comments like this then fails the regex at [2], which then\nfurther makes the UI javascript stuff we have not recognise the\nfailure.\n\nAdditionally, that regex doesn\u0027t match if there\u0027s links in the\ncomments anyway, for other reasons I don\u0027t want to think about either,\nso even if gerrit was consistent I don\u0027t think it would work.\n\nThe end result is that you get a jenkins failure but the test doesn\u0027t\ncome up in the CI list, like at [3].\n\nJust give this test a standard failure message, and put the link in\nthe script if it fails.  This way you get the same info in the logs\nanyway.\n\n[1] https://gerrit.googlesource.com/gerrit/+/master/gerrit-gwtexpui/src/main/java/com/google/gwtexpui/safehtml/client/SafeHtml.java#128\n[2] http://git.openstack.org/cgit/openstack-infra/system-config/tree/modules/openstack_project/manifests/gerrit.pp#n166\n[3] https://review.openstack.org/#/c/292193/\n\nChange-Id: Ie5e7d2318a510a5811c9131d56594e856da9dcc5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/f7dc9f5bf4e348f5647c6e3f7c86923bf1e4cad3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/f7dc9f5bf4e348f5647c6e3f7c86923bf1e4cad3"}]},"branch":"refs/heads/master"},"4f96b2727c2afd3c3d6b888c21c8d18ba1cb7376":{"kind":"NO_CODE_CHANGE","_number":3,"created":"2016-04-21 04:01:09.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/08/308708/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/08/308708/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/08/308708/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/08/308708/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/08/308708/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/08/308708/3"}}},"commit":{"parents":[{"commit":"4e80ebfbab780110e5cfb40597602127ec777bfe","subject":"Merge \"Slowly turn rax-ord back on in nodepool\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4e80ebfbab780110e5cfb40597602127ec777bfe"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2016-04-21 00:37:22.000000000","tz":600},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2016-04-21 03:57:59.000000000","tz":600},"subject":"Fix comment on requirements job","message":"Fix comment on requirements job\n\nCurrently failures of this job leave a broken comment that doesn\u0027t\nmatch the test-result regexes, meaning that you can\u0027t see the result\nin the callout box.  See [1].\n\nI863d88e9a7ed2fd41924b8fc4a12dbea3ee2b205 fixes the root cause, but\nthis message is still a bit wrong because it doesn\u0027t have the\n[PASSED|FAILURE] bit.\n\nI don\u0027t really see why we need this special result at all.  If it\nfails, you have to read the log anyway to figure out what is wrong, so\nmove the message pointing to the docs to where the failure actually\nhappens in the logs.\n\n[1] https://review.openstack.org/#/c/292193/\n\nChange-Id: Ie5e7d2318a510a5811c9131d56594e856da9dcc5\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4f96b2727c2afd3c3d6b888c21c8d18ba1cb7376"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4f96b2727c2afd3c3d6b888c21c8d18ba1cb7376"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}