)]}'
{"jenkins/scripts/run-tarball.sh":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"577a6ece12aef09f57d2fc968ef73154a9b92c87","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    puppet module build ."},{"line_number":24,"context_line":"    # NOTE(pabelanger): Here we are converting openstack-neutron-8.0.0.tar.gz to"},{"line_number":25,"context_line":"    # puppet-neutron-8.0.0.tar.gz."},{"line_number":26,"context_line":"    find . -name openstack-*.tar.gz | sed -e \"p;s/openstack-/puppet-/\" | xargs -n2 mv"},{"line_number":27,"context_line":"    mkdir -p dist"},{"line_number":28,"context_line":"    if echo $ZUUL_REFNAME | grep refs/tags/ \u003e/dev/null ; then"},{"line_number":29,"context_line":"        # NOTE(pabelanger) We don\u0027t need to rename tagged tarballs as `puppet"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a122d0e_585582f8","line":26,"updated":"2016-05-02 14:38:04.000000000","message":"since you remove all openstack-* files, why do we need MODULE_NAME then?\nOn line 33, we can do  mv pkg/puppet-*.tar.gz dist/","commit_id":"619c8066ccc4132c1a7ba8af041fe58559468428"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"3c7f5a4d6a69387221aec39dd60287316c03508f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    puppet module build ."},{"line_number":24,"context_line":"    # NOTE(pabelanger): Here we are converting openstack-neutron-8.0.0.tar.gz to"},{"line_number":25,"context_line":"    # puppet-neutron-8.0.0.tar.gz."},{"line_number":26,"context_line":"    find . -name openstack-*.tar.gz | sed -e \"p;s/openstack-/puppet-/\" | xargs -n2 mv"},{"line_number":27,"context_line":"    mkdir -p dist"},{"line_number":28,"context_line":"    if echo $ZUUL_REFNAME | grep refs/tags/ \u003e/dev/null ; then"},{"line_number":29,"context_line":"        # NOTE(pabelanger) We don\u0027t need to rename tagged tarballs as `puppet"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a122d0e_98ad5aed","line":26,"in_reply_to":"1a122d0e_585582f8","updated":"2016-05-02 14:40:13.000000000","message":"we are only replacing openstack with puppet, which means the version info is still in the filename.\n\nWith line 33, we\u0027d never create puppet-foo-master, puppet-foo-stable-liberty, puppet-foo-stable-mitaka","commit_id":"619c8066ccc4132c1a7ba8af041fe58559468428"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9d9a8cb5deab4fa1c20845688239e3c01b52c41e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # module build` does the right thing."},{"line_number":31,"context_line":"        mv pkg/*.tar.gz dist/"},{"line_number":32,"context_line":"    else"},{"line_number":33,"context_line":"        mv pkg/*.tar.gz dist/$MODULE_NAME.tar.gz"},{"line_number":34,"context_line":"else"},{"line_number":35,"context_line":"# this a python project"},{"line_number":36,"context_line":"    venv\u003d${1:-venv}"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a122d0e_b8b49635","line":33,"updated":"2016-05-02 14:40:42.000000000","message":"you missed the \"fi\"","commit_id":"619c8066ccc4132c1a7ba8af041fe58559468428"}]}