)]}'
{"jenkins/jobs/monasca.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"7571cf51c9fe23689c7db330a4df3dc83880dfbc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"          export PROJECTS\u003d\"openstack/monasca-api openstack/monasca-persister openstack/monasca-common openstack/monasca-agent $PROJECTS\""},{"line_number":22,"context_line":"          export PROJECTS\u003d\"openstack/monasca-notification openstack/monasca-thresh openstack/monasca-statsd $PROJECTS\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"          function pre_test_hook {"},{"line_number":25,"context_line":"              source $BASE/new/monasca-api/devstack/pre_test_hook.sh"},{"line_number":26,"context_line":"          }"},{"line_number":27,"context_line":"          export -f pre_test_hook"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bab6814e_82f7f889","line":24,"updated":"2016-05-20 20:22:40.000000000","message":"The error being raised is somewhat misleading (a secondary error because it misparsed this). In JJB job-templates, you need to double {{ and }} to escape them.","commit_id":"fb541d25fb1e3860aec9b89fe6afe2d909f6a7dd"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f3e3e1548d26a64e2af8d7b664a1b4c80f6289eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- job-template:"},{"line_number":2,"context_line":"    name: gate-{name}-tempest-dsvm"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"    node: ubuntu-trusty"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9abb7d3a_6f43bf13","line":2,"range":{"start_line":2,"start_character":9,"end_line":2,"end_character":34},"updated":"2016-06-01 13:50:37.000000000","message":"That\u0027s far too generic. Btw. usually jobs are called gate-tempest-dsvm-{name}-XXX.\n\nSo, add some XXX, please ;). Also below","commit_id":"68f74ad6cb7d408bf71bbe96afcf7c0d20b0e11d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f3e3e1548d26a64e2af8d7b664a1b4c80f6289eb","unresolved":false,"context_lines":[{"line_number":18,"context_line":"          export DEVSTACK_GATE_NEUTRON\u003d1"},{"line_number":19,"context_line":"          export ENABLED_SERVICES\u003dtempest"},{"line_number":20,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin monasca-api git://git.openstack.org/openstack/monasca-api\""},{"line_number":21,"context_line":"          export PROJECTS\u003d\"openstack/monasca-api openstack/monasca-persister openstack/monasca-common openstack/monasca-agent $PROJECTS\""},{"line_number":22,"context_line":"          export PROJECTS\u003d\"openstack/monasca-notification openstack/monasca-thresh openstack/monasca-statsd $PROJECTS\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"          function pre_test_hook {{"},{"line_number":25,"context_line":"              source $BASE/new/monasca-api/devstack/pre_test_hook.sh"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9abb7d3a_0f62f3d7","line":22,"range":{"start_line":21,"start_character":10,"end_line":22,"end_character":10},"updated":"2016-06-01 13:50:37.000000000","message":"Let\u0027s use one entry per line - that\u0027s our usual convention.","commit_id":"68f74ad6cb7d408bf71bbe96afcf7c0d20b0e11d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f3e3e1548d26a64e2af8d7b664a1b4c80f6289eb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"          export ENABLED_SERVICES\u003dtempest"},{"line_number":60,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin monasca-api git://git.openstack.org/openstack/monasca-api\""},{"line_number":61,"context_line":"          export PROJECTS\u003d\"openstack/monasca-api openstack/monasca-persister openstack/monasca-common openstack/monasca-agent $PROJECTS\""},{"line_number":62,"context_line":"          export PROJECTS\u003d\"openstack/monasca-notification openstack/monasca-thresh openstack/monasca-statsd $PROJECTS\""},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"MONASCA_API_IMPLEMENTATION_LANG\u003djava\""},{"line_number":65,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"MONASCA_PERSISTER_IMPLEMENTATION_LANG\u003djava\""}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9abb7d3a_ef4faf31","line":62,"updated":"2016-06-01 13:50:37.000000000","message":"like above","commit_id":"68f74ad6cb7d408bf71bbe96afcf7c0d20b0e11d"}],"jenkins/jobs/projects.yaml":[{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"866fe11c85a4425e08aea67adcf26692798ce541","unresolved":false,"context_lines":[{"line_number":3277,"context_line":"    jobs:"},{"line_number":3278,"context_line":"      - python-jobs"},{"line_number":3279,"context_line":"      - pypi-jobs"},{"line_number":3280,"context_line":"      - gate-{name}-tempest-dsvm"},{"line_number":3281,"context_line":""},{"line_number":3282,"context_line":"- project:"},{"line_number":3283,"context_line":"    name: monasca-api"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_5a7ad7bd","line":3280,"range":{"start_line":3280,"start_character":8,"end_line":3280,"end_character":32},"updated":"2016-05-23 15:53:58.000000000","message":"This is probably fine for now, but it only really tests the install of the agent. We need a better test for the functionality","commit_id":"a24d0b19a29b537d70f3f0c4c58cc976ff458251"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"866fe11c85a4425e08aea67adcf26692798ce541","unresolved":false,"context_lines":[{"line_number":3324,"context_line":"    jobs:"},{"line_number":3325,"context_line":"      - python-jobs"},{"line_number":3326,"context_line":"      - pypi-jobs"},{"line_number":3327,"context_line":"      - gate-{name}-tempest-dsvm"},{"line_number":3328,"context_line":""},{"line_number":3329,"context_line":"- project:"},{"line_number":3330,"context_line":"    name: monasca-persister"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_da8a471a","line":3327,"range":{"start_line":3327,"start_character":8,"end_line":3327,"end_character":32},"updated":"2016-05-23 15:53:58.000000000","message":"Should probably test both python and java api here","commit_id":"a24d0b19a29b537d70f3f0c4c58cc976ff458251"},{"author":{"_account_id":14517,"name":"Ryan Brandt","email":"ryan.brandt@hpe.com","username":"ryan-brandt"},"change_message_id":"866fe11c85a4425e08aea67adcf26692798ce541","unresolved":false,"context_lines":[{"line_number":3352,"context_line":""},{"line_number":3353,"context_line":"    jobs:"},{"line_number":3354,"context_line":"      - maven-plugin-jobs"},{"line_number":3355,"context_line":"      - gate-{name}-java-tempest-dsvm"},{"line_number":3356,"context_line":""},{"line_number":3357,"context_line":"- project:"},{"line_number":3358,"context_line":"    name: monasca-ui"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bab6814e_5a7f7714","line":3355,"range":{"start_line":3355,"start_character":8,"end_line":3355,"end_character":37},"updated":"2016-05-23 15:53:58.000000000","message":"same as above","commit_id":"a24d0b19a29b537d70f3f0c4c58cc976ff458251"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"839aab2dc602a92ea9fa82fb196bc6c163cc931d","unresolved":false,"context_lines":[{"line_number":3272,"context_line":"    jobs:"},{"line_number":3273,"context_line":"      - python-jobs"},{"line_number":3274,"context_line":"      - pypi-jobs"},{"line_number":3275,"context_line":"      - tempest-monasca-full-jobs"},{"line_number":3276,"context_line":""},{"line_number":3277,"context_line":"- project:"},{"line_number":3278,"context_line":"    name: monasca-api"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9abb7d3a_8fae96e5","line":3275,"updated":"2016-06-02 15:54:40.000000000","message":"The multiple instantiations of the tempest-monasca-full-jobs job group is the problem. Each instantiation creates a new copy of the jobs in the group. Since the job names don\u0027t differ on each instantiation you get duplicate job names and the test fails. You only need to instantiate the job template once.","commit_id":"9dba174e1f93149a14ef64be74d0624e25a0755f"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"15f297d067b1fcf2e07a772d8838a510eb0cb0d4","unresolved":false,"context_lines":[{"line_number":3272,"context_line":"    jobs:"},{"line_number":3273,"context_line":"      - python-jobs"},{"line_number":3274,"context_line":"      - pypi-jobs"},{"line_number":3275,"context_line":"      - tempest-monasca-full-jobs"},{"line_number":3276,"context_line":""},{"line_number":3277,"context_line":"- project:"},{"line_number":3278,"context_line":"    name: monasca-api"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9abb7d3a_2bbe7dd4","line":3275,"in_reply_to":"9abb7d3a_8fae96e5","updated":"2016-06-02 16:13:14.000000000","message":"Thanks for pointing this out! A new patch is on the way.","commit_id":"9dba174e1f93149a14ef64be74d0624e25a0755f"}],"zuul/layout.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"9b5a2e957c7da9e4fd97216b070afac673096000","unresolved":false,"context_lines":[{"line_number":7445,"context_line":"      - name: publish-to-pypi"},{"line_number":7446,"context_line":"    check:"},{"line_number":7447,"context_line":"      - gate-monasca-agent-pep8"},{"line_number":7448,"context_line":"      - gate-monasca-agent-python27"},{"line_number":7449,"context_line":"    gate:"},{"line_number":7450,"context_line":"      - gate-monasca-agent-pep8"},{"line_number":7451,"context_line":"      - gate-monasca-agent-python27"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bab6814e_a3cb1e52","line":7448,"updated":"2016-05-26 17:18:06.000000000","message":"You need to add the new job here as well. Otherwise the job may be failing and you won\u0027t discover that until after approval.","commit_id":"b2bbc47217db51619b8f601e8c9742bec230d559"},{"author":{"_account_id":18179,"name":"Kaiyan Sheng","email":"kaiyan.sheng@hpe.com","username":"kaiyan-sheng"},"change_message_id":"242a29c0cd1c5fa136e588cb677c230bc3d0b8a0","unresolved":false,"context_lines":[{"line_number":7445,"context_line":"      - name: publish-to-pypi"},{"line_number":7446,"context_line":"    check:"},{"line_number":7447,"context_line":"      - gate-monasca-agent-pep8"},{"line_number":7448,"context_line":"      - gate-monasca-agent-python27"},{"line_number":7449,"context_line":"    gate:"},{"line_number":7450,"context_line":"      - gate-monasca-agent-pep8"},{"line_number":7451,"context_line":"      - gate-monasca-agent-python27"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bab6814e_037f8ae0","line":7448,"in_reply_to":"bab6814e_a3cb1e52","updated":"2016-05-26 17:23:35.000000000","message":"Yes you are right! Thanks! Will post a new patch right away!","commit_id":"b2bbc47217db51619b8f601e8c9742bec230d559"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f3e3e1548d26a64e2af8d7b664a1b4c80f6289eb","unresolved":false,"context_lines":[{"line_number":2846,"context_line":"  - name: gate-monasca-api-java-tempest-dsvm"},{"line_number":2847,"context_line":"    voting: false"},{"line_number":2848,"context_line":""},{"line_number":2849,"context_line":"  - name: gate-monasca-agent-tempest-dsvm"},{"line_number":2850,"context_line":"    voting: false"},{"line_number":2851,"context_line":""},{"line_number":2852,"context_line":"  - name: gate-monasca-common-tempest-dsvm"},{"line_number":2853,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"9abb7d3a_2fc0974f","line":2850,"range":{"start_line":2849,"start_character":10,"end_line":2850,"end_character":17},"updated":"2016-06-01 13:50:37.000000000","message":"I suggest to name the job \"-nv\" using {job-suffix} like other dsvm jobs. Then you don\u0027t need all these voting lines.","commit_id":"68f74ad6cb7d408bf71bbe96afcf7c0d20b0e11d"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f9709bcc25aa49de356cf7a7718ed86c303bcbe6","unresolved":false,"context_lines":[{"line_number":7484,"context_line":"    check:"},{"line_number":7485,"context_line":"      - gate-monasca-agent-pep8"},{"line_number":7486,"context_line":"      - gate-monasca-agent-python27"},{"line_number":7487,"context_line":"      - \u0027gate-tempest-dsvm-monasca-python-full-nv\u0027"},{"line_number":7488,"context_line":"      - \u0027gate-tempest-dsvm-monasca-java-full-nv\u0027"},{"line_number":7489,"context_line":"    gate:"},{"line_number":7490,"context_line":"      - gate-monasca-agent-pep8"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"9abb7d3a_9436a1e5","line":7487,"range":{"start_line":7487,"start_character":8,"end_line":7487,"end_character":50},"updated":"2016-06-02 18:21:12.000000000","message":"No need for these \u0027quotation marks\u0027. could you remove them for consistency, please?","commit_id":"99237699281c367685299579ab9c231714715946"}]}