)]}'
{"jenkins/jobs/macros.yaml":[{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"19fc4a8e58a30b16427eb7af0622ebd550fa55a1","unresolved":false,"context_lines":[{"line_number":252,"context_line":"- builder:"},{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          local retval"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3aaa91ec_d8e073cf","line":255,"updated":"2016-06-27 17:39:29.000000000","message":"Suggestion is also to put \n\n#!/bin/bash -x\n\nas the first line here.","commit_id":"c52dedb948a81087e72bafbf48a41f47b9b5943d"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"f28bc6f9596186f73ef2cb267bf9b22a188ba71f","unresolved":false,"context_lines":[{"line_number":252,"context_line":"- builder:"},{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          local retval"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3aaa91ec_d898731e","line":255,"in_reply_to":"3aaa91ec_d8e073cf","updated":"2016-06-27 17:45:48.000000000","message":"I think I spelled it wrong in IRC, the invocation that we assumed had existed before was \u0027set -e\u0027. But wherever it had been before, I guess it was removed for reason and chances are non-zero that we\u0027ll break other people\u0027s code with it. \n\nSo I\u0027d like to stick for now to just restoring exit code at the end of script.","commit_id":"c52dedb948a81087e72bafbf48a41f47b9b5943d"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"c53f816363f620135471af76e1c9640236280613","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          local retval"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_13865c13","line":256,"range":{"start_line":256,"start_character":16,"end_line":256,"end_character":22},"updated":"2016-06-27 18:01:34.000000000","message":"Could also use #!/bin/bash -x to drop out on any error","commit_id":"2cd6a43a16734d20add053c23f44b05d75688767"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"7f4a9abeca66d2a07871fd67e03ac4e948cc2d58","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          local retval"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_79c05e7d","line":256,"range":{"start_line":256,"start_character":16,"end_line":256,"end_character":22},"in_reply_to":"3aaa91ec_13865c13","updated":"2016-06-27 19:24:26.000000000","message":"I think this is superior as well.","commit_id":"2cd6a43a16734d20add053c23f44b05d75688767"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"f55648641e1687119ade4954a002723434f53426","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          local retval"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_53c6244a","line":256,"range":{"start_line":256,"start_character":16,"end_line":256,"end_character":22},"in_reply_to":"3aaa91ec_13865c13","updated":"2016-06-27 18:03:07.000000000","message":"Steve, is it your joint flashmob with Matt ;)? (see previous comment from him)","commit_id":"2cd6a43a16734d20add053c23f44b05d75688767"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"2d33c7e635929733bec076033b8e47957ef41602","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          local retval"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_1e9ae0c5","line":256,"range":{"start_line":256,"start_character":16,"end_line":256,"end_character":22},"in_reply_to":"3aaa91ec_53c6244a","updated":"2016-06-27 19:02:49.000000000","message":"No, I didn\u0027t see the comment and saw the +1  :)","commit_id":"2cd6a43a16734d20add053c23f44b05d75688767"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"5e83444caefaf3a674b191f322022724a09d1fd4","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          local retval"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_cf6b8484","line":256,"range":{"start_line":256,"start_character":16,"end_line":256,"end_character":22},"in_reply_to":"3aaa91ec_79c05e7d","updated":"2016-06-27 20:15:27.000000000","message":"To be clear, it\u0027s -e to drop out on error, not -x...-x just logs commands/output.","commit_id":"2cd6a43a16734d20add053c23f44b05d75688767"},{"author":{"_account_id":6554,"name":"Spencer Krum","email":"nibz@spencerkrum.com","username":"krum-spencer"},"change_message_id":"25b3bf42858fdda677eb7bb7d18f1dd278d03bc7","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          local retval"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_2fd5e8b8","line":256,"range":{"start_line":256,"start_character":16,"end_line":256,"end_character":22},"in_reply_to":"3aaa91ec_cf6b8484","updated":"2016-06-27 20:25:43.000000000","message":"Haha, fair. :) -eux for great good!","commit_id":"2cd6a43a16734d20add053c23f44b05d75688767"},{"author":{"_account_id":10063,"name":"Steve McLellan","email":"steven.j.mclellan@gmail.com","username":"sjmc7"},"change_message_id":"0a6660e5e9a256430d6f93fb001db854ae3d0553","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          local retval"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3aaa91ec_cf1f04b6","line":256,"range":{"start_line":256,"start_character":16,"end_line":256,"end_character":22},"in_reply_to":"3aaa91ec_cf6b8484","updated":"2016-06-27 20:26:18.000000000","message":"Yeah, sorry - should be\n\n#!/bin/bash -xe\n\nBut my point still holds :)  Sorry for the confusion","commit_id":"2cd6a43a16734d20add053c23f44b05d75688767"},{"author":{"_account_id":8040,"name":"Timur Sufiev","email":"tsufiev@gmail.com","username":"tsufiev"},"change_message_id":"c4880989f6e448c2e0b722471d9139792cb65e54","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          #!/bin/bash -eux"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_53045ac5","line":256,"updated":"2016-06-27 21:29:14.000000000","message":"On the second thought, I agreed too fast. What if \u0027npm run\u0027 completes with non zero status, will lines 270-273 be executed? If not, it\u0027s very likely that we\u0027re breaking something.","commit_id":"2d067f4803be78001d504fbfff304db69d7322bf"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"824c9c32199dc94c4033fc381407f8d79ac01fdd","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          #!/bin/bash -eux"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_332f0ef8","line":256,"in_reply_to":"3aaa91ec_53045ac5","updated":"2016-06-27 21:35:09.000000000","message":"I don\u0027t think it WAS being executed before; if we do need to do that then your approach is better.  Let\u0027s rely on the infra guys to give us direction here.","commit_id":"2d067f4803be78001d504fbfff304db69d7322bf"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"58e73508948fa7fb1a94dee8c3adc74ce4470450","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          #!/bin/bash -eux"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_9c69a628","line":256,"in_reply_to":"3aaa91ec_53045ac5","updated":"2016-06-28 05:57:27.000000000","message":"If npm runs fails with non zero status, then the script will abort immediately if you use \"bash -e\". So, the npm prune/shrinkwrap will not get executed.\n\nBut if it fails, why should those get generated?","commit_id":"2d067f4803be78001d504fbfff304db69d7322bf"},{"author":{"_account_id":14124,"name":"Matt Borland","email":"matt.borland@hpe.com","username":"mborland"},"change_message_id":"232a8a3f91e8bdb6d6c551d56716883c55ca3848","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          #!/bin/bash -eux"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_f38e0226","line":256,"in_reply_to":"3aaa91ec_9c69a628","updated":"2016-06-28 13:02:01.000000000","message":"Timur, I\u0027m fine with no shrinkwrap...what we really need (and still get) is the log of the command and its failure.","commit_id":"2d067f4803be78001d504fbfff304db69d7322bf"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"1927523d5981e024a85d491777ff39e8121338ba","unresolved":false,"context_lines":[{"line_number":253,"context_line":"    name: npm-run"},{"line_number":254,"context_line":"    builders:"},{"line_number":255,"context_line":"      - shell: |"},{"line_number":256,"context_line":"          #!/bin/bash -eux"},{"line_number":257,"context_line":"          export DISPLAY\u003d:99"},{"line_number":258,"context_line":"          npm install"},{"line_number":259,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3aaa91ec_fa2d2efe","line":256,"in_reply_to":"3aaa91ec_f38e0226","updated":"2016-06-28 15:00:07.000000000","message":"Exiting on errors vs. shrinkwrap are two different discussions.\n\nWe should exit on errors, period.\n\nIt is helpful if we have shrinkwrap output for a failed build, so we can see which dependencies were included in this particular run. That, however, can be achieved by running shrinkwrap in a different macro, and/or running it right after npm install.","commit_id":"2d067f4803be78001d504fbfff304db69d7322bf"}]}