)]}'
{"id":"openstack%2Fproject-config~336955","triplet_id":"openstack%2Fproject-config~master~I51ed3bca4e27e82d75c063a7c2a6412174216d14","project":"openstack/project-config","branch":"master","topic":"bug/1598581","hashtags":[],"change_id":"I51ed3bca4e27e82d75c063a7c2a6412174216d14","subject":"Enable file injection in neutron full ssh job","status":"MERGED","created":"2016-07-03 23:48:29.000000000","updated":"2016-08-12 02:46:21.000000000","submitted":"2016-08-09 20:27:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"5ab5a35bcf03767c49ed248698d73207a3067715","_number":336955,"virtual_id_number":336955,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":0,"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"date":"2016-08-12 02:46:21.000000000","post_submit":true,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":2,"date":"2016-08-09 20:27:29.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"recommended":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"all":[{"value":0,"date":"2016-07-13 09:07:44.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":1,"date":"2016-08-09 19:45:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":2,"date":"2016-08-09 20:15:31.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-07-05 18:32:19.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"all":[{"value":0,"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},{"value":0,"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"value":1,"date":"2016-08-09 20:15:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-05 18:32:19.000000000","updated_by":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"reviewer":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"state":"REVIEWER"},{"updated":"2016-07-13 09:07:44.000000000","updated_by":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"reviewer":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"state":"REVIEWER"},{"updated":"2016-08-09 19:45:11.000000000","updated_by":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"reviewer":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"state":"REVIEWER"},{"updated":"2016-08-09 20:15:31.000000000","updated_by":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"reviewer":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"state":"REVIEWER"},{"updated":"2016-08-09 20:27:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0cfc33ea89f14febf8521450e243b318f1e20526","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-07-03 23:48:29.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"8c60b3e664988e009b8e8c19278f286e9ad16764","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-03 23:56:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-project-config-compare-xml http://logs.openstack.org/55/336955/1/check/gate-project-config-compare-xml/aba0520/ : Jenkins XML output has changed. in 7m 46s (non-voting)\n- gate-project-config-layout http://logs.openstack.org/55/336955/1/check/gate-project-config-layout/6798054/ : SUCCESS in 7m 07s\n- gate-project-config-jenkins-project http://logs.openstack.org/55/336955/1/check/gate-project-config-jenkins-project/137ebdb/ : SUCCESS in 1m 25s","accounts_in_message":[],"_revision_number":1},{"id":"f0d29697bb07d9059ffcec5df6ecd0ba33f759c0","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2016-07-04 08:29:02.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"37b6fd05dd40af52920442a468c3632860b3d033","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-07-04 13:08:26.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a924e94a62aececf0e3ed46b429e12193ba52d1b","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-07-04 13:09:02.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"0fee91fbdd5bca902601e16c0e0db9384cbd2554","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-04 13:21:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-project-config-compare-xml http://logs.openstack.org/55/336955/2/check/gate-project-config-compare-xml/75df533/ : Jenkins XML output has changed. in 10m 07s (non-voting)\n- gate-project-config-layout http://logs.openstack.org/55/336955/2/check/gate-project-config-layout/5b97732/ : SUCCESS in 6m 24s\n- gate-project-config-jenkins-project http://logs.openstack.org/55/336955/2/check/gate-project-config-jenkins-project/c674bb8/ : SUCCESS in 1m 21s","accounts_in_message":[],"_revision_number":2},{"id":"ac49ecee6fe64142108fe276311a06475d3fd24f","author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"date":"2016-07-05 18:32:19.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"a992e47dbb072616f74052c239d032f5b5840f60","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2016-07-13 08:12:07.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"fea58e95f867e9a0ea21fdb0d6ce30a81ee8dd27","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2016-07-13 08:15:37.000000000","message":"Patch Set 2: -Code-Review\n\n1 question- It will again start failing as libvirt has it disabled by default right?","accounts_in_message":[],"_revision_number":2},{"id":"05599bc3a0c25708d85872df76e2b862a15dd6ea","author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"date":"2016-07-13 09:07:44.000000000","message":"Patch Set 2:\n\nAlso not sure how tests were passing as file injection is disabled on nova side.","accounts_in_message":[],"_revision_number":2},{"id":"2c18808d97f45cd216f177d28ba036ad43931818","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-07-14 01:30:23.000000000","message":"Patch Set 2:\n\ngmann, there is a dependency on a devstack change that will configure nova and tempest to make file injection, and the test, work.\n\nThe test wasn\u0027t passing, but it was in the neutron full ssh non-voting job, so no one really noticed it was failing since it was non-voting.","accounts_in_message":[],"_revision_number":2},{"id":"e7804371c6a9819617d06eb8f03a1ceb34f9baa5","author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"date":"2016-08-09 19:45:11.000000000","message":"Patch Set 2: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"aba551aaadaa64d00da2cb431661f9b388863df6","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2016-08-09 20:15:31.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nas discussed in the devstack change, this was failing but not noticed.  with neutron sign-off, and the devstack bits in, this LGTM","accounts_in_message":[],"_revision_number":2},{"id":"3abde1013035ebcf4514fb0ccec83395c461d8fc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-09 20:15:47.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"d3916a54f9ed7ba74628dcb8d2de2378ef85a798","date":"2016-08-09 20:27:29.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"ce59797cdf90f63d9db489e9fb18b5dd453c0148","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-09 20:27:29.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-project-config-layout http://logs.openstack.org/55/336955/2/gate/gate-project-config-layout/d3bb2e5/ : SUCCESS in 9m 48s\n- gate-project-config-jenkins-project http://logs.openstack.org/55/336955/2/gate/gate-project-config-jenkins-project/0cf988d/ : SUCCESS in 2m 04s","accounts_in_message":[],"_revision_number":2},{"id":"4ec9feeb2cdf3797609cdc4cd5922db579e1df5c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2016-08-12 02:46:21.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"4b9af66e95b7dc099c12fb68e3479ddb9d800526","revisions":{"063ffbe16e672f8552ccb6d7f40b452acafd69ff":{"kind":"REWORK","_number":1,"created":"2016-07-03 23:48:29.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/55/336955/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/55/336955/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/55/336955/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/55/336955/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/55/336955/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/55/336955/1"}}},"commit":{"parents":[{"commit":"f269e732f0c79d228e3b1d37bd86623d76a256b6","subject":"Merge \"Publish docs for opesntack-salt\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/f269e732f0c79d228e3b1d37bd86623d76a256b6"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-07-03 23:45:48.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-07-03 23:45:48.000000000","tz":-240},"subject":"Enable file injection in neutron full ssh job","message":"Enable file injection in neutron full ssh job\n\nThis was previously enabled in tempest but was broken\nby default since the libvirt driver disables file\ninjection by default, so this job fails because it\nssh\u0027s into the guest to verify the injected files exist,\nwhich they wouldn\u0027t by default.\n\nNova is being fixed to fail a server create request if\nit can\u0027t inject files, and devstack is being updated to\nconfigure the stack to test this properly.\n\nRelated-Bug: #1598581\n\nChange-Id: I51ed3bca4e27e82d75c063a7c2a6412174216d14\nDepends-On: I34790fadeffd6e3fdc65bd9feed3d6e62316896c\nDepends-On: Ieb0f64847e31622bd86d1c5f4672c37b3a89f197\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/063ffbe16e672f8552ccb6d7f40b452acafd69ff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/063ffbe16e672f8552ccb6d7f40b452acafd69ff"}]},"branch":"refs/heads/master"},"4b9af66e95b7dc099c12fb68e3479ddb9d800526":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-07-04 13:09:02.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/55/336955/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/project-config","ref":"refs/changes/55/336955/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/project-config refs/changes/55/336955/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/project-config refs/changes/55/336955/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/project-config refs/changes/55/336955/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/project-config refs/changes/55/336955/2"}}},"commit":{"parents":[{"commit":"f269e732f0c79d228e3b1d37bd86623d76a256b6","subject":"Merge \"Publish docs for opesntack-salt\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/f269e732f0c79d228e3b1d37bd86623d76a256b6"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-07-03 23:45:48.000000000","tz":-240},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2016-07-04 13:08:53.000000000","tz":-240},"subject":"Enable file injection in neutron full ssh job","message":"Enable file injection in neutron full ssh job\n\nThis was previously enabled in tempest but was broken\nby default since the libvirt driver disables file\ninjection by default, so this job fails because it\nssh\u0027s into the guest to verify the injected files exist,\nwhich they wouldn\u0027t by default.\n\nNova is being fixed to fail a server create request if\nit can\u0027t inject files, and devstack is being updated to\nconfigure the stack to test this properly.\n\nRelated-Bug: #1598581\n\nChange-Id: I51ed3bca4e27e82d75c063a7c2a6412174216d14\nDepends-On: I34790fadeffd6e3fdc65bd9feed3d6e62316896c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4b9af66e95b7dc099c12fb68e3479ddb9d800526"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/project-config/commit/4b9af66e95b7dc099c12fb68e3479ddb9d800526"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}