)]}'
{"jenkins/jobs/macros.yaml":[{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"27b97d916a3e91d1b531d0b790334b107d107243","unresolved":false,"context_lines":[{"line_number":223,"context_line":"      - shell: \"/usr/local/jenkins/slave_scripts/run-pylint.sh {env}\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"- builder:"},{"line_number":226,"context_line":"    name: npm-install"},{"line_number":227,"context_line":"    builders:"},{"line_number":228,"context_line":"      - shell: |"},{"line_number":229,"context_line":"          # Prerequisites"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_bd7cd4b5","line":226,"updated":"2016-07-06 19:35:54.000000000","message":"If you\u0027ll take a look at the npm-run macro (from javascript.yml), you\u0027ll see that it\u0027s usually invoked like this:\n\n      - npm-run:\n          command: \u0027{command}\u0027\n\nWithin the npm-run macro, this is then used in the line \"npm {command}\". For this patch, I\u0027d like to see something like this:\n\n      - npm-install:\n          version: \u0027{version}\u0027\n\nWhich would then be accessible in the shell script like this:\n\n     echo \u0027deb https://deb.nodesource.com/{version} trusty main\u0027\n\nYou\u0027d have to add some default value detection though, which I\u0027m not certain how to do in jjb layouts.","commit_id":"a1306b217b01da5fc604d95924951fbd662eb501"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"1c0afb9098fcc447f48e53f63f9a4afb75fb5473","unresolved":false,"context_lines":[{"line_number":223,"context_line":"      - shell: \"/usr/local/jenkins/slave_scripts/run-pylint.sh {env}\""},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"- builder:"},{"line_number":226,"context_line":"    name: npm-install"},{"line_number":227,"context_line":"    builders:"},{"line_number":228,"context_line":"      - shell: |"},{"line_number":229,"context_line":"          # Prerequisites"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_3e6dde99","line":226,"in_reply_to":"1aa78d24_bd7cd4b5","updated":"2016-07-10 20:48:44.000000000","message":"Add a solution about it, i am not sure if it is a good solution, but from my test it works, please to review it.","commit_id":"a1306b217b01da5fc604d95924951fbd662eb501"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"be6928ae7b5fe6f8a07c773351532f46a8fca115","unresolved":false,"context_lines":[{"line_number":231,"context_line":"          sudo apt-get update"},{"line_number":232,"context_line":"          sudo apt-get install -y apt-transport-https lsb-release curl"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"          DISTRO\u003d$(lsb_release -c -s)"},{"line_number":235,"context_line":"          VERSION\u003d{version}"},{"line_number":236,"context_line":"          if [[ $VERSION !\u003d \u00276\u0027 ]]; then"},{"line_number":237,"context_line":"          \tVERSION\u003d4"},{"line_number":238,"context_line":"          fi"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_edd3aad3","line":235,"range":{"start_line":234,"start_character":18,"end_line":235,"end_character":27},"updated":"2016-07-11 05:19:01.000000000","message":"You need to set version everytime the build is used.","commit_id":"58c98c9d78ef552a20726b39243eb0ed13e0c9ea"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"31e1e680a1364155692a8bb551554246d121c84a","unresolved":false,"context_lines":[{"line_number":231,"context_line":"          sudo apt-get update"},{"line_number":232,"context_line":"          sudo apt-get install -y apt-transport-https lsb-release curl"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"          DISTRO\u003d$(lsb_release -c -s)"},{"line_number":235,"context_line":"          VERSION\u003d{version}"},{"line_number":236,"context_line":"          if [[ $VERSION !\u003d \u00276\u0027 ]]; then"},{"line_number":237,"context_line":"          \tVERSION\u003d4"},{"line_number":238,"context_line":"          fi"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_a68257fe","line":235,"range":{"start_line":234,"start_character":18,"end_line":235,"end_character":27},"in_reply_to":"1aa78d24_edd3aad3","updated":"2016-07-11 11:07:29.000000000","message":"I thought if not pass any parameter to the macro, the parameter-templates ({version}) will be left as output, and only set the parameter version: 6 it will install nodejs 6, all others will install nodejs 4, so don\u0027t need to set version if you want to install nodejs 4","commit_id":"58c98c9d78ef552a20726b39243eb0ed13e0c9ea"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"be6928ae7b5fe6f8a07c773351532f46a8fca115","unresolved":false,"context_lines":[{"line_number":234,"context_line":"          DISTRO\u003d$(lsb_release -c -s)"},{"line_number":235,"context_line":"          VERSION\u003d{version}"},{"line_number":236,"context_line":"          if [[ $VERSION !\u003d \u00276\u0027 ]]; then"},{"line_number":237,"context_line":"          \tVERSION\u003d4"},{"line_number":238,"context_line":"          fi"},{"line_number":239,"context_line":"          # Install via nodesource"},{"line_number":240,"context_line":"          curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add -"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_adc9a227","line":237,"range":{"start_line":237,"start_character":10,"end_line":237,"end_character":11},"updated":"2016-07-11 05:19:01.000000000","message":"no tabs, please","commit_id":"58c98c9d78ef552a20726b39243eb0ed13e0c9ea"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"31e1e680a1364155692a8bb551554246d121c84a","unresolved":false,"context_lines":[{"line_number":234,"context_line":"          DISTRO\u003d$(lsb_release -c -s)"},{"line_number":235,"context_line":"          VERSION\u003d{version}"},{"line_number":236,"context_line":"          if [[ $VERSION !\u003d \u00276\u0027 ]]; then"},{"line_number":237,"context_line":"          \tVERSION\u003d4"},{"line_number":238,"context_line":"          fi"},{"line_number":239,"context_line":"          # Install via nodesource"},{"line_number":240,"context_line":"          curl -s https://deb.nodesource.com/gpgkey/nodesource.gpg.key | sudo apt-key add -"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"1aa78d24_c69e8353","line":237,"range":{"start_line":237,"start_character":10,"end_line":237,"end_character":11},"in_reply_to":"1aa78d24_adc9a227","updated":"2016-07-11 11:07:29.000000000","message":"sorry, typo, will fix in next patch","commit_id":"58c98c9d78ef552a20726b39243eb0ed13e0c9ea"}]}