)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"24ed0c3e892023fb6e69c1caa4648ac040d68046","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use ovs-interface-undefault instead of ovs-native job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently of_interface and ovsdb_interface have \u0027native\u0027 by default."},{"line_number":10,"context_line":"So ovs-native jobs are unnecessary. But a test case with undefault ovs-interface"},{"line_number":11,"context_line":"still needs to be checked."},{"line_number":12,"context_line":"This allows to run the test case with undefault ovs-interface."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1aa78d24_bbcd81b9","line":10,"updated":"2016-07-14 15:24:46.000000000","message":"undefault is not a word. What are you trying to do?\n\nIn master we switched to native interfaces, these are the ones we care about going forward. In stable we test against rootwrap-based interfaces and we have native interfaces that can be tested on demand. \n\nNow there is a chance we may break the non native interfaces in master, but that\u0027s not how we\u0027re gonna ship.","commit_id":"75d7c7c25446ac7f23227b800327750bd154e694"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"ee94e0f5bbce37e26a450d7bc92c57899360cde2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Use ovs-interface-undefault instead of ovs-native job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently of_interface and ovsdb_interface have \u0027native\u0027 by default."},{"line_number":10,"context_line":"So ovs-native jobs are unnecessary. But a test case with undefault ovs-interface"},{"line_number":11,"context_line":"still needs to be checked."},{"line_number":12,"context_line":"This allows to run the test case with undefault ovs-interface."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"1aa78d24_18459f14","line":10,"in_reply_to":"1aa78d24_bbcd81b9","updated":"2016-07-15 03:35:31.000000000","message":"Yes, I used \u0027undefault\u0027 is coined word because I could not find suitable words.\nI meant a value of configuration option which is not a default by \u0027undefault\u0027\nIn the case of of_interface option, when it is defined by default\u003d\u0027native\u0027, \u0027undefault\u0027 means \u0027ovs-ofctl\u0027.\n\nThis change allows job to do the following:\n- Check a default value of configuration options for of_interface and ovsdb_interface\n  in a neutron tree expanded on ci host.\n- run tests using options with value which is not default.\n  for example if of_interface option has \u0027native\u0027 by default, it will run tests with of_interface\u003d\u0027ovs-ofctl\u0027.\n  if of_interface option has \u0027ovs-ofctl\u0027 by default, it will run tests with of_interface\u003d\u0027native\u0027 as well.\n\nSo I think this will work in both master and stable well.\n(run tests with non native for master and native for stable)","commit_id":"75d7c7c25446ac7f23227b800327750bd154e694"}],"jenkins/jobs/devstack-gate.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"e3b3bff19b8a1c4e1f15eb44de1c768718ed167a","unresolved":false,"context_lines":[{"line_number":3325,"context_line":"    jobs:"},{"line_number":3326,"context_line":"      - \u0027{pipeline}-tempest-dsvm-all{job-suffix}\u0027"},{"line_number":3327,"context_line":"      - \u0027{pipeline}-tempest-dsvm-full-test-accounts{job-suffix}\u0027"},{"line_number":3328,"context_line":"      - \u0027{pipeline}-tempest-dsvm-neutron-dvr-ovs-interface-undefault{job-suffix}\u0027"},{"line_number":3329,"context_line":"      - \u0027{pipeline}-tempest-dsvm-neutron-full-non-admin{job-suffix}\u0027"},{"line_number":3330,"context_line":"      - \u0027{pipeline}-tempest-dsvm-neutron-full-test-accounts{job-suffix}\u0027"},{"line_number":3331,"context_line":"      - \u0027{pipeline}-tempest-dsvm-neutron-identity-v3-only-full{job-suffix}\u0027"},{"line_number":3332,"context_line":"      - \u0027{pipeline}-tempest-dsvm-neutron-ovs-interface-undefault{job-suffix}\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_3d59ad8f","line":3329,"range":{"start_line":3328,"start_character":7,"end_line":3329,"end_character":68},"updated":"2016-07-08 06:41:49.000000000","message":"remove the entries from these job-groups, variable expansion will not work when using them.\n\nJust add the jobs - with proper values - to your project in projects.yaml.","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"12bf27ac8e5f2e6225ff7347290c5ef341df3b64","unresolved":false,"context_lines":[{"line_number":3325,"context_line":"    jobs:"},{"line_number":3326,"context_line":"      - \u0027{pipeline}-tempest-dsvm-all{job-suffix}\u0027"},{"line_number":3327,"context_line":"      - \u0027{pipeline}-tempest-dsvm-full-test-accounts{job-suffix}\u0027"},{"line_number":3328,"context_line":"      - \u0027{pipeline}-tempest-dsvm-neutron-dvr-ovs-interface-undefault{job-suffix}\u0027"},{"line_number":3329,"context_line":"      - \u0027{pipeline}-tempest-dsvm-neutron-full-non-admin{job-suffix}\u0027"},{"line_number":3330,"context_line":"      - \u0027{pipeline}-tempest-dsvm-neutron-full-test-accounts{job-suffix}\u0027"},{"line_number":3331,"context_line":"      - \u0027{pipeline}-tempest-dsvm-neutron-identity-v3-only-full{job-suffix}\u0027"},{"line_number":3332,"context_line":"      - \u0027{pipeline}-tempest-dsvm-neutron-ovs-interface-undefault{job-suffix}\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_328c2a35","line":3329,"range":{"start_line":3328,"start_character":7,"end_line":3329,"end_character":68},"in_reply_to":"1aa78d24_3d59ad8f","updated":"2016-07-08 13:53:47.000000000","message":"OK, I will do it.","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"}],"jenkins/jobs/neutron.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"04ef6e5273e21a084b57666da54c29f83f40fd1b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          # Add configrations for ovs native interface in local.conf"},{"line_number":117,"context_line":"          local def_of_interface"},{"line_number":118,"context_line":"          local def_ovsdb_interface"},{"line_number":119,"context_line":"          curl -fsS http://git.openstack.org/cgit/openstack/neutron/plain/neutron/plugins/ml2/drivers/openvswitch/agent/common/config.py | grep \"\u0027of_interface\u0027\" | grep \"default\u003d\u0027ovs-ofctl\u0027\" 1\u003e /dev/null"},{"line_number":120,"context_line":"          if [ $? -eq 0 ]; then"},{"line_number":121,"context_line":"              def_of_interface\u003d\u0027native\u0027"},{"line_number":122,"context_line":"          else"},{"line_number":123,"context_line":"              def_of_interface\u003d\u0027ovs-ofctl\u0027"},{"line_number":124,"context_line":"          fi"},{"line_number":125,"context_line":"          curl -fsS http://git.openstack.org/cgit/openstack/neutron/plain/neutron/agent/ovsdb/api.py | grep -A2 \"\u0027ovsdb_interface\u0027\" | grep \"default\u003d\u0027vsctl\u0027\" 1\u003e /dev/null"},{"line_number":126,"context_line":"          if [ $? -eq 0 ]; then"},{"line_number":127,"context_line":"              def_ovsdb_interface\u003d\u0027native\u0027"},{"line_number":128,"context_line":"          else"},{"line_number":129,"context_line":"              def_ovsdb_interface\u003d\u0027vsctl\u0027"},{"line_number":130,"context_line":"          fi"},{"line_number":131,"context_line":"          function pre_test_hook {{"},{"line_number":132,"context_line":"              local localconf\u003d$BASE/new/devstack/local.conf"},{"line_number":133,"context_line":"              echo \"[[post-config|/\\$Q_PLUGIN_CONF_FILE]]\" \u003e\u003e $localconf"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1aa78d24_1d07bf82","line":130,"range":{"start_line":119,"start_character":10,"end_line":130,"end_character":12},"updated":"2016-07-07 13:03:23.000000000","message":"This is far too fragile, please find a better solution.\n\nYou should not need to use curl here.","commit_id":"f645076ff57339a0fc42e7f173684622a0bd431b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"e3b3bff19b8a1c4e1f15eb44de1c768718ed167a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          # Add configrations for ovs native interface in local.conf"},{"line_number":117,"context_line":"          function pre_test_hook {{"},{"line_number":118,"context_line":"              local localconf\u003d$BASE/new/devstack/local.conf"},{"line_number":119,"context_line":"              local of_interface_val\u003d{of-interface}"},{"line_number":120,"context_line":"              local ovsdb_interface_val\u003d{ovsdb-interface}"},{"line_number":121,"context_line":"              echo \"[[post-config|/\\$Q_PLUGIN_CONF_FILE]]\" \u003e\u003e $localconf"},{"line_number":122,"context_line":"              echo \"[ovs]\" \u003e\u003e $localconf"},{"line_number":123,"context_line":"              echo \"of_interface\u003d$of_interface_val\" \u003e\u003e $localconf"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_fd5e0578","line":120,"range":{"start_line":119,"start_character":10,"end_line":120,"end_character":57},"updated":"2016-07-08 06:41:49.000000000","message":"you have now variables here, so the usual devstack approach will not work","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"cdd5093ed4d38d39bf0cbe152a7f646021180433","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          # Add configrations for ovs native interface in local.conf"},{"line_number":117,"context_line":"          function pre_test_hook {{"},{"line_number":118,"context_line":"              local localconf\u003d$BASE/new/devstack/local.conf"},{"line_number":119,"context_line":"              local of_interface_val\u003d{of-interface}"},{"line_number":120,"context_line":"              local ovsdb_interface_val\u003d{ovsdb-interface}"},{"line_number":121,"context_line":"              echo \"[[post-config|/\\$Q_PLUGIN_CONF_FILE]]\" \u003e\u003e $localconf"},{"line_number":122,"context_line":"              echo \"[ovs]\" \u003e\u003e $localconf"},{"line_number":123,"context_line":"              echo \"of_interface\u003d$of_interface_val\" \u003e\u003e $localconf"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_a250a3d5","line":120,"range":{"start_line":119,"start_character":10,"end_line":120,"end_character":57},"in_reply_to":"1aa78d24_8f13105c","updated":"2016-07-09 10:01:52.000000000","message":"Ah ok, I understood your explanation now.","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4e64518ebdc207e91f876464623f1c48e721c814","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          # Add configrations for ovs native interface in local.conf"},{"line_number":117,"context_line":"          function pre_test_hook {{"},{"line_number":118,"context_line":"              local localconf\u003d$BASE/new/devstack/local.conf"},{"line_number":119,"context_line":"              local of_interface_val\u003d{of-interface}"},{"line_number":120,"context_line":"              local ovsdb_interface_val\u003d{ovsdb-interface}"},{"line_number":121,"context_line":"              echo \"[[post-config|/\\$Q_PLUGIN_CONF_FILE]]\" \u003e\u003e $localconf"},{"line_number":122,"context_line":"              echo \"[ovs]\" \u003e\u003e $localconf"},{"line_number":123,"context_line":"              echo \"of_interface\u003d$of_interface_val\" \u003e\u003e $localconf"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_8f13105c","line":120,"range":{"start_line":119,"start_character":10,"end_line":120,"end_character":57},"in_reply_to":"1aa78d24_9e9ec505","updated":"2016-07-09 07:43:24.000000000","message":"Variables are replaced. What I meant was: Don\u0027t add this to the devstack job-groups. The template itself will work. See my comments elsewhere as well","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"42f307a8ac1c8ff6eeb025caba1ac3d058946fe5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          # Add configrations for ovs native interface in local.conf"},{"line_number":117,"context_line":"          function pre_test_hook {{"},{"line_number":118,"context_line":"              local localconf\u003d$BASE/new/devstack/local.conf"},{"line_number":119,"context_line":"              local of_interface_val\u003d{of-interface}"},{"line_number":120,"context_line":"              local ovsdb_interface_val\u003d{ovsdb-interface}"},{"line_number":121,"context_line":"              echo \"[[post-config|/\\$Q_PLUGIN_CONF_FILE]]\" \u003e\u003e $localconf"},{"line_number":122,"context_line":"              echo \"[ovs]\" \u003e\u003e $localconf"},{"line_number":123,"context_line":"              echo \"of_interface\u003d$of_interface_val\" \u003e\u003e $localconf"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_7d893fca","line":120,"range":{"start_line":119,"start_character":10,"end_line":120,"end_character":57},"in_reply_to":"1aa78d24_9e9ec505","updated":"2016-07-09 04:17:36.000000000","message":"We can see the expanded neutron tree here. How about to grep for expanded config.py and api.py file instead of using curl?","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"12bf27ac8e5f2e6225ff7347290c5ef341df3b64","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          # Add configrations for ovs native interface in local.conf"},{"line_number":117,"context_line":"          function pre_test_hook {{"},{"line_number":118,"context_line":"              local localconf\u003d$BASE/new/devstack/local.conf"},{"line_number":119,"context_line":"              local of_interface_val\u003d{of-interface}"},{"line_number":120,"context_line":"              local ovsdb_interface_val\u003d{ovsdb-interface}"},{"line_number":121,"context_line":"              echo \"[[post-config|/\\$Q_PLUGIN_CONF_FILE]]\" \u003e\u003e $localconf"},{"line_number":122,"context_line":"              echo \"[ovs]\" \u003e\u003e $localconf"},{"line_number":123,"context_line":"              echo \"of_interface\u003d$of_interface_val\" \u003e\u003e $localconf"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_9e9ec505","line":120,"range":{"start_line":119,"start_character":10,"end_line":120,"end_character":57},"in_reply_to":"1aa78d24_fd5e0578","updated":"2016-07-08 13:53:47.000000000","message":"Hmm, the following job uses it.\n\nhttps://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/neutron-lbaas.yaml#n32\n\nIs the variables not replaced with specified value, when a job is executed ?\nIf this does not work, I may set \u0027ovs-ofctl\u0027 and \u0027vsctl\u0027  to local.conf directly.","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ef4eb36b553919838873d3ea465613d404433504","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                  [ -n \"$line\" ]"},{"line_number":136,"context_line":"              }}"},{"line_number":137,"context_line":"              # Check if default is native when of_interface has a default value."},{"line_number":138,"context_line":"              if [ -f ofif_conf_file ]; then"},{"line_number":139,"context_line":"                  if _check_default $ofif_conf_file of_interface; then"},{"line_number":140,"context_line":"                      if _check_default $ofif_conf_file of_interface native; then"},{"line_number":141,"context_line":"                          of_interface_val\u003d\u0027ovs-ofctl\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_0d8396cd","line":138,"range":{"start_line":138,"start_character":22,"end_line":138,"end_character":36},"updated":"2016-07-11 05:16:27.000000000","message":"$ofif...","commit_id":"a613d51ab7a672c1742b5fb7bcc6170f83032796"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"afee7667ab51835f76a9c03d7bdbf71975764417","unresolved":false,"context_lines":[{"line_number":135,"context_line":"                  [ -n \"$line\" ]"},{"line_number":136,"context_line":"              }}"},{"line_number":137,"context_line":"              # Check if default is native when of_interface has a default value."},{"line_number":138,"context_line":"              if [ -f ofif_conf_file ]; then"},{"line_number":139,"context_line":"                  if _check_default $ofif_conf_file of_interface; then"},{"line_number":140,"context_line":"                      if _check_default $ofif_conf_file of_interface native; then"},{"line_number":141,"context_line":"                          of_interface_val\u003d\u0027ovs-ofctl\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_e85a78f1","line":138,"range":{"start_line":138,"start_character":22,"end_line":138,"end_character":36},"in_reply_to":"1aa78d24_0d8396cd","updated":"2016-07-11 05:59:49.000000000","message":"Done","commit_id":"a613d51ab7a672c1742b5fb7bcc6170f83032796"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ef4eb36b553919838873d3ea465613d404433504","unresolved":false,"context_lines":[{"line_number":136,"context_line":"              }}"},{"line_number":137,"context_line":"              # Check if default is native when of_interface has a default value."},{"line_number":138,"context_line":"              if [ -f ofif_conf_file ]; then"},{"line_number":139,"context_line":"                  if _check_default $ofif_conf_file of_interface; then"},{"line_number":140,"context_line":"                      if _check_default $ofif_conf_file of_interface native; then"},{"line_number":141,"context_line":"                          of_interface_val\u003d\u0027ovs-ofctl\u0027"},{"line_number":142,"context_line":"                      else"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_2d681221","line":139,"range":{"start_line":139,"start_character":52,"end_line":139,"end_character":64},"updated":"2016-07-11 05:16:27.000000000","message":"$of_interface","commit_id":"a613d51ab7a672c1742b5fb7bcc6170f83032796"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"afee7667ab51835f76a9c03d7bdbf71975764417","unresolved":false,"context_lines":[{"line_number":136,"context_line":"              }}"},{"line_number":137,"context_line":"              # Check if default is native when of_interface has a default value."},{"line_number":138,"context_line":"              if [ -f ofif_conf_file ]; then"},{"line_number":139,"context_line":"                  if _check_default $ofif_conf_file of_interface; then"},{"line_number":140,"context_line":"                      if _check_default $ofif_conf_file of_interface native; then"},{"line_number":141,"context_line":"                          of_interface_val\u003d\u0027ovs-ofctl\u0027"},{"line_number":142,"context_line":"                      else"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_e811d805","line":139,"range":{"start_line":139,"start_character":52,"end_line":139,"end_character":64},"in_reply_to":"1aa78d24_2d681221","updated":"2016-07-11 05:59:49.000000000","message":"This is constant string which specify option name.","commit_id":"a613d51ab7a672c1742b5fb7bcc6170f83032796"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ef4eb36b553919838873d3ea465613d404433504","unresolved":false,"context_lines":[{"line_number":137,"context_line":"              # Check if default is native when of_interface has a default value."},{"line_number":138,"context_line":"              if [ -f ofif_conf_file ]; then"},{"line_number":139,"context_line":"                  if _check_default $ofif_conf_file of_interface; then"},{"line_number":140,"context_line":"                      if _check_default $ofif_conf_file of_interface native; then"},{"line_number":141,"context_line":"                          of_interface_val\u003d\u0027ovs-ofctl\u0027"},{"line_number":142,"context_line":"                      else"},{"line_number":143,"context_line":"                          of_interface_val\u003d\u0027native\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_8d778601","line":140,"range":{"start_line":140,"start_character":55,"end_line":140,"end_character":67},"updated":"2016-07-11 05:16:27.000000000","message":"$of...","commit_id":"a613d51ab7a672c1742b5fb7bcc6170f83032796"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"afee7667ab51835f76a9c03d7bdbf71975764417","unresolved":false,"context_lines":[{"line_number":137,"context_line":"              # Check if default is native when of_interface has a default value."},{"line_number":138,"context_line":"              if [ -f ofif_conf_file ]; then"},{"line_number":139,"context_line":"                  if _check_default $ofif_conf_file of_interface; then"},{"line_number":140,"context_line":"                      if _check_default $ofif_conf_file of_interface native; then"},{"line_number":141,"context_line":"                          of_interface_val\u003d\u0027ovs-ofctl\u0027"},{"line_number":142,"context_line":"                      else"},{"line_number":143,"context_line":"                          of_interface_val\u003d\u0027native\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_28f480cd","line":140,"range":{"start_line":140,"start_character":55,"end_line":140,"end_character":67},"in_reply_to":"1aa78d24_8d778601","updated":"2016-07-11 05:59:49.000000000","message":"This is constant string which specify option name.","commit_id":"a613d51ab7a672c1742b5fb7bcc6170f83032796"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"ef4eb36b553919838873d3ea465613d404433504","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                  fi"},{"line_number":146,"context_line":"              fi"},{"line_number":147,"context_line":"              # Check if default is native when ovsdb_interface has a default value."},{"line_number":148,"context_line":"              if [ -f ovsdbif_conf_file ]; then"},{"line_number":149,"context_line":"                  if _check_default $ovsdbif_conf_file ovsdb_interface; then"},{"line_number":150,"context_line":"                      if _check_default $ovsdbif_conf_file ovsdb_interface native; then"},{"line_number":151,"context_line":"                          ovsdb_interface_val\u003d\u0027vsctl\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_cd5fce73","line":148,"range":{"start_line":148,"start_character":22,"end_line":148,"end_character":39},"updated":"2016-07-11 05:16:27.000000000","message":"more missing $ here and below","commit_id":"a613d51ab7a672c1742b5fb7bcc6170f83032796"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"afee7667ab51835f76a9c03d7bdbf71975764417","unresolved":false,"context_lines":[{"line_number":145,"context_line":"                  fi"},{"line_number":146,"context_line":"              fi"},{"line_number":147,"context_line":"              # Check if default is native when ovsdb_interface has a default value."},{"line_number":148,"context_line":"              if [ -f ovsdbif_conf_file ]; then"},{"line_number":149,"context_line":"                  if _check_default $ovsdbif_conf_file ovsdb_interface; then"},{"line_number":150,"context_line":"                      if _check_default $ovsdbif_conf_file ovsdb_interface native; then"},{"line_number":151,"context_line":"                          ovsdb_interface_val\u003d\u0027vsctl\u0027"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1aa78d24_4872ac7d","line":148,"range":{"start_line":148,"start_character":22,"end_line":148,"end_character":39},"in_reply_to":"1aa78d24_cd5fce73","updated":"2016-07-11 05:59:49.000000000","message":"Done","commit_id":"a613d51ab7a672c1742b5fb7bcc6170f83032796"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"24ed0c3e892023fb6e69c1caa4648ac040d68046","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# TODO(kakuma) This is because of checking test case which ovs interface"},{"line_number":113,"context_line":"# is configured by undefault value."},{"line_number":114,"context_line":"# This can be dropped when ovs interface was determined to one."},{"line_number":115,"context_line":"- job-template:"},{"line_number":116,"context_line":"    name: \u0027{pipeline}-tempest-dsvm-neutron-dvr-ovs-interface-undefault{job-suffix}\u0027"},{"line_number":117,"context_line":"    node: \u0027{node}\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1aa78d24_fb0ee930","line":114,"updated":"2016-07-14 15:24:46.000000000","message":"what does this mean exactly? I don\u0027t understand","commit_id":"75d7c7c25446ac7f23227b800327750bd154e694"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"ee94e0f5bbce37e26a450d7bc92c57899360cde2","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"# TODO(kakuma) This is because of checking test case which ovs interface"},{"line_number":113,"context_line":"# is configured by undefault value."},{"line_number":114,"context_line":"# This can be dropped when ovs interface was determined to one."},{"line_number":115,"context_line":"- job-template:"},{"line_number":116,"context_line":"    name: \u0027{pipeline}-tempest-dsvm-neutron-dvr-ovs-interface-undefault{job-suffix}\u0027"},{"line_number":117,"context_line":"    node: \u0027{node}\u0027"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"1aa78d24_18d75f50","line":114,"in_reply_to":"1aa78d24_fb0ee930","updated":"2016-07-15 03:35:31.000000000","message":"We have each 2 way to speake openflow and ovsdb interface but in the future one of two way[1] will be removed\nfrom bothersome work to maintain 2 way, superiority of the interface of either etc.\n(I believe that native interface will be left.)\nWhen all branch use one way, this job will become unnecessary.","commit_id":"75d7c7c25446ac7f23227b800327750bd154e694"}],"jenkins/jobs/projects.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"e3b3bff19b8a1c4e1f15eb44de1c768718ed167a","unresolved":false,"context_lines":[{"line_number":1452,"context_line":"          node: ubuntu-trusty"},{"line_number":1453,"context_line":"          job-suffix: \u0027\u0027"},{"line_number":1454,"context_line":"          branch-override: default"},{"line_number":1455,"context_line":"          of-interface: \u0027ovs-ofctl\u0027"},{"line_number":1456,"context_line":"          ovsdb-interface: \u0027vsctl\u0027"},{"line_number":1457,"context_line":"      # Experimental jobs for ubuntu-xenial"},{"line_number":1458,"context_line":"      - devstack-jobs:"},{"line_number":1459,"context_line":"          pipeline: experimental"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_bd4d9dc6","line":1456,"range":{"start_line":1455,"start_character":2,"end_line":1456,"end_character":34},"updated":"2016-07-08 06:41:49.000000000","message":"This would work but would apply to other jobs as well. Instead move your jobs out of devstack-jobs.","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"12bf27ac8e5f2e6225ff7347290c5ef341df3b64","unresolved":false,"context_lines":[{"line_number":1452,"context_line":"          node: ubuntu-trusty"},{"line_number":1453,"context_line":"          job-suffix: \u0027\u0027"},{"line_number":1454,"context_line":"          branch-override: default"},{"line_number":1455,"context_line":"          of-interface: \u0027ovs-ofctl\u0027"},{"line_number":1456,"context_line":"          ovsdb-interface: \u0027vsctl\u0027"},{"line_number":1457,"context_line":"      # Experimental jobs for ubuntu-xenial"},{"line_number":1458,"context_line":"      - devstack-jobs:"},{"line_number":1459,"context_line":"          pipeline: experimental"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_f2ee22b3","line":1456,"range":{"start_line":1455,"start_character":2,"end_line":1456,"end_character":34},"in_reply_to":"1aa78d24_bd4d9dc6","updated":"2016-07-08 13:53:47.000000000","message":"OK, I will do it.","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"}],"zuul/layout.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"e3b3bff19b8a1c4e1f15eb44de1c768718ed167a","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"  - name: gate-tempest-dsvm-neutron-dvr-multinode-full"},{"line_number":1733,"context_line":"    voting: false"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"  - name: gate-tempest-dsvm-neutron-ovs-interface-undefault"},{"line_number":1736,"context_line":"    voting: false"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"  - name: gate-tempest-dsvm-neutron-dvr-ovs-interface-undefault"},{"line_number":1739,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_9d4a61ab","line":1736,"range":{"start_line":1735,"start_character":2,"end_line":1736,"end_character":17},"updated":"2016-07-08 06:41:49.000000000","message":"define them with job-suffix \"-nv\" and then you don\u0027t need these.\n\nBut for experimental jobs, no need to make them non-voting.","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"},{"author":{"_account_id":8344,"name":"fumihiko kakuma","email":"kakuma@valinux.co.jp","username":"kakuma"},"change_message_id":"12bf27ac8e5f2e6225ff7347290c5ef341df3b64","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"  - name: gate-tempest-dsvm-neutron-dvr-multinode-full"},{"line_number":1733,"context_line":"    voting: false"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"  - name: gate-tempest-dsvm-neutron-ovs-interface-undefault"},{"line_number":1736,"context_line":"    voting: false"},{"line_number":1737,"context_line":""},{"line_number":1738,"context_line":"  - name: gate-tempest-dsvm-neutron-dvr-ovs-interface-undefault"},{"line_number":1739,"context_line":"    voting: false"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1aa78d24_12200ef7","line":1736,"range":{"start_line":1735,"start_character":2,"end_line":1736,"end_character":17},"in_reply_to":"1aa78d24_9d4a61ab","updated":"2016-07-08 13:53:47.000000000","message":"OK, I will do it.","commit_id":"4601226160168e231d886cc848c00a2b17f62e82"}]}