)]}'
{"nodepool/scripts/configure_mirror.sh":[{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"42fd0860ad6f9926f3329cfec70ccb0eee4ea33d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"cat \u003c\u003c \"EOF\" \u003e\u003e /tmp/mirror_info.sh"},{"line_number":38,"context_line":"export NODEPOOL_DEBIAN_MIRROR\u003d${NODEPOOL_DEBIAN_MIRROR:-http://$NODEPOOL_MIRROR_HOST/debian}"},{"line_number":39,"context_line":"export NODEPOOL_PYPI_MIRROR\u003d${NODEPOOL_PYPI_MIRROR:-http://$NODEPOOL_MIRROR_HOST/pypi/simple}"},{"line_number":40,"context_line":"export NODEPOOL_WHEEL_MIRROR\u003d${NODEPOOL_WHEEL_MIRROR:-http://$NODEPOOL_MIRROR_HOST/wheel/$AFS_SLUG}"},{"line_number":41,"context_line":"export NODEPOOL_UBUNTU_MIRROR\u003d${NODEPOOL_UBUNTU_MIRROR:-http://$NODEPOOL_MIRROR_HOST/ubuntu}"},{"line_number":42,"context_line":"export NODEPOOL_CENTOS_MIRROR\u003d${NODEPOOL_CENTOS_MIRROR:-http://$NODEPOOL_MIRROR_HOST/centos}"},{"line_number":43,"context_line":"export NODEPOOL_DEBIAN_OPENSTACK_MIRROR\u003d${NODEPOOL_DEBIAN_OPENSTACK_MIRROR:-http://$NODEPOOL_MIRROR_HOST/debian-openstack}"}],"source_content_type":"text/x-sh","patch_set":2,"id":"bff0334d_196aaa7f","line":40,"updated":"2017-04-05 22:01:59.000000000","message":"Where does AFS_SLUG come from? afs-slug.sh? That will have to move up I think","commit_id":"2814f55391ea5ff30962b171cd39cfd8a56c7e2f"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"095617ab98f8e4dddf862667c14f31560e6a59d3","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# Copy AFS Slug generation details into mirror_info.sh so that consumers"},{"line_number":35,"context_line":"# don\u0027t have to know about generating the wheel mirror\u0027s"},{"line_number":36,"context_line":"# distro-release-processor tuple."},{"line_number":37,"context_line":"cat /usr/local/jenkins/slave_scripts/afs-slug.sh \u003e\u003e /tmp/mirror_info.sh"},{"line_number":38,"context_line":"# We write this as a heredoc so that the same information used by this script"},{"line_number":39,"context_line":"# is useable by others without double accounting. Note that the quoted EOF"},{"line_number":40,"context_line":"# means we don\u0027t do variable expansion."}],"source_content_type":"text/x-sh","patch_set":3,"id":"bff0334d_b95bbe85","line":37,"updated":"2017-04-05 22:15:49.000000000","message":"/tmp/mirror_info.sh looks a little malformed, line 1 is the export above, next line will be #!/bin/bash.","commit_id":"f00d777377b001d095400323df7e3ab2a5937cd8"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"7069f196f1520dcc8fa71e059c5d81a93880b956","unresolved":false,"context_lines":[{"line_number":34,"context_line":"# Copy AFS Slug generation details into mirror_info.sh so that consumers"},{"line_number":35,"context_line":"# don\u0027t have to know about generating the wheel mirror\u0027s"},{"line_number":36,"context_line":"# distro-release-processor tuple."},{"line_number":37,"context_line":"cat /usr/local/jenkins/slave_scripts/afs-slug.sh \u003e\u003e /tmp/mirror_info.sh"},{"line_number":38,"context_line":"# We write this as a heredoc so that the same information used by this script"},{"line_number":39,"context_line":"# is useable by others without double accounting. Note that the quoted EOF"},{"line_number":40,"context_line":"# means we don\u0027t do variable expansion."}],"source_content_type":"text/x-sh","patch_set":3,"id":"bff0334d_597392e8","line":37,"in_reply_to":"bff0334d_b95bbe85","updated":"2017-04-05 22:21:39.000000000","message":"Its only malformed if you expect this new script to be executable directly. We are setting it up to be sourced so I think its fine.\n\nThe other potential concern would be modifying an existing file to break its shebang but that isn\u0027t the case here either.","commit_id":"f00d777377b001d095400323df7e3ab2a5937cd8"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f76c237fc0b67c0be7af4c2a78df84b7ca93b606","unresolved":false,"context_lines":[{"line_number":48,"context_line":"export NODEPOOL_EPEL_MIRROR\u003d${NODEPOOL_EPEL_MIRROR:-http://$NODEPOOL_MIRROR_HOST/epel}"},{"line_number":49,"context_line":"export NODEPOOL_FEDORA_MIRROR\u003d${NODEPOOL_FEDORA_MIRROR:-http://$NODEPOOL_MIRROR_HOST/fedora}"},{"line_number":50,"context_line":"export NODEPOOL_CEPH_MIRROR\u003d${NODEPOOL_CEPH_MIRROR:-http://$NODEPOOL_MIRROR_HOST/ceph-deb-hammer}"},{"line_number":51,"context_line":"export NODEPOOL_UCA_MIRROR\u003d${NODEPOOL_UCA_MIRROR:-http://$NODEPOOL_MIRROR_HOST/ubuntu-cloud-archive}"},{"line_number":52,"context_line":"export NODEPOOL_MARIADB_MIRROR\u003d${NODEPOOL_MARIADB_MIRROR:-http://$NODEPOOL_MIRROR_HOST/ubuntu-mariadb}"},{"line_number":53,"context_line":"export NODEPOOL_NPM_MIRROR\u003d${NODEPOOL_NPM_MIRROR:-http://$NODEPOOL_MIRROR_HOST/npm/}"},{"line_number":54,"context_line":"EOF"}],"source_content_type":"text/x-sh","patch_set":3,"id":"bff0334d_624a1656","line":51,"updated":"2017-04-06 06:03:12.000000000","message":"Don\u0027t we have now an openSUSE mirror as well? Let\u0027s add that one...","commit_id":"f00d777377b001d095400323df7e3ab2a5937cd8"}]}