)]}'
{"jenkins/jobs/packaging-mirror.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"9afeda8b0b7388ad051f16adc94e9a0ee60a042d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"          BRANCH\u003d$(echo $ZUUL_REFNAME | cut -d/ -f2)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"          cd $AFS_DIR/dists/{codename}-$BRANCH"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"          gpg --armor --detach-sign --output Relase.gpg Release"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"- job-template:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"dada55a8_4b54ac53","line":55,"updated":"2016-07-18 05:49:46.000000000","message":"this doesn\u0027t need AFS authentication to write out the .gpg file?","commit_id":"07587526b5f78d662debb70711777617a3bf1db5"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"c530cc7ec13808ba1bc5ae82ef7b91794ba61ee3","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    name: reprepro-gpg-sign"},{"line_number":47,"context_line":"    builders:"},{"line_number":48,"context_line":"      - shell: |"},{"line_number":49,"context_line":"          #!/bin/bash -xe"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"          AFS_DIR\u003d/afs/.openstack.org/mirror/deb-openstack"},{"line_number":52,"context_line":"          BRANCH\u003d$(echo $ZUUL_REFNAME | cut -d/ -f2)"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_67b0a5de","line":49,"updated":"2016-07-18 16:38:06.000000000","message":"Please move this into a script file. Since it gets installed by puppet on the signing node, we don\u0027t have to worry about image update cycles to get changes for it into production.","commit_id":"acf31108bd38b66abeefb39ed66ec2157842d17c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"c530cc7ec13808ba1bc5ae82ef7b91794ba61ee3","unresolved":false,"context_lines":[{"line_number":56,"context_line":"          k5start -t -f /etc/packaging.keytab \\"},{"line_number":57,"context_line":"              service/packaging \\"},{"line_number":58,"context_line":"              -- timeout -k 2m 30m \\"},{"line_number":59,"context_line":"              gpg --armor --detach-sign --output Relase.gpg Release"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"- job-template:"},{"line_number":62,"context_line":"    name: reprepro-import-{reprepro}-{codename}"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_47b5a1cb","line":59,"updated":"2016-07-18 16:38:06.000000000","message":"This matches what I do for my personal deb repos (built with apt-ftparchive) and the secure-APT implementation in apt-get likes the result just fine.","commit_id":"acf31108bd38b66abeefb39ed66ec2157842d17c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"c530cc7ec13808ba1bc5ae82ef7b91794ba61ee3","unresolved":false,"context_lines":[{"line_number":79,"context_line":"      - console-log"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"- job-template:"},{"line_number":82,"context_line":"    name: reprepro-gpg-sign-{codename}"},{"line_number":83,"context_line":"    node: signing"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_a7ca9d4d","line":82,"updated":"2016-07-18 16:38:06.000000000","message":"Nit: I\u0027d suggest something a little more generic like reprepro-sign-{codename} (mentioning the tool used to sign it is a bit redundant/unnecessary).","commit_id":"acf31108bd38b66abeefb39ed66ec2157842d17c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"c530cc7ec13808ba1bc5ae82ef7b91794ba61ee3","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    wrappers:"},{"line_number":86,"context_line":"      - build-timeout:"},{"line_number":87,"context_line":"          timeout: 90"},{"line_number":88,"context_line":"      - timestamps"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    builders:"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_87c79944","line":87,"updated":"2016-07-18 16:38:06.000000000","message":"90 minutes is a massive timeout. I would expect the Release file to be signed in a matter of a few seconds at most. In fact, you\u0027re running the gpg call under a 150 _second_ timeout, so unless you expect 87.5 minutes of overhead this should probably just use the default build-timeout instead.","commit_id":"acf31108bd38b66abeefb39ed66ec2157842d17c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"c530cc7ec13808ba1bc5ae82ef7b91794ba61ee3","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    builders:"},{"line_number":91,"context_line":"      - revoke-sudo"},{"line_number":92,"context_line":"      - link-logs"},{"line_number":93,"context_line":"      - net-info"},{"line_number":94,"context_line":"      - reprepro-gpg-sign:"},{"line_number":95,"context_line":"          codename: \"{codename}\""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_e7c49541","line":93,"updated":"2016-07-18 16:38:06.000000000","message":"This builder is mostly irrelevant since the job always runs on the signing node, and we know about its network configuration. The primary use for net-info is so we preserve network diagnostic details for single-use nodes since we can\u0027t easily figure that out after nodepool deletes them.","commit_id":"acf31108bd38b66abeefb39ed66ec2157842d17c"}],"jenkins/scripts/reprepro-gpg-sign.sh":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"e0fc57da4f48f00eac01e2efdb5df33bb2f05e71","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"k5start -t -f /etc/packaging.keytab \\"},{"line_number":22,"context_line":"    service/packaging \\"},{"line_number":23,"context_line":"    -- timeout -k 2m 30m \\"},{"line_number":24,"context_line":"    gpg --armor --detach-sign --output Relase.gpg Release"}],"source_content_type":"text/x-sh","patch_set":4,"id":"dada55a8_53e8c210","line":23,"updated":"2016-07-18 18:12:41.000000000","message":"Sorry I misread this before. So you\u0027re timing out the gpg call after 30 minutes, and if it\u0027s still not stopped 2 minutes after that you use sigkill to forcibly terminate it. It looks like our default build-timeout is 30 minutes, so this should ideally be something shorter.","commit_id":"a88a908a77e52e418c6b516259385cb993850124"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"98b70ec542019e9555934039b2f0ff42f92acb43","unresolved":false,"context_lines":[{"line_number":21,"context_line":"k5start -t -f /etc/packaging.keytab \\"},{"line_number":22,"context_line":"    service/packaging \\"},{"line_number":23,"context_line":"    -- timeout -k 2m 5m \\"},{"line_number":24,"context_line":"    gpg --armor --detach-sign --output Release.gpg Release"}],"source_content_type":"text/x-sh","patch_set":9,"id":"bacf61ea_926623b9","line":24,"range":{"start_line":24,"start_character":15,"end_line":24,"end_character":16},"updated":"2016-08-05 13:31:46.000000000","message":"This is nice, but it\u0027d be even better if you could also do (not instead, really ALSO):\ngpg --armor --clearsign --output InRelease Release","commit_id":"4d139affb47c9178154ef296cdc3763a4ae46a19"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"0e7f8f5e57b2b8c4f20089d7f1e84e3769410f66","unresolved":false,"context_lines":[{"line_number":19,"context_line":"    service/packaging \\"},{"line_number":20,"context_line":"    -- timeout -k 2m 5m\""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"cd $AFS_DIR/dists/{codename}-$BRANCH"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"$K5START gpg --armor --detach-sign --output Release.gpg Release"},{"line_number":25,"context_line":"$K5START gpg --armor --clearsign --output InRelease Release"}],"source_content_type":"text/x-sh","patch_set":10,"id":"bacf61ea_202e028c","line":22,"range":{"start_line":22,"start_character":18,"end_line":22,"end_character":26},"updated":"2016-08-05 13:43:35.000000000","message":"this is a problem {codename} will fail","commit_id":"6a692c77d328440d87ed6380ab1b653b3d49a9c8"}]}