)]}'
{"jenkins/jobs/ansible-role-jobs.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"f4f24f488c8a4184311c8d2c5d7262117aed4d61","unresolved":false,"context_lines":[{"line_number":51,"context_line":"          fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"          function post_test_hook {{"},{"line_number":54,"context_line":"              $BASE/new/$(basename $ZUUL_PROJECT)/tests/hooks/post_test_hook.sh"},{"line_number":55,"context_line":"          }}"},{"line_number":56,"context_line":"          export -f post_test_hook"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_9913905c","line":54,"updated":"2016-07-18 11:56:07.000000000","message":"Normally we use the same post_test_hook everywhere, this makes it repo specific.","commit_id":"6a180d23408d16f973cc3b947d32ea9106dbe422"},{"author":{"_account_id":1106,"name":"Ricardo Carrillo Cruz","email":"ricardo.carrillo.cruz@gmail.com","username":"rcc"},"change_message_id":"eedf15112956086e4bbfc1a3bccb5b57ab8b2188","unresolved":false,"context_lines":[{"line_number":51,"context_line":"          fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"          function post_test_hook {{"},{"line_number":54,"context_line":"              $BASE/new/$(basename $ZUUL_PROJECT)/tests/hooks/post_test_hook.sh"},{"line_number":55,"context_line":"          }}"},{"line_number":56,"context_line":"          export -f post_test_hook"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_f9860c64","line":54,"in_reply_to":"dada55a8_9913905c","updated":"2016-07-18 12:00:38.000000000","message":"on the contrary, this is about making the post_test_hook generic so any ansible-role project can use it, the project just should have a tests/hooks/post_test_hook.\n\nNormally, the post-test-hook is project specific, e.g.:\n\nhttp://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/trove.yaml#n63\nhttp://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/zaqar.yaml#n34\n\ni.e. the project name is hardcoded in the post-test-hook function.\n\nAs this belongs to ansible-role-jobs, which is meant to be reused by multiple ansible role projects that\u0027s the reason why I opted to rely on ZUUL_PROJECT var.","commit_id":"6a180d23408d16f973cc3b947d32ea9106dbe422"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"6278461b75209e427c31799828166b807532a34b","unresolved":false,"context_lines":[{"line_number":51,"context_line":"          fi"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"          function post_test_hook {{"},{"line_number":54,"context_line":"              $BASE/new/${{ZUUL_PROJECT##*/}}/tests/hooks/post_test_hook.sh"},{"line_number":55,"context_line":"          }}"},{"line_number":56,"context_line":"          export -f post_test_hook"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"dada55a8_0f058ec1","line":54,"range":{"start_line":54,"start_character":24,"end_line":54,"end_character":45},"updated":"2016-07-18 12:48:16.000000000","message":"Why not use {name} here? That\u0027s the repo name you need...","commit_id":"8f942cc61bce4cc54a945d6e511824f71a29eda6"}]}
