)]}'
{"jenkins/jobs/macros.yaml":[{"author":{"_account_id":15168,"name":"Kirill Zaitsev","email":"k.zaitsev@me.com","username":"kzaitsev"},"change_message_id":"f7d6617b3e8482833fb337d6063697dfb5d2e808","unresolved":false,"context_lines":[{"line_number":879,"context_line":"          sudo apt-get install -y shellcheck"},{"line_number":880,"context_line":"          # Validate shell scripts, in each directory"},{"line_number":881,"context_line":"          for folder in {dir_list}; do"},{"line_number":882,"context_line":"              find \"$folder\" -name \u0027*.sh\u0027 -print0 | while read -d \u0027\u0027 -r script; do"},{"line_number":883,"context_line":"                  shellcheck \"$script\""},{"line_number":884,"context_line":"              done"},{"line_number":885,"context_line":"          done"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_f3398df3","line":884,"range":{"start_line":882,"start_character":14,"end_line":884,"end_character":18},"updated":"2016-07-20 13:40:04.000000000","message":"This can be simplified to \n\n  find \"$folder\" -name \"*.sh\" -exec shellcheck {} \u0027;\u0027\n\nor even\n\n  find \"{dir_list}\" -name \"*.sh\" -exec shellcheck {} \u0027;\u0027","commit_id":"bee874afa4beaae6f72137973095e598e0923bdc"},{"author":{"_account_id":10288,"name":"Aleksey","email":"alexz.kh.ua@gmail.com","username":"alexz"},"change_message_id":"339014750813af75f611d1e401b5f10bb7f187c0","unresolved":false,"context_lines":[{"line_number":879,"context_line":"          sudo apt-get install -y shellcheck"},{"line_number":880,"context_line":"          # Validate shell scripts, in each directory"},{"line_number":881,"context_line":"          for folder in {dir_list}; do"},{"line_number":882,"context_line":"              find \"$folder\" -name \u0027*.sh\u0027 -print0 | while read -d \u0027\u0027 -r script; do"},{"line_number":883,"context_line":"                  shellcheck \"$script\""},{"line_number":884,"context_line":"              done"},{"line_number":885,"context_line":"          done"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"dada55a8_c93e56d9","line":884,"range":{"start_line":882,"start_character":14,"end_line":884,"end_character":18},"in_reply_to":"dada55a8_f3398df3","updated":"2016-07-20 14:13:24.000000000","message":"The main idea of using trick with `while` - in this case we cover folders with strange names like with spaces and etc","commit_id":"bee874afa4beaae6f72137973095e598e0923bdc"}],"jenkins/jobs/projects.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"24f51c1c7392b9eed86e29b72850d74380b8bfe5","unresolved":false,"context_lines":[{"line_number":4244,"context_line":"- project:"},{"line_number":4245,"context_line":"    name: murano-apps"},{"line_number":4246,"context_line":""},{"line_number":4247,"context_line":"    check:                                                                      "},{"line_number":4248,"context_line":"      - \u0027gate-{name}-linters\u0027                                                   "},{"line_number":4249,"context_line":"    gate:                                                                       "},{"line_number":4250,"context_line":"      - \u0027gate-{name}-linters\u0027                                                   "},{"line_number":4251,"context_line":"                              "},{"line_number":4252,"context_line":""},{"line_number":4253,"context_line":"- project:"},{"line_number":4254,"context_line":"    name: murano-dashboard"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dada55a8_3c7de9b1","line":4251,"range":{"start_line":4247,"start_character":1,"end_line":4251,"end_character":30},"updated":"2016-07-25 15:46:56.000000000","message":"REmove that ugly extra whitespace - and just define the job with:\n\n- \u0027gate-{name}-linters\u0027","commit_id":"4405af39bc61bd2cb34a20d56c709a4b14f29e9d"}],"zuul/layout.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"24f51c1c7392b9eed86e29b72850d74380b8bfe5","unresolved":false,"context_lines":[{"line_number":8306,"context_line":"    check:"},{"line_number":8307,"context_line":"      - name: gate-murano-apps-linters"},{"line_number":8308,"context_line":"        voting: false"},{"line_number":8309,"context_line":"    gate:"},{"line_number":8310,"context_line":"      - name: gate-murano-apps-linters"},{"line_number":8311,"context_line":"        voting: false"},{"line_number":8312,"context_line":""},{"line_number":8313,"context_line":"  - name: openstack/murano-dashboard"},{"line_number":8314,"context_line":"    template:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"dada55a8_3c54c91f","line":8311,"range":{"start_line":8309,"start_character":1,"end_line":8311,"end_character":21},"updated":"2016-07-25 15:46:56.000000000","message":"non-voting jobs  are not part of gate, remove this\n\nAnd move the voting defition to the top like others are.\n\nAnd it\u0027s\ncheck:\n - gate-...\n\nName is only used for templates","commit_id":"4405af39bc61bd2cb34a20d56c709a4b14f29e9d"},{"author":{"_account_id":6816,"name":"Jesse Pretorius","email":"jesse@odyssey4.me","username":"jesse-pretorius"},"change_message_id":"e86cb413e24eef6dc1406d30b48aabea511f5a46","unresolved":false,"context_lines":[{"line_number":8576,"context_line":"  - name: openstack/murano-apps"},{"line_number":8577,"context_line":"    template:"},{"line_number":8578,"context_line":"      - name: merge-check"},{"line_number":8579,"context_line":"      - name: noop-jobs"},{"line_number":8580,"context_line":"    check:"},{"line_number":8581,"context_line":"      - name: gate-murano-apps-linters"},{"line_number":8582,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":11,"id":"dada55a8_d300c968","line":8579,"range":{"start_line":8579,"start_character":0,"end_line":8579,"end_character":23},"updated":"2016-07-26 12:23:17.000000000","message":"I think this will have to come out for the check to work.","commit_id":"92c87267e086f1e7a2f9d0f1ef48ea6dfad1cc7b"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4d006d51627a3184f8659ae13b26e9fcfec469fb","unresolved":false,"context_lines":[{"line_number":8577,"context_line":"    template:"},{"line_number":8578,"context_line":"      - name: merge-check"},{"line_number":8579,"context_line":"    check:"},{"line_number":8580,"context_line":"      - name: gate-murano-apps-linters"},{"line_number":8581,"context_line":""},{"line_number":8582,"context_line":"  - name: openstack/murano-dashboard"},{"line_number":8583,"context_line":"    template:"}],"source_content_type":"text/x-yaml","patch_set":12,"id":"dada55a8_9bee5feb","line":8580,"range":{"start_line":8580,"start_character":8,"end_line":8580,"end_character":14},"updated":"2016-07-26 14:28:00.000000000","message":"remove \"name:\", that is only needed for templates.","commit_id":"66d6910eeb52c7ab62cf869416a380c469d5c246"}]}
