)]}'
{"jenkins/jobs/macros.yaml":[{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"ca2568e40c2d275354dfc2d6766bd535897c4bd7","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"          # Xvfb Buffer..."},{"line_number":285,"context_line":"          export DISPLAY\u003d:99"},{"line_number":286,"context_line":"          npm install"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"          # Run any custom devstack configuration required by the project"},{"line_number":289,"context_line":"          function pre_test_hook {{"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_1fe117ff","line":286,"updated":"2016-07-28 15:40:25.000000000","message":"Are we sure we the current cwd is the right directory ?","commit_id":"da25d97b7decf1582d6e516cc52c93790784f6e6"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"ea611338332ed821de38d52cdb0b96fccb3890ab","unresolved":false,"context_lines":[{"line_number":283,"context_line":""},{"line_number":284,"context_line":"          # Xvfb Buffer..."},{"line_number":285,"context_line":"          export DISPLAY\u003d:99"},{"line_number":286,"context_line":"          npm install"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"          # Run any custom devstack configuration required by the project"},{"line_number":289,"context_line":"          function pre_test_hook {{"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_cdf236d2","line":286,"in_reply_to":"bacf61ea_1fe117ff","updated":"2016-07-29 18:00:47.000000000","message":"I believe so. All macros need to start from the same set of assumptions, so it should start in the same place as the npm-run macro.","commit_id":"da25d97b7decf1582d6e516cc52c93790784f6e6"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"0a7698b705be221b1356f9d464b57a5914b33790","unresolved":false,"context_lines":[{"line_number":290,"context_line":"              cd $WORKSPACE"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"              # If the project wants to configure devstack, otherwise continue."},{"line_number":293,"context_line":"              npm configure-devstack || true"},{"line_number":294,"context_line":"          }}"},{"line_number":295,"context_line":"          export -f pre_test_hook"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_134ad2c5","line":293,"updated":"2016-07-28 06:01:13.000000000","message":"we mentioned this in irc this morning, but i\u0027d rather no see this if we\u0027re creating a new interface as it tends to hide problems that come back to bite you later","commit_id":"da25d97b7decf1582d6e516cc52c93790784f6e6"},{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"ca2568e40c2d275354dfc2d6766bd535897c4bd7","unresolved":false,"context_lines":[{"line_number":290,"context_line":"              cd $WORKSPACE"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"              # If the project wants to configure devstack, otherwise continue."},{"line_number":293,"context_line":"              npm configure-devstack || true"},{"line_number":294,"context_line":"          }}"},{"line_number":295,"context_line":"          export -f pre_test_hook"},{"line_number":296,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_1f863713","line":293,"in_reply_to":"bacf61ea_134ad2c5","updated":"2016-07-28 15:40:25.000000000","message":"I agree and it should be \"npm run configure-devstack\"\n\nWe could check if the task exists before executing by doing something like:\n\n if npm run | grep configure-devstack \u003e /dev/null ; then #list all tasks and search for configure-devstack\n   npm run configure-devstack # we don\u0027t have \"|| true\" anymore so if the task exists and fail, we should stop.\n fi","commit_id":"da25d97b7decf1582d6e516cc52c93790784f6e6"},{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"ca2568e40c2d275354dfc2d6766bd535897c4bd7","unresolved":false,"context_lines":[{"line_number":304,"context_line":"              if [[ $npm_lifecycle_phases \u003d~ (^| ){command}($| ) ]]; then"},{"line_number":305,"context_line":"                  npm {command} --silent -- --keystone-url http://localhost:5000/"},{"line_number":306,"context_line":"              else"},{"line_number":307,"context_line":"                  npm run {command} --silent -- --keystone-url http://localhost:5000/"},{"line_number":308,"context_line":"              fi"},{"line_number":309,"context_line":"          }}"},{"line_number":310,"context_line":"          export -f post_test_hook"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_df92df4a","line":307,"updated":"2016-07-28 15:40:25.000000000","message":"What\u0027s the goal of this `--keystone-url` ? I don\u0027t see it used anywhere in our tests. Ideally we would need all openstack credentials in our functional-test. So we need one of the files in \"/opt/stack/new/devstack/accrc\" (ex: /opt/stack/new/devstack/accrc/admin/admin)\n\nWe could either source this file in this script, or give the url as --openstack-credentials /file/name.\nAccording to this review introducing functionnal tests, it expect environement variables, so it would be easier to source the file.\nhttps://review.openstack.org/#/c/345529/3/test/functional/helpers/cloudsConfig.js","commit_id":"da25d97b7decf1582d6e516cc52c93790784f6e6"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"ea611338332ed821de38d52cdb0b96fccb3890ab","unresolved":false,"context_lines":[{"line_number":304,"context_line":"              if [[ $npm_lifecycle_phases \u003d~ (^| ){command}($| ) ]]; then"},{"line_number":305,"context_line":"                  npm {command} --silent -- --keystone-url http://localhost:5000/"},{"line_number":306,"context_line":"              else"},{"line_number":307,"context_line":"                  npm run {command} --silent -- --keystone-url http://localhost:5000/"},{"line_number":308,"context_line":"              fi"},{"line_number":309,"context_line":"          }}"},{"line_number":310,"context_line":"          export -f post_test_hook"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_add702ec","line":307,"in_reply_to":"bacf61ea_df92df4a","updated":"2016-07-29 18:00:47.000000000","message":"Well, I put that in there to start the discussion on how we\u0027d tell the project where Devstack is accessible. Given that we can\u0027t exactly prescribe how the tests are structured, it\u0027s probably better to rely on environment variables (which are a little more portable) than to expect a commandline parameter on every test invocation.\n\n(i.e. I agree with using Environment Vars, lemme go update that)","commit_id":"da25d97b7decf1582d6e516cc52c93790784f6e6"},{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"8f6ea04fe69284c8fb2b6e89dc10c3e88370d843","unresolved":false,"context_lines":[{"line_number":292,"context_line":"              if [[ $npm_lifecycle_phases \u003d~ (^| ){pre_test_command}($| ) ]]; then"},{"line_number":293,"context_line":"                  npm {pre_test_command} --silent"},{"line_number":294,"context_line":"              else"},{"line_number":295,"context_line":"                  npm run {pre_test_command} --silent"},{"line_number":296,"context_line":"              fi"},{"line_number":297,"context_line":"          }}"},{"line_number":298,"context_line":"          export -f pre_test_hook"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_4d060987","line":295,"updated":"2016-07-29 17:46:34.000000000","message":"\"--silent\" looks like to be a shorthand for \"--log-level silent\". So I asume it won\u0027t log any output, it make debugging of our jobs more complicated. Also if the task doesn\u0027t exist, will it fail silently or will the jenkins build stop ? (as pre_test_hook failed)","commit_id":"6cd7b19dfb9df6bbda7c61993ed92f3ef4b9bc62"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"cb2e4d240095410631de82e3eee8d77bfcc87088","unresolved":false,"context_lines":[{"line_number":292,"context_line":"              if [[ $npm_lifecycle_phases \u003d~ (^| ){pre_test_command}($| ) ]]; then"},{"line_number":293,"context_line":"                  npm {pre_test_command} --silent"},{"line_number":294,"context_line":"              else"},{"line_number":295,"context_line":"                  npm run {pre_test_command} --silent"},{"line_number":296,"context_line":"              fi"},{"line_number":297,"context_line":"          }}"},{"line_number":298,"context_line":"          export -f pre_test_hook"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_bfdc0874","line":295,"in_reply_to":"bacf61ea_4d060987","updated":"2016-07-29 18:02:23.000000000","message":"--silent only removes the log output from npm - it doesn\u0027t impact the log output from karma, jasmine, etc.","commit_id":"6cd7b19dfb9df6bbda7c61993ed92f3ef4b9bc62"},{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"8f6ea04fe69284c8fb2b6e89dc10c3e88370d843","unresolved":false,"context_lines":[{"line_number":302,"context_line":"              if [[ $npm_lifecycle_phases \u003d~ (^| ){post_test_command}($| ) ]]; then"},{"line_number":303,"context_line":"                  npm {post_test_command} --silent -- --config /etc/openstack/clouds.yaml"},{"line_number":304,"context_line":"              else"},{"line_number":305,"context_line":"                  npm run {post_test_command} --silent -- --config /etc/openstack/clouds.yaml"},{"line_number":306,"context_line":"              fi"},{"line_number":307,"context_line":"          }}"},{"line_number":308,"context_line":"          export -f post_test_hook"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_4d2d69fd","line":305,"updated":"2016-07-29 17:46:34.000000000","message":"Great I didn\u0027t know there was a clouds.yaml available. I\u0027ll change my review in js-openstack-lib to support this \"--config\".","commit_id":"6cd7b19dfb9df6bbda7c61993ed92f3ef4b9bc62"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"43fa11227ad10421059b0defc8052c7491bb7f5a","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":"          function post_test_hook {{"},{"line_number":301,"context_line":"              # Location of devstack\u0027s clouds.yaml parameter should be available in"},{"line_number":302,"context_line":"              # env $CLOUDS_YAML"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"              # Try running as a standard lifecycle script, otherwise try custom."},{"line_number":305,"context_line":"              if [[ $npm_lifecycle_phases \u003d~ (^| ){post_test_command}($| ) ]]; then"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bacf61ea_663da0dc","line":302,"updated":"2016-08-01 16:38:53.000000000","message":"From Monty: The reason that CLOUDS_YAML isn\u0027t exported, is because that\u0027s one of the canonical locations for clouds.yaml.\n\nNow, in reality it\u0027s only _one_ of the canonical locations of clouds.yaml, and I\u0027m not certain we want to create a precedent for depending on this particular location - hence why the depends-on exports the CLOUDS_YAML config field. But then, do we really want to set the precedent that all devstack javascript projects are configured via clouds.yaml? I\u0027m not certain we do.","commit_id":"2bd701b0d4cd4f23475e5a6765e97234450a50dc"},{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"9c608fb55602c5ef446101d0bcba80bc125578d0","unresolved":false,"context_lines":[{"line_number":299,"context_line":""},{"line_number":300,"context_line":"          function post_test_hook {{"},{"line_number":301,"context_line":"              # Location of devstack\u0027s clouds.yaml parameter should be available in"},{"line_number":302,"context_line":"              # env $CLOUDS_YAML"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"              # Try running as a standard lifecycle script, otherwise try custom."},{"line_number":305,"context_line":"              if [[ $npm_lifecycle_phases \u003d~ (^| ){post_test_command}($| ) ]]; then"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"bacf61ea_8c56f503","line":302,"in_reply_to":"bacf61ea_663da0dc","updated":"2016-08-01 16:59:12.000000000","message":"Alright so that would mean we don\u0027t load a clouds.yaml file but generate one from environment variables? like sourcing \"~stack/devstack/accrc/admin/admin\" ? (similar to https://github.com/openstack/python-openstacksdk/blob/master/post_test_hook.sh#L11-L15)","commit_id":"2bd701b0d4cd4f23475e5a6765e97234450a50dc"}],"jenkins/jobs/projects.yaml":[{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"ca2568e40c2d275354dfc2d6766bd535897c4bd7","unresolved":false,"context_lines":[{"line_number":3470,"context_line":"      - nodejs6-jobs"},{"line_number":3471,"context_line":"      - nodejs6-docs"},{"line_number":3472,"context_line":"      - \u0027{name}-dsvm-nodejs{version}-npm-run-{command}\u0027:"},{"line_number":3473,"context_line":"          command: test"},{"line_number":3474,"context_line":"          version: 6"},{"line_number":3475,"context_line":"      - \u0027{name}-nodejs{version}-npm-docs-publish\u0027:"},{"line_number":3476,"context_line":"          docs_path: \"sdks/javascript/js-openstack-lib\""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bacf61ea_ffb6c3da","line":3473,"updated":"2016-07-28 15:40:25.000000000","message":"shouldn\u0027t this be \"functional-test\" instead? I know the js-openstack-lib review about functional-test is not merged yet, but running unit tests not talking to devstack doesn\u0027t give us much value.","commit_id":"da25d97b7decf1582d6e516cc52c93790784f6e6"}],"zuul/layout.yaml":[{"author":{"_account_id":8614,"name":"Corentin Ardeois","email":"corentin.ardeois@gmail.com","username":"cardeois"},"change_message_id":"8f6ea04fe69284c8fb2b6e89dc10c3e88370d843","unresolved":false,"context_lines":[{"line_number":7676,"context_line":"      - js-openstack-lib-dsvm-nodejs6-npm-run-functional-test"},{"line_number":7677,"context_line":"      - js-openstack-lib-dsvm-nodejs4-npm-run-functional-test"},{"line_number":7678,"context_line":"    gate:"},{"line_number":7679,"context_line":"      - js-openstack-lib-dsvm-nodejs4-npm-run-functional-test"},{"line_number":7680,"context_line":"    pre-release:"},{"line_number":7681,"context_line":"      - js-openstack-lib-nodejs6-npm-docs-publish"},{"line_number":7682,"context_line":"    release:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_ed441db8","line":7679,"updated":"2016-07-29 17:46:34.000000000","message":"Shouldn\u0027t we start with \u0027experiment\u0027 of \u0027check\u0027 first? To be sure our flow is setup correctly?","commit_id":"6cd7b19dfb9df6bbda7c61993ed92f3ef4b9bc62"},{"author":{"_account_id":9717,"name":"Michael Krotscheck","email":"krotscheck@gmail.com","username":"krotscheck"},"change_message_id":"cb2e4d240095410631de82e3eee8d77bfcc87088","unresolved":false,"context_lines":[{"line_number":7676,"context_line":"      - js-openstack-lib-dsvm-nodejs6-npm-run-functional-test"},{"line_number":7677,"context_line":"      - js-openstack-lib-dsvm-nodejs4-npm-run-functional-test"},{"line_number":7678,"context_line":"    gate:"},{"line_number":7679,"context_line":"      - js-openstack-lib-dsvm-nodejs4-npm-run-functional-test"},{"line_number":7680,"context_line":"    pre-release:"},{"line_number":7681,"context_line":"      - js-openstack-lib-nodejs6-npm-docs-publish"},{"line_number":7682,"context_line":"    release:"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bacf61ea_3f3e588c","line":7679,"in_reply_to":"bacf61ea_ed441db8","updated":"2016-07-29 18:02:23.000000000","message":"I like living on the edge. You? ;)\n\n(FINE FINE, I\u0027ll change it)","commit_id":"6cd7b19dfb9df6bbda7c61993ed92f3ef4b9bc62"}]}