)]}'
{"jenkins/jobs/devstack-gate.yaml":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b9ffc53b393d0915536734eafdc805d70b59b2f8","unresolved":false,"context_lines":[{"line_number":1667,"context_line":"      - console-log"},{"line_number":1668,"context_line":""},{"line_number":1669,"context_line":"- job-template:"},{"line_number":1670,"context_line":"    name: \u0027{pipeline}-tempest-dsvm-full-devstack-plugin-nfs-{mode}{job-suffix}\u0027"},{"line_number":1671,"context_line":"    node: \u0027{node}\u0027"},{"line_number":1672,"context_line":""},{"line_number":1673,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a89bdaa_10230dbe","line":1670,"updated":"2016-09-13 15:25:27.000000000","message":"As part of the trusty/xenial split we have been putting -{node} in the job names as well. By default this makes -ubuntu-xenial jobs run against \u003e\u003d newton and trusty for \u003c newton. Probably want to just future proof here and go ahead and do that now. This job then becomes:\n\n  \u0027{pipeline}-tempest-dsvm-full-devstack-plugin-nfs-{mode}-{node}{job-suffix}\u0027","commit_id":"b52af627cfea9d13a386949477959f3140cb45d4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"b9ffc53b393d0915536734eafdc805d70b59b2f8","unresolved":false,"context_lines":[{"line_number":1689,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin devstack-plugin-{plugin} git://git.openstack.org/{plugin-repo}\""},{"line_number":1690,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_NFS_CINDER\u003dTrue\""},{"line_number":1691,"context_line":"          export NFS_SECURE_FILE_PERMISSIONS\u003d{secure-file-permissions}"},{"line_number":1692,"context_line":"          export NFS_SECURE_FILE_OPERATIONS\u003d{secure-file-operations}"},{"line_number":1693,"context_line":""},{"line_number":1694,"context_line":"          export BRANCH_OVERRIDE\u003d{branch-override}"},{"line_number":1695,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a89bdaa_93048715","line":1692,"updated":"2016-09-13 15:25:27.000000000","message":"Since you are setting up a binary job where either both of these are true or both are false maybe you want to use a single parameter for both? not sure if it makes sense to have one be false and the other be true.","commit_id":"b52af627cfea9d13a386949477959f3140cb45d4"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"f674a0a0180e8e8c68a83820469d0c3c285d2818","unresolved":false,"context_lines":[{"line_number":1689,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin devstack-plugin-{plugin} git://git.openstack.org/{plugin-repo}\""},{"line_number":1690,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_NFS_CINDER\u003dTrue\""},{"line_number":1691,"context_line":"          export NFS_SECURE_FILE_PERMISSIONS\u003d{secure-file-permissions}"},{"line_number":1692,"context_line":"          export NFS_SECURE_FILE_OPERATIONS\u003d{secure-file-operations}"},{"line_number":1693,"context_line":""},{"line_number":1694,"context_line":"          export BRANCH_OVERRIDE\u003d{branch-override}"},{"line_number":1695,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a89bdaa_f34dd33e","line":1692,"in_reply_to":"9a89bdaa_93048715","updated":"2016-09-13 15:27:33.000000000","message":"I should\u0027ve caught this before but if you want NFS_SECURE* env vars to be available to devstack you need to set them in the localrc using the method above so this becomes:\n\n export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"NFS_SECURE_FILE_PERMISSIONS\u003d{secure-file-permissions}\"\n export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"NFS_SECURE_FILE_OPERATIONS\u003d{secure-file-operations}\"","commit_id":"b52af627cfea9d13a386949477959f3140cb45d4"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"639e6c762d4fb367b3668048d67ee0d2704dfe5b","unresolved":false,"context_lines":[{"line_number":1689,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin devstack-plugin-{plugin} git://git.openstack.org/{plugin-repo}\""},{"line_number":1690,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_NFS_CINDER\u003dTrue\""},{"line_number":1691,"context_line":"          export NFS_SECURE_FILE_PERMISSIONS\u003d{secure-file-permissions}"},{"line_number":1692,"context_line":"          export NFS_SECURE_FILE_OPERATIONS\u003d{secure-file-operations}"},{"line_number":1693,"context_line":""},{"line_number":1694,"context_line":"          export BRANCH_OVERRIDE\u003d{branch-override}"},{"line_number":1695,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"7a8ec9b2_bed4b947","line":1692,"in_reply_to":"9a89bdaa_f34dd33e","updated":"2016-09-13 17:35:10.000000000","message":"Hmmm good catch, the vars indeed didn\u0027t get to devstack. Thanks!\n\nAbout the, 2 vars its easier to do like this, otherwise I\u0027ll have to apply some logic in the nfs_plugin to set then True/False.","commit_id":"b52af627cfea9d13a386949477959f3140cb45d4"}]}