)]}'
{"nodepool/elements/cache-devstack/extra-data.d/55-cache-devstack-repos":[{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"e3762df7f373e09650836a1d4450d15fb0d89005","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    image_tool \u003d os.path.join(basedir, \u0027tools\u0027, \u0027image_list.sh\u0027)"},{"line_number":119,"context_line":"    if os.path.exists(image_tool):"},{"line_number":120,"context_line":"        returncode, out \u003d run_local("},{"line_number":121,"context_line":"            [image_tool, \"ironic\", \"libvirt\", \"dummy\"], status\u003dTrue)"},{"line_number":122,"context_line":"        if returncode:"},{"line_number":123,"context_line":"            print \"%s failed\" % image_tool"},{"line_number":124,"context_line":"            print \"Exit: %s, Output: %s\" % (returncode, out)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a8bc5a2_19bfb561","line":121,"updated":"2016-09-27 02:55:43.000000000","message":"why \"ironic libvirt dummy\" but not \"openvz ironic libvirt vsphere dummy\"? Just remove xenserver from the list?","commit_id":"6ca6fd47c22da10a5f278669056a6adc75a307ce"},{"author":{"_account_id":17169,"name":"John Hua","email":"ihuazhihao@gmail.com","username":"johnhua"},"change_message_id":"8084899045e6a4f63fbdec41598a98387c370597","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    image_tool \u003d os.path.join(basedir, \u0027tools\u0027, \u0027image_list.sh\u0027)"},{"line_number":119,"context_line":"    if os.path.exists(image_tool):"},{"line_number":120,"context_line":"        returncode, out \u003d run_local("},{"line_number":121,"context_line":"            [image_tool, \"ironic\", \"libvirt\", \"dummy\"], status\u003dTrue)"},{"line_number":122,"context_line":"        if returncode:"},{"line_number":123,"context_line":"            print \"%s failed\" % image_tool"},{"line_number":124,"context_line":"            print \"Exit: %s, Output: %s\" % (returncode, out)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a8bc5a2_f18d822b","line":121,"in_reply_to":"5a8bc5a2_19bfb561","updated":"2016-09-28 01:55:16.000000000","message":"As advised by Bob, only these three are tested.","commit_id":"6ca6fd47c22da10a5f278669056a6adc75a307ce"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"94e2e0eba9af3221ff04a5b4e8d0a8d8eb9192d7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    image_tool \u003d os.path.join(basedir, \u0027tools\u0027, \u0027image_list.sh\u0027)"},{"line_number":119,"context_line":"    if os.path.exists(image_tool):"},{"line_number":120,"context_line":"        returncode, out \u003d run_local("},{"line_number":121,"context_line":"            [image_tool, \"ironic\", \"libvirt\", \"dummy\"], status\u003dTrue)"},{"line_number":122,"context_line":"        if returncode:"},{"line_number":123,"context_line":"            print \"%s failed\" % image_tool"},{"line_number":124,"context_line":"            print \"Exit: %s, Output: %s\" % (returncode, out)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3a98d1f4_67b6fd8b","line":121,"in_reply_to":"5a8bc5a2_59b490d0","updated":"2016-09-29 02:12:56.000000000","message":"Cool. Thanks for the clarification. this change looks good to me. Although a comment in source code may be useful for future understanding.","commit_id":"6ca6fd47c22da10a5f278669056a6adc75a307ce"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"11364fd76c89330a4a255c0fa8dd35f0edbd6501","unresolved":false,"context_lines":[{"line_number":118,"context_line":"    image_tool \u003d os.path.join(basedir, \u0027tools\u0027, \u0027image_list.sh\u0027)"},{"line_number":119,"context_line":"    if os.path.exists(image_tool):"},{"line_number":120,"context_line":"        returncode, out \u003d run_local("},{"line_number":121,"context_line":"            [image_tool, \"ironic\", \"libvirt\", \"dummy\"], status\u003dTrue)"},{"line_number":122,"context_line":"        if returncode:"},{"line_number":123,"context_line":"            print \"%s failed\" % image_tool"},{"line_number":124,"context_line":"            print \"Exit: %s, Output: %s\" % (returncode, out)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5a8bc5a2_59b490d0","line":121,"in_reply_to":"5a8bc5a2_f18d822b","updated":"2016-09-28 08:33:34.000000000","message":"The intention is to only cache the images that are used in the CIs run by Infra.\nvsphere (for example) has a large image which is cached by Infra\u0027s scripts but never used.","commit_id":"6ca6fd47c22da10a5f278669056a6adc75a307ce"}]}