)]}'
{"jenkins/jobs/macros.yaml":[{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"86aa111d5862dda1e0b8c99f8f152e12aca23cdd","unresolved":false,"context_lines":[{"line_number":1079,"context_line":"          # format the new file as xfs"},{"line_number":1080,"context_line":"          mkfs.xfs ${HOME}/xfs_partition"},{"line_number":1081,"context_line":"          # loopback mount the file to /tmp"},{"line_number":1082,"context_line":"          sudo mount -o loop,noatime,nodiratime ${HOME}/xfs_partition /tmp"},{"line_number":1083,"context_line":"          sudo chmod 777 /tmp"},{"line_number":1084,"context_line":""},{"line_number":1085,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"9a629dbe_4d8f5923","line":1082,"updated":"2016-11-07 22:58:23.000000000","message":"My primary concern is that Ansible (as called from zuul-launcher) copies job scripts into /tmp and also buffers the job console log from /tmp/console.html so it may cause the job to be unable to complete and may also make it harder to debug. Is it possible the files created by these tests can be corralled into a specific subdirectory of /tmp so that we could just mount the xfs filesystem there?","commit_id":"a3f1f4b60dac1e29bf16d5273732bc48f250358c"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0da91f3c56a7ea259d0bd1139152e4fb8035f7a4","unresolved":false,"context_lines":[{"line_number":1077,"context_line":"          # create a large-ish file that we\u0027ll mount as a loopback"},{"line_number":1078,"context_line":"          truncate -s 1GB ${HOME}/xfs_partition"},{"line_number":1079,"context_line":"          # format the new file as xfs"},{"line_number":1080,"context_line":"          mkfs.xfs ${HOME}/xfs_partition"},{"line_number":1081,"context_line":"          # loopback mount the file"},{"line_number":1082,"context_line":"          mkdir ${HOME}/xfstmp"},{"line_number":1083,"context_line":"          sudo mount -o loop,noatime,nodiratime ${HOME}/xfs_partition ${HOME}/xfstmp"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a77a97e_d3e824e5","line":1080,"updated":"2016-11-16 18:15:00.000000000","message":"Perhaps make ${HOME}/xfs_partition a parameter to this builder...","commit_id":"695591b18197cf6cc766cab3dc72f2407444bc7e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"08583e12d1ca364784b85c96f231c5f76a5312ae","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"          sudo mount -o loop,noatime,nodiratime ${HOME}/xfs_partition ${HOME}/xfstmp"},{"line_number":1084,"context_line":"          sudo chmod 777 ${HOME}/xfstmp"},{"line_number":1085,"context_line":"          # export the mountpoint as TMPDIR so tests can use it"},{"line_number":1086,"context_line":"          export TMPDIR\u003d${HOME}/xfstmp"},{"line_number":1087,"context_line":""},{"line_number":1088,"context_line":"# \u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":1089,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a77a97e_ea470449","line":1086,"range":{"start_line":1086,"start_character":9,"end_line":1086,"end_character":38},"updated":"2016-11-16 08:22:41.000000000","message":"Will this get passed to your scripts? I doubt it. These are different shell invocations.","commit_id":"695591b18197cf6cc766cab3dc72f2407444bc7e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"64b73a9ac2df94018467d459b59c0746e8e6644c","unresolved":false,"context_lines":[{"line_number":779,"context_line":"- builder:"},{"line_number":780,"context_line":"    name: tox-with-tmpdir-passed-in"},{"line_number":781,"context_line":"    builders:"},{"line_number":782,"context_line":"      - shell: \"/usr/local/jenkins/slave_scripts/run-tox-with-tmpdir-passed-in.sh {new_tmpdir_loc} {envlist}\""},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"- builder:"},{"line_number":785,"context_line":"    name: assert-no-extra-files"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7a77a97e_8d8672d9","line":782,"updated":"2016-11-17 06:10:28.000000000","message":"Why not make this a two liner and reuse the existing script?\n\nJust use\n\nexport TMPDIR\u003d... as first line","commit_id":"63b5419e4cc71490af4e246a5c74badf56e8711a"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"872b7c0147326e2781d5b035264e3c19343f1877","unresolved":false,"context_lines":[{"line_number":782,"context_line":"      - shell: |"},{"line_number":783,"context_line":"          #!/bin/bash"},{"line_number":784,"context_line":"          export TMPDIR\u003d{new_tmpdir_loc}"},{"line_number":785,"context_line":"          exit /usr/local/jenkins/slave_scripts/run-tox.sh {envlist}\""},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"- builder:"},{"line_number":788,"context_line":"    name: assert-no-extra-files"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_75b2664d","line":785,"updated":"2016-11-18 19:21:44.000000000","message":"My concern was more over patchset 6 which was adding a new script. In this case the job will succeed and just not use the alternative TMPDIR until the run-tox.sh modification from this change appears in all our images. As long as gradually phasing in the new behavior is acceptable to the Swift team, this seems like a fine choice.","commit_id":"f19f2fc381b8c0dc5f7c8402efa488007d8ed1c1"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4b2fdb68ac4e4fa7a0f488bb122d233b3b834425","unresolved":false,"context_lines":[{"line_number":782,"context_line":"      - shell: |"},{"line_number":783,"context_line":"          #!/bin/bash"},{"line_number":784,"context_line":"          export TMPDIR\u003d{new_tmpdir_loc}"},{"line_number":785,"context_line":"          exit /usr/local/jenkins/slave_scripts/run-tox.sh {envlist}\""},{"line_number":786,"context_line":""},{"line_number":787,"context_line":"- builder:"},{"line_number":788,"context_line":"    name: assert-no-extra-files"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"7a77a97e_5463cc41","line":785,"updated":"2016-11-18 07:39:43.000000000","message":"This would work - but as Jeremy explains, it takes at least a day until that script is updated.\n\nHave a look at the !include-raw instruction at:\nhttps://review.openstack.org/#/c/391499/13/jenkins/jobs/manuals-jobs.yaml\n\nThat\u0027s what Jeremy is suggestion: Inline the shell script.","commit_id":"f19f2fc381b8c0dc5f7c8402efa488007d8ed1c1"}],"jenkins/jobs/python-jobs.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"08583e12d1ca364784b85c96f231c5f76a5312ae","unresolved":false,"context_lines":[{"line_number":521,"context_line":""},{"line_number":522,"context_line":"- job-template:"},{"line_number":523,"context_line":"    name: \u0027gate-{name}-tox-xfs-tmp-{envlist}-{node}\u0027"},{"line_number":524,"context_line":"    description: \u0027Same job as gate-{name}-tox-{envlist}, mounts /tmp as xfs.\u0027"},{"line_number":525,"context_line":"    node: \u0027{node}\u0027"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a77a97e_6a7214af","line":524,"range":{"start_line":524,"start_character":64,"end_line":524,"end_character":75},"updated":"2016-11-16 08:22:41.000000000","message":"That part is not correct anymore.","commit_id":"695591b18197cf6cc766cab3dc72f2407444bc7e"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"0da91f3c56a7ea259d0bd1139152e4fb8035f7a4","unresolved":false,"context_lines":[{"line_number":536,"context_line":"      - install-distro-packages"},{"line_number":537,"context_line":"      - mount-xfs-tmp-space"},{"line_number":538,"context_line":"      - revoke-sudo"},{"line_number":539,"context_line":"      - tox:"},{"line_number":540,"context_line":"          envlist: \u0027{envlist}\u0027"},{"line_number":541,"context_line":"      - assert-no-extra-files"},{"line_number":542,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a77a97e_b3e1e800","line":539,"updated":"2016-11-16 18:15:00.000000000","message":"...and then instead of calling the normal tox builder, make a paremeterized copy of it that exports TMPDIR from it before invoking tox?","commit_id":"695591b18197cf6cc766cab3dc72f2407444bc7e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"08583e12d1ca364784b85c96f231c5f76a5312ae","unresolved":false,"context_lines":[{"line_number":533,"context_line":"      - print-template-name:"},{"line_number":534,"context_line":"          template-name: \"{template-name}\""},{"line_number":535,"context_line":"      - zuul-git-prep-upper-constraints"},{"line_number":536,"context_line":"      - install-distro-packages"},{"line_number":537,"context_line":"      - mount-xfs-tmp-space"},{"line_number":538,"context_line":"      - revoke-sudo"},{"line_number":539,"context_line":"      - tox:"},{"line_number":540,"context_line":"          envlist: \u0027{envlist}\u0027"},{"line_number":541,"context_line":"      - assert-no-extra-files"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    publishers:"},{"line_number":544,"context_line":"      - test-results"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a77a97e_4aa63811","line":541,"range":{"start_line":536,"start_character":7,"end_line":541,"end_character":29},"updated":"2016-11-16 08:22:41.000000000","message":"Each of these are different shells, passing of TMPDIR from mount-xfs-tmp-space to tox is not going to work.","commit_id":"695591b18197cf6cc766cab3dc72f2407444bc7e"},{"author":{"_account_id":330,"name":"John Dickinson","email":"me@not.mn","username":"notmyname"},"change_message_id":"0cca8fff4ec2c9cd52b8850c777582ca143e4a26","unresolved":false,"context_lines":[{"line_number":533,"context_line":"      - print-template-name:"},{"line_number":534,"context_line":"          template-name: \"{template-name}\""},{"line_number":535,"context_line":"      - zuul-git-prep-upper-constraints"},{"line_number":536,"context_line":"      - install-distro-packages"},{"line_number":537,"context_line":"      - mount-xfs-tmp-space"},{"line_number":538,"context_line":"      - revoke-sudo"},{"line_number":539,"context_line":"      - tox:"},{"line_number":540,"context_line":"          envlist: \u0027{envlist}\u0027"},{"line_number":541,"context_line":"      - assert-no-extra-files"},{"line_number":542,"context_line":""},{"line_number":543,"context_line":"    publishers:"},{"line_number":544,"context_line":"      - test-results"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7a77a97e_b8a0ea44","line":541,"range":{"start_line":536,"start_character":7,"end_line":541,"end_character":29},"in_reply_to":"7a77a97e_4aa63811","updated":"2016-11-16 17:01:10.000000000","message":"Is there a mechanism for doing that? How can we define something in one builder that gets passed to a different builder (as environment vars)?\n\nI suppose a \"just make it work\" option would be to have some different channel of communication (eg leaving files on disk) or hard code the expected TMPDIR location into tests (which means keeping magic strings in sync across two repos). Both of those seem less than ideal.","commit_id":"695591b18197cf6cc766cab3dc72f2407444bc7e"}],"jenkins/scripts/run-tox-with-tmpdir-passed-in.sh":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"64b73a9ac2df94018467d459b59c0746e8e6644c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"7a77a97e_ad56ce59","updated":"2016-11-17 06:10:28.000000000","message":"Let\u0027s reuse the existing script instead of duplicating it.\n\nI see now that it sets TMPDIR already, so give it an optional parameter or variable - and only set TMPDIR if needed.","commit_id":"63b5419e4cc71490af4e246a5c74badf56e8711a"}]}