)]}'
{"jenkins/jobs/networking-odl.yaml":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e1d9f8782a65385a72a72222acfe261184f05421","unresolved":false,"context_lines":[{"line_number":189,"context_line":"          # caches in nodepool, however make it a valid url for"},{"line_number":190,"context_line":"          # documentation purposes."},{"line_number":191,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl\""},{"line_number":192,"context_line":"          export DEVSTACK_SUBNODE_CONFIG\u003d\"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl\""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"          # Keep localrc to be able to set some vars in pre_test_hook"},{"line_number":195,"context_line":"          export KEEP_LOCALRC\u003d1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a77a97e_f86982bf","line":192,"range":{"start_line":192,"start_character":10,"end_line":192,"end_character":120},"updated":"2016-11-16 16:51:38.000000000","message":"is it really needed to enable this on both nodes ?","commit_id":"42dfc381891230ba56d01bc7c424173e4a2ad1e4"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b31c6524916c30fdbb9b7d51a13e894c77249830","unresolved":false,"context_lines":[{"line_number":189,"context_line":"          # caches in nodepool, however make it a valid url for"},{"line_number":190,"context_line":"          # documentation purposes."},{"line_number":191,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl\""},{"line_number":192,"context_line":"          export DEVSTACK_SUBNODE_CONFIG\u003d\"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl\""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"          # Keep localrc to be able to set some vars in pre_test_hook"},{"line_number":195,"context_line":"          export KEEP_LOCALRC\u003d1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a77a97e_615bb6f6","line":192,"range":{"start_line":192,"start_character":10,"end_line":192,"end_character":120},"in_reply_to":"7a77a97e_00d4c3ba","updated":"2016-11-17 21:32:35.000000000","message":"Marucs I was missing dhcp agent enabling I think overriding works, from logs it only enabled services on the we added ENABLED_SERVICES appended at end. \n\nhttp://logs.openstack.org/54/397354/5/check/gate-tempest-dsvm-networking-odl-multinode-carbon-snapshot-nv/d4617ce/logs/subnode-2/devstacklog.summary.txt.gz","commit_id":"42dfc381891230ba56d01bc7c424173e4a2ad1e4"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ff3f990038809177cea28c618bfd908ebb16972b","unresolved":false,"context_lines":[{"line_number":189,"context_line":"          # caches in nodepool, however make it a valid url for"},{"line_number":190,"context_line":"          # documentation purposes."},{"line_number":191,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl\""},{"line_number":192,"context_line":"          export DEVSTACK_SUBNODE_CONFIG\u003d\"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl\""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"          # Keep localrc to be able to set some vars in pre_test_hook"},{"line_number":195,"context_line":"          export KEEP_LOCALRC\u003d1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a77a97e_00d4c3ba","line":192,"range":{"start_line":192,"start_character":10,"end_line":192,"end_character":120},"in_reply_to":"7a77a97e_bf4c4943","updated":"2016-11-17 19:14:25.000000000","message":"AFAIK it will source whole file before executing anything and we are overriding the variables, networking-ovn uses same concept these will be appended to the end and I\u0027ve tried it locally on vm\u0027s and i only saw Overrided services brought up.","commit_id":"42dfc381891230ba56d01bc7c424173e4a2ad1e4"},{"author":{"_account_id":20205,"name":"Marcus Williams","email":"marcus.williams@intel.com","username":"mgkwill"},"change_message_id":"b6ec47da680435fb459ce81224b5bb8c7f4b0710","unresolved":false,"context_lines":[{"line_number":189,"context_line":"          # caches in nodepool, however make it a valid url for"},{"line_number":190,"context_line":"          # documentation purposes."},{"line_number":191,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl\""},{"line_number":192,"context_line":"          export DEVSTACK_SUBNODE_CONFIG\u003d\"enable_plugin networking-odl git://git.openstack.org/openstack/networking-odl\""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"          # Keep localrc to be able to set some vars in pre_test_hook"},{"line_number":195,"context_line":"          export KEEP_LOCALRC\u003d1"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"7a77a97e_bf4c4943","line":192,"range":{"start_line":192,"start_character":10,"end_line":192,"end_character":120},"in_reply_to":"7a77a97e_f86982bf","updated":"2016-11-16 19:51:41.000000000","message":"From review of https://review.openstack.org/#/c/294546/ and https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate.sh#L575 it appears that the purpose of  DEVSTACK_SUBNODE_CONFIG is to allow you to have a clean set of config affecting only subnodes. On those grounds alone (clean coding and explicit env variables) I\u0027d want this merged. \n\nIn regards to your patch https://review.openstack.org/#/c/397354/ and enabling on both nodes, I fear that by the time you are adding to DEVSTACK_SUBNODE_CONFIG like \"export DEVSTACK_SUBNODE_CONFIG+\u003d$\u0027\\n\u0027\"ENABLED_SERVICES\u003dn-cpu,dstat,c-vol,c-bak\" it\u0027s possible that it\u0027s already populated with the ENABLED_SERVICES of DEVSTACK_LOCAL_CONFIG. We are relying on importing DEVSTACK_LOCAL_CONFIG as a base for DEVSTACK_SUBNODE_CONFIG but is it before or after this has been appended to? If it has been appended it is an order of operations issue for which config to use. Why not just have completely separate config for subnodes? Finally, without explicitly declaring here, we are enabling on both nodes anyway, this is how the DEVSTACK_SUBNODE_CONFIG is used:\n\nif [[ -n \"$DEVSTACK_SUBNODE_CONFIG\" ]]; then\n            echo \"$DEVSTACK_SUBNODE_CONFIG\" \u003e\u003e\"$localrc_file\"\n        else\n            if [[ -n \"$DEVSTACK_LOCAL_CONFIG\" ]]; then\n                echo \"$DEVSTACK_LOCAL_CONFIG\" \u003e\u003e\"$localrc_file\"\n            fi\n        fi","commit_id":"42dfc381891230ba56d01bc7c424173e4a2ad1e4"}]}