)]}'
{"jenkins/scripts/run-hacking-with-neutron-lib-master.sh":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a10c7ee0d2cd8ce2603d7123b2d4dd3cb3192d96","unresolved":false,"context_lines":[{"line_number":17,"context_line":"sed -i \"s/neutron-lib.*/-e git+https:\\/\\/git.openstack.org\\/openstack\\/neutron-lib.git#egg\u003dneutron-lib/g\" requirements.txt"},{"line_number":18,"context_line":"sed -i \"s/neutron-lib.*/-e git+https:\\/\\/git.openstack.org\\/openstack\\/neutron-lib.git#egg\u003dneutron-lib/g\" upper-constraints.txt"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"define_hacking_check_factory() {"},{"line_number":21,"context_line":"    # setup the local-check-factory in the [hacking] section of tox.ini"},{"line_number":22,"context_line":"    grep \u0027\\[hacking\\]\u0027 tox.ini"},{"line_number":23,"context_line":"    hacking_defined\u003d$?"},{"line_number":24,"context_line":"    grep \u0027local-check-factory\u0027 tox.ini"},{"line_number":25,"context_line":"    factory_defined\u003d$?"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    if [ ${hacking_defined} -ne 0 ]; then"},{"line_number":28,"context_line":"        cat \u003c\u003c EOF \u003e\u003e tox.ini"},{"line_number":29,"context_line":"[hacking]"},{"line_number":30,"context_line":"local-check-factory \u003d ${local_check_factory}"},{"line_number":31,"context_line":"EOF"},{"line_number":32,"context_line":"        return"},{"line_number":33,"context_line":"    fi"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    if [ ${factory_defined} -ne 0 ]; then"},{"line_number":36,"context_line":"        sed -i \"/\\[hacking\\]/a local-check-factory \u003d ${local_check_factory}\" tox.ini"},{"line_number":37,"context_line":"    else"},{"line_number":38,"context_line":"        sed -i \"/local-check-factory/c\\local-check-factory \u003d ${local_check_factory}\" tox.ini"},{"line_number":39,"context_line":"    fi"},{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"define_hacking_check_factory"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cat \u003c\u003c EOF \u003e\u003e tox.ini"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-sh","patch_set":1,"id":"da4df55a_5d07f51b","line":42,"range":{"start_line":20,"start_character":0,"end_line":42,"end_character":28},"updated":"2016-12-23 12:16:37.000000000","message":"do we really need to add this plumbing code in here? What if we add these sections in the respective tox.ini files of the subprojects we care about so that one can also have the option of running this check on their local envs?","commit_id":"ad645b84e25aa8ec5297f25fcc10b73018bd11d2"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"727f305c1e241e56e5f21c432d0a81960d6ac2e3","unresolved":false,"context_lines":[{"line_number":40,"context_line":"}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"define_hacking_check_factory"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"cat \u003c\u003c EOF \u003e\u003e tox.ini"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[testenv:hacking-checks-neutron-lib-master]"}],"source_content_type":"text/x-sh","patch_set":1,"id":"1a6eadb0_fc1c4215","line":43,"updated":"2016-12-19 22:23:16.000000000","message":"Actually as per [1], this ideally should also enable-extensions from what we have in neutron-lib\u0027s tox.ini. However that sounds pretty involved to me.\n\n\n[1] https://review.openstack.org/#/c/395776/","commit_id":"ad645b84e25aa8ec5297f25fcc10b73018bd11d2"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a10c7ee0d2cd8ce2603d7123b2d4dd3cb3192d96","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"[testenv:hacking-checks-neutron-lib-master]"},{"line_number":47,"context_line":"commands \u003d"},{"line_number":48,"context_line":"  flake8 \"$@\""},{"line_number":49,"context_line":"EOF"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"$script_path/run-tox.sh hacking-checks-neutron-lib-master"}],"source_content_type":"text/x-sh","patch_set":1,"id":"da4df55a_c085ba59","line":48,"range":{"start_line":48,"start_character":2,"end_line":48,"end_character":13},"updated":"2016-12-23 12:16:37.000000000","message":"Have you considered adding this to the other script\u0027s tox target command entry [1]. I appreciate that by doing so we\u0027d be running flake checks as well as unit tests and a failure of the former would prevent a run of the latter but the amount of complexity/and moving parts induced by this change is a bit mind boggling.\n\n[1] jenkins/scripts/run-tox-with-neutron-lib-master.sh","commit_id":"ad645b84e25aa8ec5297f25fcc10b73018bd11d2"}]}