)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"1e7613558bf0e0e4d2cdb086004de3403a3d3470","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron: set DEVSTACK_GATE_NEUTRON_DVR\u003d1 for api tempest job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This job contains DVR tests, so it makes sense to set the variable. It"},{"line_number":10,"context_line":"also allows neutron gate hook to inspect the variable to determine if it"},{"line_number":11,"context_line":"should configure tempest.conf to include dvr extension tests."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da4df55a_59dd7241","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":27},"updated":"2016-12-22 14:50:15.000000000","message":"What DVR tests are you referring to? Nothing against this change per se, but I\u0027d like to understand a little more about the reasoning behind this change. Test [1,2] will execute irrespective of the flag.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/test_routers.py\n[2] https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/test_routers_negative.py","commit_id":"1e53cba1946d7462884344d27a3e4c7b1c3fb95a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7082349f5f72f9ffe81a8a187d6c50f6cd862647","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron: set DEVSTACK_GATE_NEUTRON_DVR\u003d1 for api tempest job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This job contains DVR tests, so it makes sense to set the variable. It"},{"line_number":10,"context_line":"also allows neutron gate hook to inspect the variable to determine if it"},{"line_number":11,"context_line":"should configure tempest.conf to include dvr extension tests."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da4df55a_8fcea881","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":27},"in_reply_to":"da4df55a_0c9566e3","updated":"2016-12-22 15:28:29.000000000","message":"Here I mean:\n\nhttps://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/neutron.yaml#L623","commit_id":"1e53cba1946d7462884344d27a3e4c7b1c3fb95a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e25a1331f1165faa1baaa0e6f0e922a2ddc30afa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron: set DEVSTACK_GATE_NEUTRON_DVR\u003d1 for api tempest job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This job contains DVR tests, so it makes sense to set the variable. It"},{"line_number":10,"context_line":"also allows neutron gate hook to inspect the variable to determine if it"},{"line_number":11,"context_line":"should configure tempest.conf to include dvr extension tests."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da4df55a_6cb992e9","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":27},"in_reply_to":"da4df55a_59dd7241","updated":"2016-12-22 15:06:04.000000000","message":"At the moment, api job executes all tests, including dvr, because we unconditionally configure tempest to execute them.\n\nBut there is another patch that I have that makes the gate hook to configure dvr tempest tests only when DEVSTACK_GATE_NEUTRON_DVR is enabled: https://review.openstack.org/#/c/412553/ (that latter patch is needed to make dvr scenarios we are working on to NOT be triggered in non-dvr scenario jobs).\n\nIf we would land the latter without this change, then api job would stop to execute dvr tests, because then tempest would not be configured to execute DVR api tests.","commit_id":"1e53cba1946d7462884344d27a3e4c7b1c3fb95a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7fd4ed0018b3c876e6766a42a638bb1d878cdce2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"neutron: set DEVSTACK_GATE_NEUTRON_DVR\u003d1 for api tempest job"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This job contains DVR tests, so it makes sense to set the variable. It"},{"line_number":10,"context_line":"also allows neutron gate hook to inspect the variable to determine if it"},{"line_number":11,"context_line":"should configure tempest.conf to include dvr extension tests."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da4df55a_0c9566e3","line":9,"range":{"start_line":9,"start_character":18,"end_line":9,"end_character":27},"in_reply_to":"da4df55a_6cb992e9","updated":"2016-12-22 15:21:44.000000000","message":"That\u0027s not true, we run them because DVR is part of the extensions under test, as you correctly identified in [1]. I think the root of it is that DEVSTACK_GATE_NEUTRON_DVR flips the router\u0027s default to being DVR. What are these scenario tests that you\u0027re referring to? Maybe we should add the DEVSTACK_GATE_NEUTRON_DVR bit to the scenario job instead.\n\n[1] https://review.openstack.org/#/c/412553/","commit_id":"1e53cba1946d7462884344d27a3e4c7b1c3fb95a"}]}