)]}'
{"jenkins/jobs/puppet-module-jobs.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"eacc930ae5447bc7aa3bca9fce8d60f805e977bd","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - gerrit-git-prep"},{"line_number":38,"context_line":"      - install-distro-packages"},{"line_number":39,"context_line":"      - puppet-prepare-node"},{"line_number":40,"context_line":"      - revoke-sudo"},{"line_number":41,"context_line":"      - shell: |"},{"line_number":42,"context_line":"          if [ \"{puppet_version}\" !\u003d \"latest\" ]; then"},{"line_number":43,"context_line":"            export PUPPET_GEM_VERSION\u003d\u0027~\u003e {puppet_version}.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_c201046c","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":19},"updated":"2017-01-29 15:17:03.000000000","message":"for other jobs we have \"revoke-sudo\" here - do you want to add that to your job as well. That\u0027s what I wanted to figure out","commit_id":"95e206b0b04bab09d1d1bf08ad3b869ab1b579e8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"605555b41a76254863746928361772a45ee5abc1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"      - gerrit-git-prep"},{"line_number":38,"context_line":"      - install-distro-packages"},{"line_number":39,"context_line":"      - puppet-prepare-node"},{"line_number":40,"context_line":"      - revoke-sudo"},{"line_number":41,"context_line":"      - shell: |"},{"line_number":42,"context_line":"          if [ \"{puppet_version}\" !\u003d \"latest\" ]; then"},{"line_number":43,"context_line":"            export PUPPET_GEM_VERSION\u003d\u0027~\u003e {puppet_version}.0\u0027"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_c77ae187","line":40,"range":{"start_line":40,"start_character":2,"end_line":40,"end_character":19},"in_reply_to":"3a461143_c201046c","updated":"2017-01-30 13:29:04.000000000","message":"I don\u0027t think I need it now, I\u0027m not going to need sudo.","commit_id":"95e206b0b04bab09d1d1bf08ad3b869ab1b579e8"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"898aa3fda76e9e7d30b7b4f3bd97eccec30752fa","unresolved":false,"context_lines":[{"line_number":328,"context_line":"      - zuul-clone:"},{"line_number":329,"context_line":"          project: $ZUUL_PROJECT"},{"line_number":330,"context_line":"      - install-distro-packages"},{"line_number":331,"context_line":"      - install-puppet"},{"line_number":332,"context_line":"      - allow-local-ssh-root"},{"line_number":333,"context_line":"      - shell: |"},{"line_number":334,"context_line":"          #!/bin/bash -xe"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_92c9e35b","line":331,"updated":"2017-01-30 21:43:32.000000000","message":"I don\u0027t actually think you need this. If you remove puppet-prepare-node, you will stop uninstalling puppet.  There is no need to install it, because we do it at image build time.\n\nLikely a better option is to also use bindep.txt to express the requirement of puppet package.","commit_id":"95e206b0b04bab09d1d1bf08ad3b869ab1b579e8"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"7f55e001b4de3d236733060634ce12ada0797f26","unresolved":false,"context_lines":[{"line_number":330,"context_line":"      - install-distro-packages"},{"line_number":331,"context_line":"      - install-puppet"},{"line_number":332,"context_line":"      - allow-local-ssh-root"},{"line_number":333,"context_line":"      - shell: |"},{"line_number":334,"context_line":"          #!/bin/bash -xe"},{"line_number":335,"context_line":"          cd $ZUUL_PROJECT"},{"line_number":336,"context_line":"          puppet module build ."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_773e578d","line":333,"range":{"start_line":333,"start_character":6,"end_line":333,"end_character":16},"updated":"2017-01-28 12:49:22.000000000","message":"btw. we have not revoked sudo permissions - is that intented or should it get added as well?","commit_id":"95e206b0b04bab09d1d1bf08ad3b869ab1b579e8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f5e0880efc9059c72b234f7d9519a2d8fe989317","unresolved":false,"context_lines":[{"line_number":330,"context_line":"      - install-distro-packages"},{"line_number":331,"context_line":"      - install-puppet"},{"line_number":332,"context_line":"      - allow-local-ssh-root"},{"line_number":333,"context_line":"      - shell: |"},{"line_number":334,"context_line":"          #!/bin/bash -xe"},{"line_number":335,"context_line":"          cd $ZUUL_PROJECT"},{"line_number":336,"context_line":"          puppet module build ."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_82337caa","line":333,"range":{"start_line":333,"start_character":6,"end_line":333,"end_character":16},"in_reply_to":"3a461143_226ba886","updated":"2017-01-29 14:43:57.000000000","message":"Err, I misunderstood your question, my previous comment doesn\u0027t make sense.\n\nNo, we don\u0027t need to revoke sudo permissions, the \"puppet module build\" command doesn\u0027t need sudo, any user can run it.\nSo I think we are good as it is now.","commit_id":"95e206b0b04bab09d1d1bf08ad3b869ab1b579e8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"495e4f136aef19e861936847115f61b395ce7ae4","unresolved":false,"context_lines":[{"line_number":330,"context_line":"      - install-distro-packages"},{"line_number":331,"context_line":"      - install-puppet"},{"line_number":332,"context_line":"      - allow-local-ssh-root"},{"line_number":333,"context_line":"      - shell: |"},{"line_number":334,"context_line":"          #!/bin/bash -xe"},{"line_number":335,"context_line":"          cd $ZUUL_PROJECT"},{"line_number":336,"context_line":"          puppet module build ."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3a461143_226ba886","line":333,"range":{"start_line":333,"start_character":6,"end_line":333,"end_character":16},"in_reply_to":"3a461143_773e578d","updated":"2017-01-29 14:40:01.000000000","message":"I don\u0027t think I need it, let me remove this line. Thanks.","commit_id":"95e206b0b04bab09d1d1bf08ad3b869ab1b579e8"}]}