)]}'
{"jenkins/jobs/barbican.yaml":[{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"40b638a76edcc85cef57316c10cd7cbe52715d97","unresolved":false,"context_lines":[{"line_number":107,"context_line":"          fi"},{"line_number":108,"context_line":"          # Add configrations for enabling image signature verification in local.conf"},{"line_number":109,"context_line":"          function pre_test_hook {{"},{"line_number":110,"context_line":"              local localconf\u003d$BASE/new/devstack/local.conf"},{"line_number":111,"context_line":"              echo \"[[post-config|/\\$NOVA_CONF]]\" \u003e\u003e $localconf"},{"line_number":112,"context_line":"              echo \"[glance]\" \u003e\u003e $localconf"},{"line_number":113,"context_line":"              echo \"verify_glance_signatures \u003d True\" \u003e\u003e $localconf"},{"line_number":114,"context_line":"          }}"},{"line_number":115,"context_line":"          export -f pre_test_hook"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa31d9ce_b375e6cb","line":113,"range":{"start_line":110,"start_character":13,"end_line":113,"end_character":66},"updated":"2017-02-15 18:35:34.000000000","message":"Looking at how the pre_test_hook function is used in other project .yaml files, would there be an advantage to calling a \"pre_test_hook\" script here, that referenced a file in the barbican_tempest_plugin, which could then be modified by patches to barbican_tempest_plugin instead of requiring dependent changes to the project-config project?\n\nFor example, for sahara:\n\nproject-config yaml: \nhttps://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/sahara.yaml#L310\n\npre_test_hook.sh script:\nhttps://github.com/openstack/sahara-tests/blob/master/tools/gate/scenario/pre_test_hook.sh","commit_id":"6d3c345682e658fe0e52f1fa219d6be0957f25ae"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"c859bf543dc47db6e31e4383a7c05aafdae6727e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"          fi"},{"line_number":108,"context_line":"          # Add configrations for enabling image signature verification in local.conf"},{"line_number":109,"context_line":"          function pre_test_hook {{"},{"line_number":110,"context_line":"              local localconf\u003d$BASE/new/devstack/local.conf"},{"line_number":111,"context_line":"              echo \"[[post-config|/\\$NOVA_CONF]]\" \u003e\u003e $localconf"},{"line_number":112,"context_line":"              echo \"[glance]\" \u003e\u003e $localconf"},{"line_number":113,"context_line":"              echo \"verify_glance_signatures \u003d True\" \u003e\u003e $localconf"},{"line_number":114,"context_line":"          }}"},{"line_number":115,"context_line":"          export -f pre_test_hook"},{"line_number":116,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"fa31d9ce_080afc89","line":113,"range":{"start_line":110,"start_character":13,"end_line":113,"end_character":66},"in_reply_to":"fa31d9ce_b375e6cb","updated":"2017-02-15 19:13:43.000000000","message":"In agreement with Brianna. Seems cleaner and more maintainable going forward.","commit_id":"6d3c345682e658fe0e52f1fa219d6be0957f25ae"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"cd56e94a8a282274503ae05cb84dbbb425c2a549","unresolved":false,"context_lines":[{"line_number":107,"context_line":"          fi"},{"line_number":108,"context_line":"          # Add configrations for enabling image signature verification in local.conf"},{"line_number":109,"context_line":"          function pre_test_hook {{"},{"line_number":110,"context_line":"              cd /opt/stack/new/barbican-tempest-plugin/tools/"},{"line_number":111,"context_line":"              ./pre_test_hook.sh"},{"line_number":112,"context_line":"          }}"},{"line_number":113,"context_line":"          export -f pre_test_hook"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa31d9ce_2f9ee206","line":110,"updated":"2017-02-15 21:31:39.000000000","message":"Either a test should be added to confirm that the file exists before running it, or this patch should be made dependent on https://review.openstack.org/#/c/434515/ (since the pre_test_hook.sh script doesn\u0027t exist yet)\n\nSomething like the following:\nhttp://git.openstack.org/cgit/openstack-infra/project-config/tree/jenkins/jobs/networking-sfc.yaml#n99\n\nAlso, maybe \"$BASE\" should be used instead of \"/opt/stack\"","commit_id":"d7f1cdd2c64c0aedbb11aa4c7462a4ed30ab6b2f"},{"author":{"_account_id":8623,"name":"Kaitlin Farr","email":"kaitlin.farr@jhuapl.edu","username":"kaitlin.farr"},"change_message_id":"1f2e049af3b8b58beeb03713cb0d5fb85d4ea14e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"          fi"},{"line_number":108,"context_line":"          # Add configrations for enabling image signature verification in local.conf"},{"line_number":109,"context_line":"          function pre_test_hook {{"},{"line_number":110,"context_line":"              cd /opt/stack/new/barbican-tempest-plugin/tools/"},{"line_number":111,"context_line":"              ./pre_test_hook.sh"},{"line_number":112,"context_line":"          }}"},{"line_number":113,"context_line":"          export -f pre_test_hook"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"fa31d9ce_8a009c35","line":110,"in_reply_to":"fa31d9ce_2f9ee206","updated":"2017-02-15 22:02:06.000000000","message":"Done","commit_id":"d7f1cdd2c64c0aedbb11aa4c7462a4ed30ab6b2f"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"4262f8f121b70203c6ca0ec48c62f3e4f674adfd","unresolved":false,"context_lines":[{"line_number":105,"context_line":"          if [ \"$BRANCH_OVERRIDE\" !\u003d \"default\" ] ; then"},{"line_number":106,"context_line":"              export OVERRIDE_ZUUL_BRANCH\u003d$BRANCH_OVERRIDE"},{"line_number":107,"context_line":"          fi"},{"line_number":108,"context_line":"          # Add configrations for enabling image signature verification in local.conf"},{"line_number":109,"context_line":"          function pre_test_hook {{"},{"line_number":110,"context_line":"              if [ -f $BASE/new/barbican-tempest-plugin/tools/pre_test_hook.sh ] ; then"},{"line_number":111,"context_line":"                  . $BASE/new/barbican-tempest-plugin/tools/pre_test_hook.sh"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"fa31d9ce_328702d9","line":108,"updated":"2017-02-16 16:26:47.000000000","message":"s/configrations/configurations\n\nMaybe this comment could just say a generic bit about configuring security features. In the future the pre_test_hook script probably won\u0027t just be for signature verification.","commit_id":"a0f271b6582ed1c005c616c18d257e5fc2733a9b"}]}