)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12394988a75cc5777dcf8ff7e9e2c87e4ec721b0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"As the multinode test job uses a controller node (*with* compute services)"},{"line_number":23,"context_line":"+ compute node, this also explains why this fails intermittently. The test"},{"line_number":24,"context_line":"passes if the instance gets scheduled onto the controller node (*with*"},{"line_number":25,"context_line":"compute service) and fails if the instance gets scheduler onto the compute"},{"line_number":26,"context_line":"node (\"subnode\")."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"As the tempest tests and the novnc-proxy server are co-located on the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a30ddce_0143b06c","line":25,"range":{"start_line":25,"start_character":48,"end_line":25,"end_character":57},"updated":"2017-03-13 14:22:16.000000000","message":"scheduled","commit_id":"3fadfcef4c3e24347911ac7cbae254ce11684364"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"42c5307a6b7af0b3a855963bb6da7eb88aefc5ad","unresolved":false,"context_lines":[{"line_number":22,"context_line":"As the multinode test job uses a controller node (*with* compute services)"},{"line_number":23,"context_line":"+ compute node, this also explains why this fails intermittently. The test"},{"line_number":24,"context_line":"passes if the instance gets scheduled onto the controller node (*with*"},{"line_number":25,"context_line":"compute service) and fails if the instance gets scheduler onto the compute"},{"line_number":26,"context_line":"node (\"subnode\")."},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"As the tempest tests and the novnc-proxy server are co-located on the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a30ddce_9cdf03d5","line":25,"in_reply_to":"9a30ddce_0143b06c","updated":"2017-03-13 14:35:50.000000000","message":"Done","commit_id":"3fadfcef4c3e24347911ac7cbae254ce11684364"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"39a801ff1ac5e341b7c095a97106b5fe064334f8","unresolved":false,"context_lines":[{"line_number":16,"context_line":"* [vnc].vncserver_proxyclient_address"},{"line_number":17,"context_line":"* [vnc].vncserver_listen"},{"line_number":18,"context_line":"The defaults of these config options are \"127.0.0.1\", which makes sense in"},{"line_number":19,"context_line":"an all-in-one test setup, but it should be the IP address of the compute node"},{"line_number":20,"context_line":"in an multinode setup."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"As the multinode test job uses a controller node (*with* compute services)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3a1ff146_7e21fcfa","line":19,"updated":"2017-03-16 10:31:37.000000000","message":"Reading this again, I think this is not completely correct. vncserver_listen is the compute IP but vncserver_proxyclient_address should point to the controller node where the proxy client runs (see below). So we need to set this to two different values on the slave nodes.","commit_id":"3acf17a2373bb59294e262e1039f3ebeb10e3452"}],"jenkins/jobs/devstack-gate.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"ebb5a37b432ba9ea2df4b04a241209ec81b7ad9f","unresolved":false,"context_lines":[{"line_number":1763,"context_line":"          fi"},{"line_number":1764,"context_line":"          export DEVSTACK_GATE_TOPOLOGY\u003d\"multinode\""},{"line_number":1765,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"NOVA_VNC_ENABLED\u003dtrue\""},{"line_number":1766,"context_line":"          export VNCSERVER_LISTEN\u003d$HOST_IP"},{"line_number":1767,"context_line":"          export VNCSERVER_PROXYCLIENT_ADDRESS\u003d$VNCSERVER_LISTEN"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a30ddce_a54a3424","line":1766,"updated":"2017-03-10 09:49:28.000000000","message":"I don\u0027t think that this is the right context, you will need to put this into the DEVSTACK_LOCAL_CONFIG var at least. But with the latest changes around localrc handling something even fancier might be needed.","commit_id":"6015d7fc01ac8c19cf70bf77a21f6a5b24cf1c75"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"4abd58adbd9f5fbd801340b03f9bce64a0f960f6","unresolved":false,"context_lines":[{"line_number":1763,"context_line":"          fi"},{"line_number":1764,"context_line":"          export DEVSTACK_GATE_TOPOLOGY\u003d\"multinode\""},{"line_number":1765,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"NOVA_VNC_ENABLED\u003dtrue\""},{"line_number":1766,"context_line":"          export VNCSERVER_LISTEN\u003d$HOST_IP"},{"line_number":1767,"context_line":"          export VNCSERVER_PROXYCLIENT_ADDRESS\u003d$VNCSERVER_LISTEN"},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9a30ddce_85d0d020","line":1766,"in_reply_to":"9a30ddce_a54a3424","updated":"2017-03-10 09:52:52.000000000","message":"Ah, OK, I hoped this naive approach would work. I\u0027ll do more research how this localrc handling is done here. Thanks for the hint.","commit_id":"6015d7fc01ac8c19cf70bf77a21f6a5b24cf1c75"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8309f920de8ee0997b0ff75b3826db173078e6a2","unresolved":false,"context_lines":[{"line_number":1764,"context_line":"          export DEVSTACK_GATE_TOPOLOGY\u003d\"multinode\""},{"line_number":1765,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"NOVA_VNC_ENABLED\u003dtrue\""},{"line_number":1766,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"VNCSERVER_LISTEN\u003d$HOST_IP\""},{"line_number":1767,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"VNCSERVER_PROXYCLIENT_ADDRESS\u003d$HOST_IP\""},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":1770,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"9a30ddce_a81f6906","line":1767,"updated":"2017-03-10 10:12:46.000000000","message":"If anyone has a pointer to an explanation how this \"DEVSTACK_LOCAL_CONFIG\" magic works, that would help me. I don\u0027t find docs or inline comments which give me more insights. ¯\\_(ツ)_/¯","commit_id":"1c9f5d1ee4d41f943cfdad1c62a260d4a433b78e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"d8b1bf842150007d56a8e1a48c2d91c635dc8dee","unresolved":false,"context_lines":[{"line_number":1763,"context_line":"          fi"},{"line_number":1764,"context_line":"          export DEVSTACK_GATE_TOPOLOGY\u003d\"multinode\""},{"line_number":1765,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"NOVA_VNC_ENABLED\u003dtrue\""},{"line_number":1766,"context_line":"          DEVSTACK_LOCAL_CONFIG+\u003d\"\\nVNCSERVER_LISTEN\u003d\\$HOST_IP\""},{"line_number":1767,"context_line":"          DEVSTACK_LOCAL_CONFIG+\u003d\"\\nVNCSERVER_PROXYCLIENT_ADDRESS\u003d\\$HOST_IP\""},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_082dd5fd","line":1766,"updated":"2017-03-10 10:20:00.000000000","message":"That should work a bit better now, though I\u0027m not quite sure how much quoting the \"$HOST_IP\" really needs in order to be evaluated neither too early nor too late.","commit_id":"3fadfcef4c3e24347911ac7cbae254ce11684364"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"11c42dc6e7b700588d95cb99a6d8ca23d91b15c1","unresolved":false,"context_lines":[{"line_number":1763,"context_line":"          fi"},{"line_number":1764,"context_line":"          export DEVSTACK_GATE_TOPOLOGY\u003d\"multinode\""},{"line_number":1765,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"NOVA_VNC_ENABLED\u003dtrue\""},{"line_number":1766,"context_line":"          DEVSTACK_LOCAL_CONFIG+\u003d\"\\nVNCSERVER_LISTEN\u003d\\$HOST_IP\""},{"line_number":1767,"context_line":"          DEVSTACK_LOCAL_CONFIG+\u003d\"\\nVNCSERVER_PROXYCLIENT_ADDRESS\u003d\\$HOST_IP\""},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_0e015d05","line":1766,"in_reply_to":"9a30ddce_082dd5fd","updated":"2017-03-10 10:55:54.000000000","message":"Uh, yeah, concatenation make a lot more sense, thank you.","commit_id":"3fadfcef4c3e24347911ac7cbae254ce11684364"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"12394988a75cc5777dcf8ff7e9e2c87e4ec721b0","unresolved":false,"context_lines":[{"line_number":1763,"context_line":"          fi"},{"line_number":1764,"context_line":"          export DEVSTACK_GATE_TOPOLOGY\u003d\"multinode\""},{"line_number":1765,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"NOVA_VNC_ENABLED\u003dtrue\""},{"line_number":1766,"context_line":"          DEVSTACK_LOCAL_CONFIG+\u003d\"\\nVNCSERVER_LISTEN\u003d\\$HOST_IP\""},{"line_number":1767,"context_line":"          DEVSTACK_LOCAL_CONFIG+\u003d\"\\nVNCSERVER_PROXYCLIENT_ADDRESS\u003d\\$HOST_IP\""},{"line_number":1768,"context_line":""},{"line_number":1769,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"9a30ddce_fc3f1f84","line":1766,"in_reply_to":"9a30ddce_0e015d05","updated":"2017-03-13 14:22:16.000000000","message":"The variables look good, this is even pointed out in the devstack docs for multinode:\n\nhttp://git.openstack.org/cgit/openstack-dev/devstack/tree/doc/source/guides/multinode-lab.rst#n182\n\nIt would be nice if we could just determine this automatically within devstack, but devstack is not really topology aware, devstack-gate is the thing that knows about the topology. There are certain variables that only get set in a multinode job so we could hack some topology awareness into devstack, but they\u0027d be just that, hacks, so that should probably be avoided.","commit_id":"3fadfcef4c3e24347911ac7cbae254ce11684364"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"738f2c0bea71d669572c98afcd7c614371a2f124","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"          export DEVSTACK_GATE_TOPOLOGY\u003d\"multinode\""},{"line_number":1562,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"NOVA_VNC_ENABLED\u003dtrue\""},{"line_number":1563,"context_line":"          DEVSTACK_LOCAL_CONFIG+\u003d\"\\nVNCSERVER_LISTEN\u003d\\$HOST_IP\""},{"line_number":1564,"context_line":"          DEVSTACK_LOCAL_CONFIG+\u003d\"\\nVNCSERVER_PROXYCLIENT_ADDRESS\u003d\\$HOST_IP\""},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":1567,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a1ff146_b3cad018","line":1564,"updated":"2017-03-16 08:48:43.000000000","message":"use the following for proper quoting etc. like done in rest of these files\n\n+\u003d$\u0027\\n\u0027\"VNC...","commit_id":"3acf17a2373bb59294e262e1039f3ebeb10e3452"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"451deb4d2d61267a7d86d99da5c1f61180b6629b","unresolved":false,"context_lines":[{"line_number":1561,"context_line":"          export DEVSTACK_GATE_TOPOLOGY\u003d\"multinode\""},{"line_number":1562,"context_line":"          export DEVSTACK_LOCAL_CONFIG\u003d\"NOVA_VNC_ENABLED\u003dtrue\""},{"line_number":1563,"context_line":"          DEVSTACK_LOCAL_CONFIG+\u003d\"\\nVNCSERVER_LISTEN\u003d\\$HOST_IP\""},{"line_number":1564,"context_line":"          DEVSTACK_LOCAL_CONFIG+\u003d\"\\nVNCSERVER_PROXYCLIENT_ADDRESS\u003d\\$HOST_IP\""},{"line_number":1565,"context_line":""},{"line_number":1566,"context_line":"          cp devstack-gate/devstack-vm-gate-wrap.sh ./safe-devstack-vm-gate-wrap.sh"},{"line_number":1567,"context_line":"          ./safe-devstack-vm-gate-wrap.sh"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"3a1ff146_f47c2b74","line":1564,"in_reply_to":"3a1ff146_b3cad018","updated":"2017-03-16 11:18:51.000000000","message":"instead of doing this you should be able to use \n\nlocal_conf:\n  conf: |\nNOVA_VNC_ENABLED\u003dtrue\nVNCSERVER_LISTEN\u003d$HOST_IP\nVNCSERVER_PROXYCLIENT_ADDRESS\u003d$HOST_IP\n\n\nI think (the subnode case is going to need to be ensured that it works). Which gets rid of all the crazy encoding parts.","commit_id":"3acf17a2373bb59294e262e1039f3ebeb10e3452"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"fb74d6ac747d8aaf6d81f29652b2fd83cd11b87f","unresolved":false,"context_lines":[{"line_number":1552,"context_line":"            [[local|localrc]]"},{"line_number":1553,"context_line":"            NOVA_VNC_ENABLED\u003dtrue"},{"line_number":1554,"context_line":"            VNCSERVER_LISTEN\u003d0.0.0.0"},{"line_number":1555,"context_line":"            VNCSERVER_PROXYCLIENT_ADDRESS\u003d$SERVICE_HOST"},{"line_number":1556,"context_line":"      - shell: |"},{"line_number":1557,"context_line":"          #!/bin/bash -xe"},{"line_number":1558,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3a1ff146_6afdb639","line":1555,"updated":"2017-03-16 12:11:52.000000000","message":"Hmm, http://git.openstack.org/cgit/openstack-dev/devstack/tree/doc/source/guides/multinode-lab.rst#n180 has it in yet another version, either someone tests this locally and confirms a working setup or we\u0027ll need some more iterations of testing in the gate.","commit_id":"321675b5033fc53b6a2f9d1ad50945f30766791d"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"c8de3d46dbc408190e233905029a2679bff46f9d","unresolved":false,"context_lines":[{"line_number":1552,"context_line":"            [[local|localrc]]"},{"line_number":1553,"context_line":"            NOVA_VNC_ENABLED\u003dtrue"},{"line_number":1554,"context_line":"            VNCSERVER_LISTEN\u003d0.0.0.0"},{"line_number":1555,"context_line":"            VNCSERVER_PROXYCLIENT_ADDRESS\u003d$SERVICE_HOST"},{"line_number":1556,"context_line":"      - shell: |"},{"line_number":1557,"context_line":"          #!/bin/bash -xe"},{"line_number":1558,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"1a1ced50_63c44392","line":1555,"range":{"start_line":1555,"start_character":42,"end_line":1555,"end_character":55},"updated":"2017-03-17 10:53:56.000000000","message":"I think it should be \"HOST_IP\" instead of \"SERVICE_HOST\". Until ps4 it was \"HOST_IP\".","commit_id":"321675b5033fc53b6a2f9d1ad50945f30766791d"}]}
