)]}'
{"jenkins/jobs/tripleo.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"22de018ba23936aca0e27553964c89c34963afd7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      - link-logs"},{"line_number":94,"context_line":"      - net-info"},{"line_number":95,"context_line":"      - python-tripleoclient-buildimage-checkout"},{"line_number":96,"context_line":"      - zuul-git-prep-upper-constraints"},{"line_number":97,"context_line":"      - shell: |"},{"line_number":98,"context_line":"          #!/bin/bash -xe"},{"line_number":99,"context_line":"          cd python-tripleoclient"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffe62b97_c9970c3a","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":12},"updated":"2017-03-29 14:38:00.000000000","message":"Note that this checks out the repository itself as well into workspace, hope that does not cause any problems.","commit_id":"466576fa9b92193af472a816e5b83ac22d3902d2"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"fb072836aedd032d82d2be9ea7b5e91cc3b26c3a","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      - link-logs"},{"line_number":94,"context_line":"      - net-info"},{"line_number":95,"context_line":"      - python-tripleoclient-buildimage-checkout"},{"line_number":96,"context_line":"      - zuul-git-prep-upper-constraints"},{"line_number":97,"context_line":"      - shell: |"},{"line_number":98,"context_line":"          #!/bin/bash -xe"},{"line_number":99,"context_line":"          cd python-tripleoclient"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffe62b97_2c39e3d5","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":12},"in_reply_to":"ffe62b97_c616d6a8","updated":"2017-03-29 15:40:50.000000000","message":"It is indeed the usual way but it checks out two things:\n$PROJECT_REPO plus the upper-constraints file.\n\nSo, you get an extra checkout you didn\u0027 have before.\n\nI cannot answer whether that\u0027s a problem, just pointing it out.","commit_id":"466576fa9b92193af472a816e5b83ac22d3902d2"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"b57f020f8c30e34300642b3e51229cdcfba357c7","unresolved":false,"context_lines":[{"line_number":93,"context_line":"      - link-logs"},{"line_number":94,"context_line":"      - net-info"},{"line_number":95,"context_line":"      - python-tripleoclient-buildimage-checkout"},{"line_number":96,"context_line":"      - zuul-git-prep-upper-constraints"},{"line_number":97,"context_line":"      - shell: |"},{"line_number":98,"context_line":"          #!/bin/bash -xe"},{"line_number":99,"context_line":"          cd python-tripleoclient"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffe62b97_c616d6a8","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":12},"in_reply_to":"ffe62b97_c9970c3a","updated":"2017-03-29 15:15:41.000000000","message":"is not the usual way to get the constraints? is there a better alternative?","commit_id":"466576fa9b92193af472a816e5b83ac22d3902d2"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"95cbcc6cb0884d22aa4750545d291e8781c32cfe","unresolved":false,"context_lines":[{"line_number":111,"context_line":"          export USE_DELOREAN_TRUNK\u003d1"},{"line_number":112,"context_line":"          export DELOREAN_REPO_FILE\u003d\"delorean.repo\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"          if [ \"$ZUUL_BRANCH\" \u003d\u003d \"stable/mitaka\" ]; then"},{"line_number":115,"context_line":"              export DELOREAN_TRUNK_REPO\u003d\"https://trunk.rdoproject.org/centos7-mitaka/current/\""},{"line_number":116,"context_line":"          else"},{"line_number":117,"context_line":"              export DELOREAN_TRUNK_REPO\u003d\"https://buildlogs.centos.org/centos/7/cloud/x86_64/rdo-trunk-master-tripleo/\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffe62b97_bfa6420e","line":114,"updated":"2017-03-29 12:41:55.000000000","message":"you might also need to update this check.  Otherwise, always going to build from delorean master on stable branches","commit_id":"466576fa9b92193af472a816e5b83ac22d3902d2"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"22de018ba23936aca0e27553964c89c34963afd7","unresolved":false,"context_lines":[{"line_number":124,"context_line":"          else"},{"line_number":125,"context_line":"              # This file always exists in OpenStack CI jobs, check for it so that"},{"line_number":126,"context_line":"              # it can be used manually as well."},{"line_number":127,"context_line":"              if [ -e \"$(pwd)/upper-constraints.txt\" ]; then"},{"line_number":128,"context_line":"                  export UPPER_CONSTRAINTS_FILE\u003d$(pwd)/upper-constraints.txt"},{"line_number":129,"context_line":"              fi"},{"line_number":130,"context_line":"              tox -evenv -- pip install diskimage-builder -c $UPPER_CONSTRAINTS_FILE"},{"line_number":131,"context_line":"          fi"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffe62b97_a9acc89e","line":129,"range":{"start_line":127,"start_character":14,"end_line":129,"end_character":16},"updated":"2017-03-29 14:38:00.000000000","message":"here you set this only if it exists.\n\nWith the above checkout, I think you can set this in all cases. If the file would not exist, then UPPER_CONSTRANTINS_FILE is not set at all.\n\nSo, either use a default for it - or remove the if and always set it.","commit_id":"466576fa9b92193af472a816e5b83ac22d3902d2"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"cd0b7e05cba0ea9c6adbc55f2561eb2ab8c971e6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"              if [ -e \"$(pwd)/upper-constraints.txt\" ]; then"},{"line_number":128,"context_line":"                  export UPPER_CONSTRAINTS_FILE\u003d$(pwd)/upper-constraints.txt"},{"line_number":129,"context_line":"              fi"},{"line_number":130,"context_line":"              tox -evenv -- pip install diskimage-builder -c $UPPER_CONSTRAINTS_FILE"},{"line_number":131,"context_line":"          fi"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"          tox -evenv -- openstack overcloud image build --type {image-name} --elements-path\u003d\"$ELEMENTS\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffe62b97_2e01de06","line":130,"updated":"2017-03-29 14:28:16.000000000","message":"this will not work if $UPPER_CONSTRAINTS_FILE is not set.\nthe variable is not set in all cases.","commit_id":"466576fa9b92193af472a816e5b83ac22d3902d2"},{"author":{"_account_id":6133,"name":"yolanda.robla","email":"yroblamo@redhat.com","username":"yolanda.robla"},"change_message_id":"a7cb061f0c22aaa6f061f22c39fdfaf4602840f6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"              if [ -e \"$(pwd)/upper-constraints.txt\" ]; then"},{"line_number":128,"context_line":"                  export UPPER_CONSTRAINTS_FILE\u003d$(pwd)/upper-constraints.txt"},{"line_number":129,"context_line":"              fi"},{"line_number":130,"context_line":"              tox -evenv -- pip install diskimage-builder -c $UPPER_CONSTRAINTS_FILE"},{"line_number":131,"context_line":"          fi"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"          tox -evenv -- openstack overcloud image build --type {image-name} --elements-path\u003d\"$ELEMENTS\""}],"source_content_type":"text/x-yaml","patch_set":6,"id":"ffe62b97_a9296837","line":130,"in_reply_to":"ffe62b97_2e01de06","updated":"2017-03-29 14:35:05.000000000","message":"Thanks for reviewing, can you clarify it? How can i ensure to have an upper constraints? I added the git-prep-upper-constraints, do i need anything else?","commit_id":"466576fa9b92193af472a816e5b83ac22d3902d2"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"826ba9520359fc1732bbe44ec6e3819872ef57ed","unresolved":false,"context_lines":[{"line_number":100,"context_line":"          /usr/local/jenkins/slave_scripts/install-distro-packages.sh"},{"line_number":101,"context_line":"      - shell: |"},{"line_number":102,"context_line":"          #!/bin/bash -xe"},{"line_number":103,"context_line":"          cd python-tripleoclient"},{"line_number":104,"context_line":"          ELEMENTS\u003d\"$WORKSPACE/instack-undercloud/elements:\""},{"line_number":105,"context_line":"          ELEMENTS+\u003d\"$WORKSPACE/tripleo-puppet-elements/elements:\""},{"line_number":106,"context_line":"          ELEMENTS+\u003d\"$WORKSPACE/tripleo-image-elements/elements:\""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffe62b97_036705eb","line":103,"range":{"start_line":103,"start_character":10,"end_line":103,"end_character":33},"updated":"2017-03-29 18:31:46.000000000","message":"sorry, missed this.","commit_id":"cde4af42e3fb79a9f3a0288abf850fa69825014a"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"826ba9520359fc1732bbe44ec6e3819872ef57ed","unresolved":false,"context_lines":[{"line_number":124,"context_line":"          else"},{"line_number":125,"context_line":"              # This file always exists in OpenStack CI jobs, check for it so that"},{"line_number":126,"context_line":"              # it can be used manually as well."},{"line_number":127,"context_line":"              export UPPER_CONSTRAINTS_FILE\u003d$(pwd)/upper-constraints.txt"},{"line_number":128,"context_line":"              tox -evenv -- pip install diskimage-builder -c $UPPER_CONSTRAINTS_FILE"},{"line_number":129,"context_line":"          fi"},{"line_number":130,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ffe62b97_63a37101","line":127,"range":{"start_line":127,"start_character":44,"end_line":127,"end_character":50},"updated":"2017-03-29 18:31:46.000000000","message":"$WORKSPACE instead of $(pwd) since you run cd above","commit_id":"cde4af42e3fb79a9f3a0288abf850fa69825014a"}]}