)]}'
{"jenkins/jobs/manila.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"cae83ad58d94c2904e399c6160f73bb6a1efb0e7","unresolved":false,"context_lines":[{"line_number":602,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_CEPH_C_BAK\u003dFalse\""},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"MANILA_CEPH_DRIVER\u003dcephfs{variant}\""},{"line_number":605,"context_line":""},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"          # Keep localrc to be able to set some vars in pre_test_hook"},{"line_number":608,"context_line":"          export KEEP_LOCALRC\u003d1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bff0334d_16fd6cb0","line":605,"updated":"2017-04-09 06:24:40.000000000","message":"Use the new local_conf set up","commit_id":"17bc5d8b894afd96463ab16b74823683fbe7402f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"dbec8bf55e3a61d0dcc2b83f607a44bdb1c08302","unresolved":false,"context_lines":[{"line_number":602,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_CEPH_C_BAK\u003dFalse\""},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"          export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"MANILA_CEPH_DRIVER\u003dcephfs{variant}\""},{"line_number":605,"context_line":""},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"          # Keep localrc to be able to set some vars in pre_test_hook"},{"line_number":608,"context_line":"          export KEEP_LOCALRC\u003d1"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"bff0334d_6ba60356","line":605,"in_reply_to":"bff0334d_16fd6cb0","updated":"2017-04-10 11:11:30.000000000","message":"Done","commit_id":"17bc5d8b894afd96463ab16b74823683fbe7402f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"19eb1215575a19f6cf85a523b94ecac043b99ebb","unresolved":false,"context_lines":[{"line_number":571,"context_line":"      - net-info"},{"line_number":572,"context_line":"      - devstack-checkout"},{"line_number":573,"context_line":"      - local_conf:"},{"line_number":574,"context_line":"        conf: |"},{"line_number":575,"context_line":"            [[local|localrc]]"},{"line_number":576,"context_line":"            \"enable_plugin manila git://git.openstack.org/openstack/manila\""},{"line_number":577,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_ea1a1bca","line":574,"updated":"2017-04-09 23:00:44.000000000","message":"This needs two more spaces of indent","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"66debb71ae12b26d541f4928cd6e9e0347c40a7c","unresolved":false,"context_lines":[{"line_number":571,"context_line":"      - net-info"},{"line_number":572,"context_line":"      - devstack-checkout"},{"line_number":573,"context_line":"      - local_conf:"},{"line_number":574,"context_line":"        conf: |"},{"line_number":575,"context_line":"            [[local|localrc]]"},{"line_number":576,"context_line":"            \"enable_plugin manila git://git.openstack.org/openstack/manila\""},{"line_number":577,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_4b333f15","line":574,"in_reply_to":"bff0334d_ea1a1bca","updated":"2017-04-10 11:43:17.000000000","message":"Done","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"19eb1215575a19f6cf85a523b94ecac043b99ebb","unresolved":false,"context_lines":[{"line_number":573,"context_line":"      - local_conf:"},{"line_number":574,"context_line":"        conf: |"},{"line_number":575,"context_line":"            [[local|localrc]]"},{"line_number":576,"context_line":"            \"enable_plugin manila git://git.openstack.org/openstack/manila\""},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"            \"enable_plugin devstack-plugin-ceph git://git.openstack.org/openstack/devstack-plugin-ceph\""},{"line_number":579,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_ca0bd77a","line":576,"updated":"2017-04-09 23:00:44.000000000","message":"Not sure whether they are actually harmful, but you could omit the quotes here and in the remainder of this section","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"66debb71ae12b26d541f4928cd6e9e0347c40a7c","unresolved":false,"context_lines":[{"line_number":573,"context_line":"      - local_conf:"},{"line_number":574,"context_line":"        conf: |"},{"line_number":575,"context_line":"            [[local|localrc]]"},{"line_number":576,"context_line":"            \"enable_plugin manila git://git.openstack.org/openstack/manila\""},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"            \"enable_plugin devstack-plugin-ceph git://git.openstack.org/openstack/devstack-plugin-ceph\""},{"line_number":579,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_8b2ca7ac","line":576,"in_reply_to":"bff0334d_ca0bd77a","updated":"2017-04-10 11:43:17.000000000","message":"I\u0027ll remove them, thanks.","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"aeb82f74cf917e3c198b958180594c418bac9fed","unresolved":false,"context_lines":[{"line_number":575,"context_line":"            [[local|localrc]]"},{"line_number":576,"context_line":"            \"enable_plugin manila git://git.openstack.org/openstack/manila\""},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"            \"enable_plugin devstack-plugin-ceph git://git.openstack.org/openstack/devstack-plugin-ceph\""},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"            # Enable CephFS as the backend for Manila."},{"line_number":581,"context_line":"            \"ENABLE_CEPH_MANILA\u003dTrue\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_115444fe","line":578,"updated":"2017-04-10 11:41:29.000000000","message":"REmove all the \"\" - see how it\u0027S done elsewhere","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"66debb71ae12b26d541f4928cd6e9e0347c40a7c","unresolved":false,"context_lines":[{"line_number":575,"context_line":"            [[local|localrc]]"},{"line_number":576,"context_line":"            \"enable_plugin manila git://git.openstack.org/openstack/manila\""},{"line_number":577,"context_line":""},{"line_number":578,"context_line":"            \"enable_plugin devstack-plugin-ceph git://git.openstack.org/openstack/devstack-plugin-ceph\""},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"            # Enable CephFS as the backend for Manila."},{"line_number":581,"context_line":"            \"ENABLE_CEPH_MANILA\u003dTrue\""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_716150d3","line":578,"in_reply_to":"bff0334d_115444fe","updated":"2017-04-10 11:43:17.000000000","message":"Ack.","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"19eb1215575a19f6cf85a523b94ecac043b99ebb","unresolved":false,"context_lines":[{"line_number":600,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":601,"context_line":"          export DEVSTACK_GATE_NEUTRON\u003d1"},{"line_number":602,"context_line":"          export ENABLED_SERVICES\u003dtempest"},{"line_number":603,"context_line":"          export PROJECTS\u003d\"openstack/python-manilaclient openstack/devstack-plugin-ceph $PROJECTS\""},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"          function pre_test_hook {{"},{"line_number":606,"context_line":"              # Configure Manila with a CephFSNative driver backend."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_aa1093a9","line":603,"updated":"2017-04-09 23:00:44.000000000","message":"Compared with your other jobs I think you are missing the\n\nexport KEEP_LOCALRC\u003d1\n\nhere","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"66debb71ae12b26d541f4928cd6e9e0347c40a7c","unresolved":false,"context_lines":[{"line_number":600,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"},{"line_number":601,"context_line":"          export DEVSTACK_GATE_NEUTRON\u003d1"},{"line_number":602,"context_line":"          export ENABLED_SERVICES\u003dtempest"},{"line_number":603,"context_line":"          export PROJECTS\u003d\"openstack/python-manilaclient openstack/devstack-plugin-ceph $PROJECTS\""},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"          function pre_test_hook {{"},{"line_number":606,"context_line":"              # Configure Manila with a CephFSNative driver backend."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_d62492b1","line":603,"in_reply_to":"bff0334d_aa1093a9","updated":"2017-04-10 11:43:17.000000000","message":"I was vaguely thinking that this only pertained to the traditional localrc vs local.conf, but I\u0027ll put it back.","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"19eb1215575a19f6cf85a523b94ecac043b99ebb","unresolved":false,"context_lines":[{"line_number":603,"context_line":"          export PROJECTS\u003d\"openstack/python-manilaclient openstack/devstack-plugin-ceph $PROJECTS\""},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"          function pre_test_hook {{"},{"line_number":606,"context_line":"              # Configure Manila with a CephFSNative driver backend."},{"line_number":607,"context_line":"              # Refer job-template\u0027s pre_test_hook for more details on the"},{"line_number":608,"context_line":"              # arguments."},{"line_number":609,"context_line":"              source $BASE/new/devstack-plugin-ceph/manila/pre_test_hook.sh \\"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_8a294fe7","line":606,"updated":"2017-04-09 23:00:44.000000000","message":"Nit: Native or NFS","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"66debb71ae12b26d541f4928cd6e9e0347c40a7c","unresolved":false,"context_lines":[{"line_number":603,"context_line":"          export PROJECTS\u003d\"openstack/python-manilaclient openstack/devstack-plugin-ceph $PROJECTS\""},{"line_number":604,"context_line":""},{"line_number":605,"context_line":"          function pre_test_hook {{"},{"line_number":606,"context_line":"              # Configure Manila with a CephFSNative driver backend."},{"line_number":607,"context_line":"              # Refer job-template\u0027s pre_test_hook for more details on the"},{"line_number":608,"context_line":"              # arguments."},{"line_number":609,"context_line":"              source $BASE/new/devstack-plugin-ceph/manila/pre_test_hook.sh \\"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_f66d56cc","line":606,"in_reply_to":"bff0334d_8a294fe7","updated":"2017-04-10 11:43:17.000000000","message":"Fixed, thanks.","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"87c3444dbf6df7cd31993d35d8bc96532d22988b","unresolved":false,"context_lines":[{"line_number":557,"context_line":"      - devstack-logs"},{"line_number":558,"context_line":"      - console-log"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"- job-template:"},{"line_number":561,"context_line":"    name: \u0027gate-manila-tempest-minimal-dsvm-cephfs-{variant}-{node}{suffix}\u0027"},{"line_number":562,"context_line":"    node: \u0027{node}\u0027"},{"line_number":563,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_f711d05e","line":560,"updated":"2017-04-10 12:56:46.000000000","message":"Why new template? Why not update of above one?","commit_id":"5664dcb6a69864f64b887181cde7bb0a93751d19"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9e23a5bae9b3da416d3d49bb88c629327f810d41","unresolved":false,"context_lines":[{"line_number":557,"context_line":"      - devstack-logs"},{"line_number":558,"context_line":"      - console-log"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"- job-template:"},{"line_number":561,"context_line":"    name: \u0027gate-manila-tempest-minimal-dsvm-cephfs-{variant}-{node}{suffix}\u0027"},{"line_number":562,"context_line":"    node: \u0027{node}\u0027"},{"line_number":563,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_ee58b3fa","line":560,"in_reply_to":"bff0334d_f711d05e","updated":"2017-04-11 13:29:36.000000000","message":"I was just being incremental: was going to consoldate the new experimental jobs with the old and remove the old template in a later patch.\n\nI\u0027ll go on and do the consolidation now.","commit_id":"5664dcb6a69864f64b887181cde7bb0a93751d19"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"fe42c37964acb32452fc3517e42024892c3575b4","unresolved":false,"context_lines":[{"line_number":485,"context_line":""},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"- job-template:"},{"line_number":488,"context_line":"    name: \u0027gate-manila-tempest-minimal-dsvm-cephfs-{variant}-{node}{suffix}\u0027"},{"line_number":489,"context_line":"    node: \u0027{node}\u0027"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_01714176","line":488,"range":{"start_line":488,"start_character":31,"end_line":488,"end_character":38},"updated":"2017-04-12 12:27:37.000000000","message":"\u0027minimal\u0027 as opposed to?","commit_id":"6f2cc67b64bbff59237474390cf72bd6825f701e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3fad6bae8f4985f2575817b3b423d78bdcaa6e9c","unresolved":false,"context_lines":[{"line_number":485,"context_line":""},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"- job-template:"},{"line_number":488,"context_line":"    name: \u0027gate-manila-tempest-minimal-dsvm-cephfs-{variant}-{node}{suffix}\u0027"},{"line_number":489,"context_line":"    node: \u0027{node}\u0027"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_24e9f3e4","line":488,"range":{"start_line":488,"start_character":31,"end_line":488,"end_character":38},"in_reply_to":"bff0334d_01714176","updated":"2017-04-12 13:02:32.000000000","message":"As opposed to \u0027full\u0027 I think.  Honestly, I was just copying a pattern.\n\nI will ask at the top of the review about this.","commit_id":"6f2cc67b64bbff59237474390cf72bd6825f701e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad4a62afbe605e3a20d22c6f7770a1c94b467db0","unresolved":false,"context_lines":[{"line_number":485,"context_line":""},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"- job-template:"},{"line_number":488,"context_line":"    name: \u0027gate-manila-tempest-minimal-dsvm-cephfs-{variant}-{node}{suffix}\u0027"},{"line_number":489,"context_line":"    node: \u0027{node}\u0027"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"    wrappers:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_df97b044","line":488,"range":{"start_line":488,"start_character":31,"end_line":488,"end_character":38},"in_reply_to":"bff0334d_24e9f3e4","updated":"2017-04-12 13:09:00.000000000","message":"\"minimal\" means install only required projects, not default set. Default set is not \"minimal\".","commit_id":"6f2cc67b64bbff59237474390cf72bd6825f701e"}],"jenkins/jobs/projects.yaml":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"87c3444dbf6df7cd31993d35d8bc96532d22988b","unresolved":false,"context_lines":[{"line_number":6769,"context_line":"          node: \u0027ubuntu-xenial\u0027"},{"line_number":6770,"context_line":"          suffix: \u0027-nv\u0027"},{"line_number":6771,"context_line":"          variant: \u0027native-heketi\u0027"},{"line_number":6772,"context_line":"      - \u0027gate-manila-tempest-minimal-dsvm-cephfs-{variant}-{node}{suffix}\u0027:"},{"line_number":6773,"context_line":"          node: \u0027centos-7\u0027"},{"line_number":6774,"context_line":"          suffix: \u0027-nv\u0027"},{"line_number":6775,"context_line":"          variant: \u0027native\u0027"},{"line_number":6776,"context_line":"      - \u0027gate-manila-tempest-minimal-dsvm-cephfs-{variant}-{node}{suffix}\u0027:"},{"line_number":6777,"context_line":"          node: \u0027centos-7\u0027"},{"line_number":6778,"context_line":"          suffix: \u0027-nv\u0027"},{"line_number":6779,"context_line":"          variant: \u0027nfs\u0027"},{"line_number":6780,"context_line":""},{"line_number":6781,"context_line":"- project:"},{"line_number":6782,"context_line":"    name: manila-image-elements"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_d7100cab","line":6779,"range":{"start_line":6772,"start_character":6,"end_line":6779,"end_character":24},"updated":"2017-04-10 12:56:46.000000000","message":"- \u0027gate-manila-tempest-minimal-dsvm-cephfs-{variant}-{node}{suffix}\u0027:\n    node: \u0027centos-7\u0027\n    suffix: \u0027-nv\u0027\n    variant:\n      - \u0027native\u0027\n      - \u0027nfs\u0027","commit_id":"5664dcb6a69864f64b887181cde7bb0a93751d19"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9e23a5bae9b3da416d3d49bb88c629327f810d41","unresolved":false,"context_lines":[{"line_number":6769,"context_line":"          node: \u0027ubuntu-xenial\u0027"},{"line_number":6770,"context_line":"          suffix: \u0027-nv\u0027"},{"line_number":6771,"context_line":"          variant: \u0027native-heketi\u0027"},{"line_number":6772,"context_line":"      - \u0027gate-manila-tempest-minimal-dsvm-cephfs-{variant}-{node}{suffix}\u0027:"},{"line_number":6773,"context_line":"          node: \u0027centos-7\u0027"},{"line_number":6774,"context_line":"          suffix: \u0027-nv\u0027"},{"line_number":6775,"context_line":"          variant: \u0027native\u0027"},{"line_number":6776,"context_line":"      - \u0027gate-manila-tempest-minimal-dsvm-cephfs-{variant}-{node}{suffix}\u0027:"},{"line_number":6777,"context_line":"          node: \u0027centos-7\u0027"},{"line_number":6778,"context_line":"          suffix: \u0027-nv\u0027"},{"line_number":6779,"context_line":"          variant: \u0027nfs\u0027"},{"line_number":6780,"context_line":""},{"line_number":6781,"context_line":"- project:"},{"line_number":6782,"context_line":"    name: manila-image-elements"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_2e08dbd7","line":6779,"range":{"start_line":6772,"start_character":6,"end_line":6779,"end_character":24},"in_reply_to":"bff0334d_d7100cab","updated":"2017-04-11 13:29:36.000000000","message":"Good suggestion, thanks.","commit_id":"5664dcb6a69864f64b887181cde7bb0a93751d19"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"fe42c37964acb32452fc3517e42024892c3575b4","unresolved":false,"context_lines":[{"line_number":6796,"context_line":"            - \u0027ubuntu-xenial\u0027"},{"line_number":6797,"context_line":"            - \u0027centos-7\u0027"},{"line_number":6798,"context_line":"          suffix:"},{"line_number":6799,"context_line":"            - \u0027\u0027"},{"line_number":6800,"context_line":"            - \u0027-nv\u0027"},{"line_number":6801,"context_line":"          variant:"},{"line_number":6802,"context_line":"            - \u0027native\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_c14d993b","line":6799,"range":{"start_line":6799,"start_character":14,"end_line":6799,"end_character":16},"updated":"2017-04-12 12:27:37.000000000","message":"What\u0027s this for?","commit_id":"6f2cc67b64bbff59237474390cf72bd6825f701e"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"ad4a62afbe605e3a20d22c6f7770a1c94b467db0","unresolved":false,"context_lines":[{"line_number":6796,"context_line":"            - \u0027ubuntu-xenial\u0027"},{"line_number":6797,"context_line":"            - \u0027centos-7\u0027"},{"line_number":6798,"context_line":"          suffix:"},{"line_number":6799,"context_line":"            - \u0027\u0027"},{"line_number":6800,"context_line":"            - \u0027-nv\u0027"},{"line_number":6801,"context_line":"          variant:"},{"line_number":6802,"context_line":"            - \u0027native\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_dfbe90ac","line":6799,"range":{"start_line":6799,"start_character":14,"end_line":6799,"end_character":16},"in_reply_to":"bff0334d_8167914d","updated":"2017-04-12 13:09:00.000000000","message":"\"-nv\" is used by jenkins and marks job as NonVoting. And this suffix, empty one, defines voting job without \"-nv\" suffix. Left to use it in any of pipelines when needed.","commit_id":"6f2cc67b64bbff59237474390cf72bd6825f701e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3fad6bae8f4985f2575817b3b423d78bdcaa6e9c","unresolved":false,"context_lines":[{"line_number":6796,"context_line":"            - \u0027ubuntu-xenial\u0027"},{"line_number":6797,"context_line":"            - \u0027centos-7\u0027"},{"line_number":6798,"context_line":"          suffix:"},{"line_number":6799,"context_line":"            - \u0027\u0027"},{"line_number":6800,"context_line":"            - \u0027-nv\u0027"},{"line_number":6801,"context_line":"          variant:"},{"line_number":6802,"context_line":"            - \u0027native\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_8167914d","line":6799,"range":{"start_line":6799,"start_character":14,"end_line":6799,"end_character":16},"in_reply_to":"bff0334d_c14d993b","updated":"2017-04-12 13:02:32.000000000","message":"Allows for the *possibility* of not adding \u0027-nv\u0027 on the job name.  All *actual* jobs still have \u0027-nv\u0027 currently.","commit_id":"6f2cc67b64bbff59237474390cf72bd6825f701e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"017d69f34c9df00051440e9a36954b16a93a138a","unresolved":false,"context_lines":[{"line_number":6796,"context_line":"            - \u0027ubuntu-xenial\u0027"},{"line_number":6797,"context_line":"            - \u0027centos-7\u0027"},{"line_number":6798,"context_line":"          suffix:"},{"line_number":6799,"context_line":"            - \u0027\u0027"},{"line_number":6800,"context_line":"            - \u0027-nv\u0027"},{"line_number":6801,"context_line":"          variant:"},{"line_number":6802,"context_line":"            - \u0027native\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_fa2cc2ac","line":6799,"range":{"start_line":6799,"start_character":14,"end_line":6799,"end_character":16},"in_reply_to":"bff0334d_c14d993b","updated":"2017-04-12 13:36:40.000000000","message":"You\u0027re only using the -nv jobs, so let\u0027s not define these here at all.\n\nAlso, with mitaka EOL: Do not add any new ubuntu-trusty jobs. Instead remove trusty...","commit_id":"6f2cc67b64bbff59237474390cf72bd6825f701e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bcb14ad8ee727eb1c743a00842bf2a6918b123d8","unresolved":false,"context_lines":[{"line_number":6796,"context_line":"            - \u0027ubuntu-xenial\u0027"},{"line_number":6797,"context_line":"            - \u0027centos-7\u0027"},{"line_number":6798,"context_line":"          suffix:"},{"line_number":6799,"context_line":"            - \u0027\u0027"},{"line_number":6800,"context_line":"            - \u0027-nv\u0027"},{"line_number":6801,"context_line":"          variant:"},{"line_number":6802,"context_line":"            - \u0027native\u0027"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"bff0334d_500f0d87","line":6799,"range":{"start_line":6799,"start_character":14,"end_line":6799,"end_character":16},"in_reply_to":"bff0334d_fa2cc2ac","updated":"2017-04-12 14:40:16.000000000","message":"OK, will do.","commit_id":"6f2cc67b64bbff59237474390cf72bd6825f701e"}],"zuul/layout.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"19eb1215575a19f6cf85a523b94ecac043b99ebb","unresolved":false,"context_lines":[{"line_number":3077,"context_line":"  - name: gate-manila-tempest-dsvm-postgres-zfsonlinux-ubuntu-trusty-nv"},{"line_number":3078,"context_line":"    branch: ^(?:stable/mitaka).*$"},{"line_number":3079,"context_line":""},{"line_number":3080,"context_line":"    # Skip on Ocata and ealier branches"},{"line_number":3081,"context_line":"  - name: gate-manila-tempest-minimal-dsvm-cephfs-nfs-centos-7-nv"},{"line_number":3082,"context_line":"    branch: ^(?!stable/(?:mitaka|newton|ocata)).*$"},{"line_number":3083,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_0a165fa9","line":3080,"updated":"2017-04-09 23:00:44.000000000","message":"Nit: earlier\n\nAlso not sure whether you need these comments at all, with so much \"prior art\" around","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"66debb71ae12b26d541f4928cd6e9e0347c40a7c","unresolved":false,"context_lines":[{"line_number":3077,"context_line":"  - name: gate-manila-tempest-dsvm-postgres-zfsonlinux-ubuntu-trusty-nv"},{"line_number":3078,"context_line":"    branch: ^(?:stable/mitaka).*$"},{"line_number":3079,"context_line":""},{"line_number":3080,"context_line":"    # Skip on Ocata and ealier branches"},{"line_number":3081,"context_line":"  - name: gate-manila-tempest-minimal-dsvm-cephfs-nfs-centos-7-nv"},{"line_number":3082,"context_line":"    branch: ^(?!stable/(?:mitaka|newton|ocata)).*$"},{"line_number":3083,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bff0334d_b66eae2c","line":3080,"in_reply_to":"bff0334d_0a165fa9","updated":"2017-04-10 11:43:17.000000000","message":"Agree, I removed them.","commit_id":"a450d0788225d0aeaee17a9cffe9e9eebfabe969"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"87c3444dbf6df7cd31993d35d8bc96532d22988b","unresolved":false,"context_lines":[{"line_number":3077,"context_line":"  - name: gate-manila-tempest-dsvm-postgres-zfsonlinux-ubuntu-trusty-nv"},{"line_number":3078,"context_line":"    branch: ^(?:stable/mitaka).*$"},{"line_number":3079,"context_line":""},{"line_number":3080,"context_line":"  - name: gate-manila-tempest-minimal-dsvm-cephfs-nfs-centos-7-nv"},{"line_number":3081,"context_line":"    branch: ^(?!stable/(?:mitaka|newton|ocata)).*$"},{"line_number":3082,"context_line":""},{"line_number":3083,"context_line":"  - name: gate-manila-tempest-minimal-dsvm-cephfs-native-centos-7-nv"},{"line_number":3084,"context_line":"    branch: ^(?!stable/(?:mitaka|newton|ocata)).*$"},{"line_number":3085,"context_line":""},{"line_number":3086,"context_line":"  - name: gate-manila-tempest-dsvm-cephfs-native-ubuntu-trusty-nv"},{"line_number":3087,"context_line":"    branch: ^(?:stable/mitaka).*$"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_9754c454","line":3084,"range":{"start_line":3080,"start_character":0,"end_line":3084,"end_character":50},"updated":"2017-04-10 12:56:46.000000000","message":"If you do not plan to have separate filters for them later, then it may be better to use common regex for both. See one of examples on line 3074.","commit_id":"5664dcb6a69864f64b887181cde7bb0a93751d19"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9e23a5bae9b3da416d3d49bb88c629327f810d41","unresolved":false,"context_lines":[{"line_number":3077,"context_line":"  - name: gate-manila-tempest-dsvm-postgres-zfsonlinux-ubuntu-trusty-nv"},{"line_number":3078,"context_line":"    branch: ^(?:stable/mitaka).*$"},{"line_number":3079,"context_line":""},{"line_number":3080,"context_line":"  - name: gate-manila-tempest-minimal-dsvm-cephfs-nfs-centos-7-nv"},{"line_number":3081,"context_line":"    branch: ^(?!stable/(?:mitaka|newton|ocata)).*$"},{"line_number":3082,"context_line":""},{"line_number":3083,"context_line":"  - name: gate-manila-tempest-minimal-dsvm-cephfs-native-centos-7-nv"},{"line_number":3084,"context_line":"    branch: ^(?!stable/(?:mitaka|newton|ocata)).*$"},{"line_number":3085,"context_line":""},{"line_number":3086,"context_line":"  - name: gate-manila-tempest-dsvm-cephfs-native-ubuntu-trusty-nv"},{"line_number":3087,"context_line":"    branch: ^(?:stable/mitaka).*$"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"bff0334d_ae24eb5e","line":3084,"range":{"start_line":3080,"start_character":0,"end_line":3084,"end_character":50},"in_reply_to":"bff0334d_9754c454","updated":"2017-04-11 13:29:36.000000000","message":"Thanks for this observation.  It made me think harder about what is actually needed, namely to run \u0027nfs\u0027 variant jobs only post-ocata, and to run \u0027native\u0027 variant jobs on all maintained branches (since native driver was introduced in mitaka).","commit_id":"5664dcb6a69864f64b887181cde7bb0a93751d19"}]}
