)]}'
{"jenkins/jobs/macros.yaml":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"84936bce8cec3060f258d919313c36fcacf2716d","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    builders:"},{"line_number":173,"context_line":"      - shell: |"},{"line_number":174,"context_line":"          #!/bin/bash -xe"},{"line_number":175,"context_line":"          export BRANCH\u003d{branch}"},{"line_number":176,"context_line":"          CLONEMAP\u003d`mktemp`"},{"line_number":177,"context_line":"          function cleanup {{"},{"line_number":178,"context_line":"              mkdir -p $WORKSPACE"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bff0334d_310e653b","line":175,"updated":"2017-04-07 08:23:59.000000000","message":"I don\u0027t think you need this export as you pass the \"--branch\" argument to zuul-cloner explicitly and I don\u0027t see anything else using it.","commit_id":"bb75639300e65d9a4381e979c2e3836cb2300c1e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"f422644b00546cc31f52ad7d5ecc1a1ac1e7732b","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    builders:"},{"line_number":173,"context_line":"      - shell: |"},{"line_number":174,"context_line":"          #!/bin/bash -xe"},{"line_number":175,"context_line":"          export BRANCH\u003d{branch}"},{"line_number":176,"context_line":"          CLONEMAP\u003d`mktemp`"},{"line_number":177,"context_line":"          function cleanup {{"},{"line_number":178,"context_line":"              mkdir -p $WORKSPACE"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bff0334d_bbc48e60","line":175,"in_reply_to":"bff0334d_2af94ec7","updated":"2017-04-07 10:21:21.000000000","message":"Sounds reasonable, agreed.","commit_id":"bb75639300e65d9a4381e979c2e3836cb2300c1e"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"72cc05474774f45ee715cd685a1df5f4af140c63","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    builders:"},{"line_number":173,"context_line":"      - shell: |"},{"line_number":174,"context_line":"          #!/bin/bash -xe"},{"line_number":175,"context_line":"          export BRANCH\u003d{branch}"},{"line_number":176,"context_line":"          CLONEMAP\u003d`mktemp`"},{"line_number":177,"context_line":"          function cleanup {{"},{"line_number":178,"context_line":"              mkdir -p $WORKSPACE"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bff0334d_2af94ec7","line":175,"in_reply_to":"bff0334d_310e653b","updated":"2017-04-07 09:11:29.000000000","message":"Indeed - I wanted to follow zuul-git-branch-prep-upper-constraints where we use the same construct.\n\nHaving it early here helps users figure out that they have to pass in \"branch\", so I would leave it as is.","commit_id":"bb75639300e65d9a4381e979c2e3836cb2300c1e"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"84936bce8cec3060f258d919313c36fcacf2716d","unresolved":false,"context_lines":[{"line_number":185,"context_line":"              dest: ."},{"line_number":186,"context_line":"          EOF"},{"line_number":187,"context_line":"          /usr/zuul-env/bin/zuul-cloner -m $CLONEMAP --cache-dir /opt/git \\"},{"line_number":188,"context_line":"              --branch\u003d$BRANCH \\"},{"line_number":189,"context_line":"              git://git.openstack.org $ZUUL_PROJECT"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"- builder:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"bff0334d_143c6fbd","line":188,"updated":"2017-04-07 08:23:59.000000000","message":"Just do \"--branch\u003d{branch}\" here and omit the export above?","commit_id":"bb75639300e65d9a4381e979c2e3836cb2300c1e"}]}