)]}'
{"nodepool/elements/infra-package-needs/finalise.d/89-sshd":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c1176a3f75b1cf00720babdac18e0080dd5ce8dd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Copyright (C) 2011-2013 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bff0334d_a58564d1","line":2,"updated":"2017-04-10 01:19:26.000000000","message":"technically not sure if this is right","commit_id":"3ebf7c86190022ec495127a82f92e2f46b00dae7"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c1176a3f75b1cf00720babdac18e0080dd5ce8dd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":16,"context_line":"# limitations under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# dib-lint: disable\u003dset setu setpipefail indent"},{"line_number":19,"context_line":"if [ ${DIB_DEBUG_TRACE:-0} -gt 0 ]; then"},{"line_number":20,"context_line":"    set -x"},{"line_number":21,"context_line":"fi"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bff0334d_451fb8b6","line":18,"updated":"2017-04-10 01:19:26.000000000","message":"can we stop copy-pasting this?  it was only supposed to be in existing files when they weren\u0027t dib-lint safe","commit_id":"3ebf7c86190022ec495127a82f92e2f46b00dae7"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"4185635de28fa1fd5f30be9e156bfa3cfee670d7","unresolved":false,"context_lines":[{"line_number":23,"context_line":"set -o pipefail"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"sed -i -e\u0027/PermitRootLogin/d\u0027 /etc/ssh/sshd_config \\"},{"line_number":26,"context_line":"    \u0026\u0026 echo \"PermitRootLogin Yes\" \u003e\u003e /etc/ssh/sshd_config"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"bff0334d_ef0b3127","line":26,"updated":"2017-04-10 17:09:14.000000000","message":"Couple small nits. We should have a comment in here that explains the reason for this. TLDR is glean configures ssh for the root user.\n\nAlso dib docs say that finalise.d should be reserved for things that modify the filesystem metadta or the image itself. Post-install.d is likely a better location for this step.","commit_id":"e5be75d1a196f61921b4a095d9e5780d45bbd358"}]}