)]}'
{"nodepool/elements/nodepool-base/install.d/40-install-zuul":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"a63a3d63b3f8d8c255a3e9d45f8daf919bc4974b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":13,"context_line":"# implied."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# Install bindep into a virtualenv"},{"line_number":16,"context_line":"# This is in /usr instead of /usr/local due to this bug on precise:"},{"line_number":17,"context_line":"# https://bugs.launchpad.net/ubuntu/+source/python2.7/+bug/839588"},{"line_number":18,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"bff0334d_b133f1f5","line":15,"updated":"2017-04-12 20:27:48.000000000","message":"This comment looks wrong.","commit_id":"5b7425f9a9d420cd03b54a930dadd88dfcce5c4f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9543622c150d0069a37d455d06112c645e8ca8cc","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/bash"},{"line_number":2,"context_line":"# Copyright (C) 2015 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"9ff52f3f_da7af286","line":2,"updated":"2017-04-13 14:11:01.000000000","message":"Nit: 2017","commit_id":"a3dcefbd1b22b82e6e85a13e934635b5dd145a7b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d4cca3247a85c7f7456b0c8f8804461cd11bb2a6","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -eu"},{"line_number":20,"context_line":"set -o pipefail"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"sudo -H virtualenv /usr/zuul-env"},{"line_number":23,"context_line":"sudo -H /usr/zuul-env/bin/pip install /opt/git/openstack-infra"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_abd7bcbf","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":4},"updated":"2017-04-17 17:43:50.000000000","message":"Are you sure the sudo is necessary? I don\u0027t see it in the other install.d files for this element","commit_id":"a3dcefbd1b22b82e6e85a13e934635b5dd145a7b"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"fecd8b414df07508c08fa48281443c8841a12e14","unresolved":false,"context_lines":[{"line_number":19,"context_line":"set -eu"},{"line_number":20,"context_line":"set -o pipefail"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"sudo -H virtualenv /usr/zuul-env"},{"line_number":23,"context_line":"sudo -H /usr/zuul-env/bin/pip install /opt/git/openstack-infra"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_a6f6d18e","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":4},"in_reply_to":"7ffa3b31_abd7bcbf","updated":"2017-04-17 18:14:17.000000000","message":"can remove","commit_id":"a3dcefbd1b22b82e6e85a13e934635b5dd145a7b"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"d4cca3247a85c7f7456b0c8f8804461cd11bb2a6","unresolved":false,"context_lines":[{"line_number":20,"context_line":"set -o pipefail"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"sudo -H virtualenv /usr/zuul-env"},{"line_number":23,"context_line":"sudo -H /usr/zuul-env/bin/pip install /opt/git/openstack-infra"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_8bfd203c","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":62},"updated":"2017-04-17 17:43:50.000000000","message":"Where is this from? In slave_common I see the zuul-env venv and then a pip install of /opt/zuul","commit_id":"a3dcefbd1b22b82e6e85a13e934635b5dd145a7b"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"fecd8b414df07508c08fa48281443c8841a12e14","unresolved":false,"context_lines":[{"line_number":20,"context_line":"set -o pipefail"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"sudo -H virtualenv /usr/zuul-env"},{"line_number":23,"context_line":"sudo -H /usr/zuul-env/bin/pip install /opt/git/openstack-infra"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7ffa3b31_e6397941","line":23,"range":{"start_line":23,"start_character":26,"end_line":23,"end_character":62},"in_reply_to":"7ffa3b31_8bfd203c","updated":"2017-04-17 18:14:17.000000000","message":"ah, this is a typo, it should be:\n\n  /opt/git/openstack-infra/zuul\n\nwhich we get from cache-devstack","commit_id":"a3dcefbd1b22b82e6e85a13e934635b5dd145a7b"}]}
