)]}'
{"nodepool/elements/jenkins-slave/extra-data.d/20-jenkins-user":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"84b524a40ca59168bc975da41744a29ae18238d9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# save the public key inside the chroot"},{"line_number":20,"context_line":"echo \"ssh-rsa $NODEPOOL_SSH_KEY\" \u003e $TMP_HOOKS_PATH/jenkins-user-ssh-public-key"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5ff73747_e6925d4b","line":20,"updated":"2017-04-26 17:35:04.000000000","message":"Does this write need to be sudo\u0027d? not sure what ownership of TMP_HOOK_PATH is. Remember you can\u0027t sudo echo \u003e /path and have to do something like echo | sudo tee instead.","commit_id":"2fe9c2125dc57c1d5a60e1492afd5d483a6abe4c"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"a9a7007788f78d94c17a84a3743cd3e0cb435bd6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"fi"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"# save the public key inside the chroot"},{"line_number":20,"context_line":"echo \"ssh-rsa $NODEPOOL_SSH_KEY\" \u003e $TMP_HOOKS_PATH/jenkins-user-ssh-public-key"}],"source_content_type":"application/x-shellscript","patch_set":3,"id":"5ff73747_e6349dfd","line":20,"in_reply_to":"5ff73747_e6925d4b","updated":"2017-04-26 17:47:04.000000000","message":"currently no, we have the proper write permissions to populate the key","commit_id":"2fe9c2125dc57c1d5a60e1492afd5d483a6abe4c"}],"nodepool/elements/jenkins-slave/extra-data.d/60-jenkins-user":[{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"299821209dfa15454d1bf9d256faa48336d48192","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NODEPOOL_SSH_KEY\u003d${NODEPOOL_SSH_KEY:-AAAAB3NzaC1yc2EAAAADAQABAAABAQC6WutNHfM+YdnjeNFeaIpvxqt+9aDn95Ykpmc+fASSjlDZJtOrueH3ch/v08wkE4WQKg03i+t8VonqEwMGmApYA3VzFsURUQbxzlSz5kHlBQSqgz5JTwUmnt1RH5sePL5pkuJ6JgqJ8PxJod6fiD7YDjaKJW/wBzXGnGg2EkgqrkBQXYL4hyaPuSwsQF0Gdwg3QFqXl+R/GrM6FscUkkJzbjqGKI2GhLT8mf2BIMEAiMFhF5Wl4FFrbvhTfPfW+9VdcsiMxCXaxp00n1x1+Y7OqR5AZ/id0Lkz9ZoFVGS901OB/L4xXrvUtI2y+kIYeF6hxfmAl/zhY0eWzwo9lDPz}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [ ! -f $NODEPOOL_SSH_KEY ]; then"},{"line_number":12,"context_line":"    die \"Can not find public key for jenkins user!\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5ff73747_fb08bdd9","line":9,"updated":"2017-04-26 15:09:27.000000000","message":"Can we put a comment here and in the remaining puppet side that we should change both together? at least until that is no longer necessary? Otherwise I am fine with double accounting this as theer isn\u0027t another good way to manage it.","commit_id":"4de5979b6800fad110e23ce23df18ee712c2f829"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"bf34d3400cb42dd55b1f3a57950233c3f688931e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"set -eu"},{"line_number":7,"context_line":"set -o pipefail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"NODEPOOL_SSH_KEY\u003d${NODEPOOL_SSH_KEY:-AAAAB3NzaC1yc2EAAAADAQABAAABAQC6WutNHfM+YdnjeNFeaIpvxqt+9aDn95Ykpmc+fASSjlDZJtOrueH3ch/v08wkE4WQKg03i+t8VonqEwMGmApYA3VzFsURUQbxzlSz5kHlBQSqgz5JTwUmnt1RH5sePL5pkuJ6JgqJ8PxJod6fiD7YDjaKJW/wBzXGnGg2EkgqrkBQXYL4hyaPuSwsQF0Gdwg3QFqXl+R/GrM6FscUkkJzbjqGKI2GhLT8mf2BIMEAiMFhF5Wl4FFrbvhTfPfW+9VdcsiMxCXaxp00n1x1+Y7OqR5AZ/id0Lkz9ZoFVGS901OB/L4xXrvUtI2y+kIYeF6hxfmAl/zhY0eWzwo9lDPz}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"if [ ! -f $NODEPOOL_SSH_KEY ]; then"},{"line_number":12,"context_line":"    die \"Can not find public key for jenkins user!\""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5ff73747_1bb929cb","line":9,"in_reply_to":"5ff73747_fb08bdd9","updated":"2017-04-26 15:12:20.000000000","message":"yes","commit_id":"4de5979b6800fad110e23ce23df18ee712c2f829"},{"author":{"_account_id":4146,"name":"Clark Boylan","email":"cboylan@sapwetik.org","username":"cboylan"},"change_message_id":"299821209dfa15454d1bf9d256faa48336d48192","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# save the public key inside the chroot"},{"line_number":16,"context_line":"cat \"ssh-rsa $NODEPOOL_SSH_KEY\" \u003e\u003e $TMP_HOOKS_PATH/jenkins-user-ssh-public-key"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5ff73747_1b6129aa","line":16,"updated":"2017-04-26 15:09:27.000000000","message":"I wouldn\u0027t force this to be ssh-rsa so that you could possibly pass in non rsa keys as an option. Those are becoming more and more popular and we may even consider a switch soon.","commit_id":"4de5979b6800fad110e23ce23df18ee712c2f829"},{"author":{"_account_id":4162,"name":"Paul Belanger","email":"pabelanger@redhat.com","username":"pabelanger"},"change_message_id":"bf34d3400cb42dd55b1f3a57950233c3f688931e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"fi"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# save the public key inside the chroot"},{"line_number":16,"context_line":"cat \"ssh-rsa $NODEPOOL_SSH_KEY\" \u003e\u003e $TMP_HOOKS_PATH/jenkins-user-ssh-public-key"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"5ff73747_5bad7186","line":16,"in_reply_to":"5ff73747_1b6129aa","updated":"2017-04-26 15:12:20.000000000","message":"Agree, we can maybe expose something however, it is hard coded today: https://github.com/openstack-infra/puppet-jenkins/blob/master/templates/authorized_keys.erb\n\nIf we wanted to optimize, I\u0027d love just assume the \"ssh-rsa\" type is part of nodepool_ssh_key.","commit_id":"4de5979b6800fad110e23ce23df18ee712c2f829"}]}
