)]}'
{"nodepool/elements/openstack-repos/extra-data.d/50-create-repo-list":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"34e08484c9e59e5fd61d020a556534ba54669ada","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import urllib2"},{"line_number":21,"context_line":"from urllib2 import URLError"},{"line_number":22,"context_line":"import yaml"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"URL \u003d (\u0027https://git.openstack.org/cgit/openstack-infra/project-config/\u0027"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1f013ff3_097eba6a","side":"PARENT","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":28},"updated":"2017-05-16 11:02:11.000000000","message":"indeed missing","commit_id":"64bb1f6bcb1d41514dc0345b8b840d6204bf9e06"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"9113c47fbea87a4bc08c95a8d1c66130c037bbd8","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            projects.append(project)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        return projects"},{"line_number":52,"context_line":"    except URLError:"},{"line_number":53,"context_line":"        print \"Could not open project list url: \u0027%s\u0027\" % url"},{"line_number":54,"context_line":"        raise"},{"line_number":55,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1f013ff3_e95b8e2b","side":"PARENT","line":52,"updated":"2017-05-16 11:00:26.000000000","message":"You removed the import for this, how is that supposed to work?","commit_id":"64bb1f6bcb1d41514dc0345b8b840d6204bf9e06"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"2c4471a1c2bfa0b8b8c2b7b34eb8635fd8dbd6c6","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            projects.append(project)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        return projects"},{"line_number":52,"context_line":"    except URLError:"},{"line_number":53,"context_line":"        print \"Could not open project list url: \u0027%s\u0027\" % url"},{"line_number":54,"context_line":"        raise"},{"line_number":55,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1f013ff3_6e508d0b","side":"PARENT","line":52,"in_reply_to":"1f013ff3_6e02cd0b","updated":"2017-05-16 23:39:37.000000000","message":"\u003e\u003e\u003e from urllib2 import urlopen\n \u003e\u003e\u003e try:\n ...     print(\u0027hi\u0027)\n ... except URLError:\n ...     pass\n ... \n hi\n\nhmmm","commit_id":"64bb1f6bcb1d41514dc0345b8b840d6204bf9e06"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"564ac86ca2a98fe4bc0c4bc0686ad06d8e023aff","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            projects.append(project)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        return projects"},{"line_number":52,"context_line":"    except URLError:"},{"line_number":53,"context_line":"        print \"Could not open project list url: \u0027%s\u0027\" % url"},{"line_number":54,"context_line":"        raise"},{"line_number":55,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1f013ff3_eed7fd4e","side":"PARENT","line":52,"in_reply_to":"1f013ff3_6e508d0b","updated":"2017-05-16 23:50:45.000000000","message":"so yeah, that pulls in the exception confusingly.  but this made me look closer, and i see \"six\" has wrappers for all this.  six is a dependency of dib.  updated in next review.  thanks :)","commit_id":"64bb1f6bcb1d41514dc0345b8b840d6204bf9e06"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"38824d88789c5f572c9882b96619b773c07ff246","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            projects.append(project)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        return projects"},{"line_number":52,"context_line":"    except URLError:"},{"line_number":53,"context_line":"        print \"Could not open project list url: \u0027%s\u0027\" % url"},{"line_number":54,"context_line":"        raise"},{"line_number":55,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1f013ff3_6e02cd0b","side":"PARENT","line":52,"in_reply_to":"1f013ff3_e95b8e2b","updated":"2017-05-16 23:34:54.000000000","message":"hmm, interesting and true :)  i wonder why this wasn\u0027t picked up","commit_id":"64bb1f6bcb1d41514dc0345b8b840d6204bf9e06"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"350a4063a132d8c545eb2efc35b61ec2f0cc62df","unresolved":false,"context_lines":[{"line_number":19,"context_line":"import os"},{"line_number":20,"context_line":"import urllib2"},{"line_number":21,"context_line":"from urllib2 import URLError"},{"line_number":22,"context_line":"import yaml"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"URL \u003d (\u0027https://git.openstack.org/cgit/openstack-infra/project-config/\u0027"},{"line_number":25,"context_line":"       \u0027plain/gerrit/projects.yaml\u0027)"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"1f013ff3_3122e153","side":"PARENT","line":22,"updated":"2017-05-17 05:13:26.000000000","message":"The urllib stuff looks reasonable now, but why are you dropping the imports for os+yaml? Both are still being used below.","commit_id":"64bb1f6bcb1d41514dc0345b8b840d6204bf9e06"}]}
