)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"bb648be0b0db5f0b21b17007c148a44938f1f3d2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Uninstall urllib3 pip installation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"https://review.openstack.org/#/c/456395/ has added urllib3 package"},{"line_number":10,"context_line":"installation from pip which is conflicting to rpm based installation."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This parch removes it in node preparation for puppet jobs as it"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df140735_3b21f14e","line":9,"updated":"2017-05-29 10:11:36.000000000","message":"This patch should not have changed anything, those packages used to be installed with pip by puppet during the image build, now they\u0027re still installed with pip but directly in a dib element.","commit_id":"db12204b2b82442f4e5b643c98dc818c3a5f4d54"}],"jenkins/jobs/macros.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"9f7630019ee2df170c0412bd9d3b0bcfd6f97f8e","unresolved":false,"context_lines":[{"line_number":523,"context_line":"              sudo yum -y install libxml2-devel libxslt-devel ruby-devel zlib-devel"},{"line_number":524,"context_line":"              sudo yum -y groupinstall \"Development Tools\""},{"line_number":525,"context_line":"              # Uninstall python-requests and urllib3 from pip, since we install it in"},{"line_number":526,"context_line":"              # system-config/install_puppet.sh"},{"line_number":527,"context_line":"              sudo pip uninstall requests urllib3 -y || true"},{"line_number":528,"context_line":"          elif [ -f /usr/bin/apt-get ]; then"},{"line_number":529,"context_line":"              sudo apt-get remove -y --purge facter puppet puppet-common hiera"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_502484c6","line":526,"updated":"2017-05-29 09:59:05.000000000","message":"install_puppet only installs requests but not urllib3 - or is that a dependency?","commit_id":"db12204b2b82442f4e5b643c98dc818c3a5f4d54"},{"author":{"_account_id":16312,"name":"Alfredo Moralejo","email":"amoralej@redhat.com","username":"amoralej"},"change_message_id":"d02f31e05e5356f4c1e8b9d4c97914cd7032f7f1","unresolved":false,"context_lines":[{"line_number":523,"context_line":"              sudo yum -y install libxml2-devel libxslt-devel ruby-devel zlib-devel"},{"line_number":524,"context_line":"              sudo yum -y groupinstall \"Development Tools\""},{"line_number":525,"context_line":"              # Uninstall python-requests and urllib3 from pip, since we install it in"},{"line_number":526,"context_line":"              # system-config/install_puppet.sh"},{"line_number":527,"context_line":"              sudo pip uninstall requests urllib3 -y || true"},{"line_number":528,"context_line":"          elif [ -f /usr/bin/apt-get ]; then"},{"line_number":529,"context_line":"              sudo apt-get remove -y --purge facter puppet puppet-common hiera"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_bb75019b","line":526,"in_reply_to":"df140735_502484c6","updated":"2017-05-29 10:02:46.000000000","message":"yes, it is dependency. Whatever is installing requests from rpm will install urllib3 also.","commit_id":"db12204b2b82442f4e5b643c98dc818c3a5f4d54"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"942783c78fb1b6db389cb865e784f5ce3cc8180f","unresolved":false,"context_lines":[{"line_number":523,"context_line":"              sudo yum -y install libxml2-devel libxslt-devel ruby-devel zlib-devel"},{"line_number":524,"context_line":"              sudo yum -y groupinstall \"Development Tools\""},{"line_number":525,"context_line":"              # Uninstall python-requests and urllib3 from pip, since we install it in"},{"line_number":526,"context_line":"              # system-config/install_puppet.sh"},{"line_number":527,"context_line":"              sudo pip uninstall requests urllib3 -y || true"},{"line_number":528,"context_line":"          elif [ -f /usr/bin/apt-get ]; then"},{"line_number":529,"context_line":"              sudo apt-get remove -y --purge facter puppet puppet-common hiera"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"df140735_7b276966","line":526,"in_reply_to":"df140735_bb75019b","updated":"2017-05-29 10:08:32.000000000","message":"yeah it\u0027s a dep, see https://pypi.python.org/pypi/requests","commit_id":"db12204b2b82442f4e5b643c98dc818c3a5f4d54"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"f35a1a79e39187e62b5fc9f675ed9db0bee4fb47","unresolved":false,"context_lines":[{"line_number":523,"context_line":"              sudo yum -y install libxml2-devel libxslt-devel ruby-devel zlib-devel"},{"line_number":524,"context_line":"              sudo yum -y groupinstall \"Development Tools\""},{"line_number":525,"context_line":"              # Uninstall python-requests and urllib3 from pip, since we install it in"},{"line_number":526,"context_line":"              # system-config/install_puppet.sh"},{"line_number":527,"context_line":"              sudo pip uninstall requests urllib3 -y || true"},{"line_number":528,"context_line":"          elif [ -f /usr/bin/apt-get ]; then"},{"line_number":529,"context_line":"              sudo apt-get remove -y --purge facter puppet puppet-common hiera"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"df140735_fc2dafa8","line":526,"updated":"2017-05-29 12:41:11.000000000","message":"Could you update the comment too? \"Uninstall python-requests and urllib3 from pip, which are preinstalled on the node during the image build\"","commit_id":"d4da2847ac98ea5d6b340eb454932c1089199837"}]}
