)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"c252d6fc2df5f453520edbf6ee972729d0875edf","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ansible-role-jobs are supposed to be used in the OSA repositories so"},{"line_number":10,"context_line":"there is not particular reason to check for the project name before we"},{"line_number":11,"context_line":"enable the EPEL repository. If for whatever reason the EPEL repository"},{"line_number":12,"context_line":"is not there, then we simply return \u0027true\u0027 so we don\u0027t break existing"},{"line_number":13,"context_line":"jobs. This fixes a problem with the \u0027ansible-hardening\u0027 repository which"},{"line_number":14,"context_line":"doesn\u0027t match the \u0027openstack-ansible\u0027 pattern and as such the EPEL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_4752d53c","line":11,"updated":"2017-07-06 09:01:56.000000000","message":"I\u0027m not understanding this bit \n\n\"check for the project name before we enable EPEL repository\"\n\nI don\u0027t see where that check is happening?\n\nIt really seems wrong to ignore this ... since the EPEL repo *should* be there on our images?","commit_id":"3c621e603a7d97be6612f95f094fd7edd6c16413"},{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"6cfd82472284d8d9b704867b5eeac38c2fd23961","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ansible-role-jobs are supposed to be used in the OSA repositories so"},{"line_number":10,"context_line":"there is not particular reason to check for the project name before we"},{"line_number":11,"context_line":"enable the EPEL repository. If for whatever reason the EPEL repository"},{"line_number":12,"context_line":"is not there, then we simply return \u0027true\u0027 so we don\u0027t break existing"},{"line_number":13,"context_line":"jobs. This fixes a problem with the \u0027ansible-hardening\u0027 repository which"},{"line_number":14,"context_line":"doesn\u0027t match the \u0027openstack-ansible\u0027 pattern and as such the EPEL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_446c0c9b","line":11,"in_reply_to":"3f1d235d_4253e317","updated":"2017-07-06 11:12:53.000000000","message":"i\u0027m not seeing this, which yaml file?\n\nmaybe an intersection of a bit more in the commit message and my lack of understanding of what\u0027s going on","commit_id":"3c621e603a7d97be6612f95f094fd7edd6c16413"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"f678b970e18153bd9135262dc3300259eeebfde2","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ansible-role-jobs are supposed to be used in the OSA repositories so"},{"line_number":10,"context_line":"there is not particular reason to check for the project name before we"},{"line_number":11,"context_line":"enable the EPEL repository. If for whatever reason the EPEL repository"},{"line_number":12,"context_line":"is not there, then we simply return \u0027true\u0027 so we don\u0027t break existing"},{"line_number":13,"context_line":"jobs. This fixes a problem with the \u0027ansible-hardening\u0027 repository which"},{"line_number":14,"context_line":"doesn\u0027t match the \u0027openstack-ansible\u0027 pattern and as such the EPEL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_d20a1ad0","line":11,"in_reply_to":"3f1d235d_446c0c9b","updated":"2017-07-06 12:00:50.000000000","message":"This commit also modifies https://review.openstack.org/#/c/478095/2/jenkins/jobs/ansible-role-jobs.yaml\n\nThis is the yaml file I am referring to.","commit_id":"3c621e603a7d97be6612f95f094fd7edd6c16413"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"f7e3f10bb2e93059b73f623ee8f24c5cd925cc7a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The ansible-role-jobs are supposed to be used in the OSA repositories so"},{"line_number":10,"context_line":"there is not particular reason to check for the project name before we"},{"line_number":11,"context_line":"enable the EPEL repository. If for whatever reason the EPEL repository"},{"line_number":12,"context_line":"is not there, then we simply return \u0027true\u0027 so we don\u0027t break existing"},{"line_number":13,"context_line":"jobs. This fixes a problem with the \u0027ansible-hardening\u0027 repository which"},{"line_number":14,"context_line":"doesn\u0027t match the \u0027openstack-ansible\u0027 pattern and as such the EPEL"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f1d235d_4253e317","line":11,"in_reply_to":"3f1d235d_4752d53c","updated":"2017-07-06 09:06:05.000000000","message":"In the yaml file, there is this condition\n\nif [[ \"{name}\" \u003d\u003d *\"openstack-ansible\"* ]]; then\n\nSo basically, if the {name} (which is the OSA repositorY) is *openstack-ansible* then we enable the repository. Yes, the epel repository is there but disabled so we try to enable it if possible. Maybe the commit message is not clear enough? :/","commit_id":"3c621e603a7d97be6612f95f094fd7edd6c16413"}],"jenkins/jobs/ansible-role-jobs.yaml":[{"author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"change_message_id":"5e996bb8cb538100770b321ccaa716fb1ec99d71","unresolved":false,"context_lines":[{"line_number":77,"context_line":"          template-name: \"{template-name}\""},{"line_number":78,"context_line":"      - zuul-git-prep-upper-constraints"},{"line_number":79,"context_line":"      - shell: |"},{"line_number":80,"context_line":"          if [[ \"{name}\" \u003d\u003d *\"openstack-ansible\"* ]]; then"},{"line_number":81,"context_line":"            # EPEL must be enabled because some deps from bindep.txt are"},{"line_number":82,"context_line":"            # otherwise not available"},{"line_number":83,"context_line":"            if [[ -e /usr/bin/yum ]]; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_d0a43d4d","side":"PARENT","line":80,"updated":"2017-07-06 23:21:11.000000000","message":"ahhh! i see now\n\nwhy not just turn this into a regex match?\n\n  \"{name}\" \u003d~ (openstack-ansible.*|hardening).*\n\nthis also seems to be what\u0027s done in zuul matching anyway\n\n ^gate-(openstack-ansible-security|ansible-hardening)-ansible-func-centos-7.*$\n\nthings like || true always raise a warning for me as so often we find we end up ignoring useful information.  so modifying checks is my preference","commit_id":"173d33a3fbd0921a46d788091b1bae5c6a85dd6f"},{"author":{"_account_id":23163,"name":"Markos Chandras (hwoarang)","email":"markos@chandras.me","username":"mchandras"},"change_message_id":"93ce8afde134fc7d705dbe8883d56a86823b6076","unresolved":false,"context_lines":[{"line_number":77,"context_line":"          template-name: \"{template-name}\""},{"line_number":78,"context_line":"      - zuul-git-prep-upper-constraints"},{"line_number":79,"context_line":"      - shell: |"},{"line_number":80,"context_line":"          if [[ \"{name}\" \u003d\u003d *\"openstack-ansible\"* ]]; then"},{"line_number":81,"context_line":"            # EPEL must be enabled because some deps from bindep.txt are"},{"line_number":82,"context_line":"            # otherwise not available"},{"line_number":83,"context_line":"            if [[ -e /usr/bin/yum ]]; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3f1d235d_f12174b5","side":"PARENT","line":80,"in_reply_to":"3f1d235d_d0a43d4d","updated":"2017-07-07 06:08:20.000000000","message":"mainly for two reasons\n\na) if we add a new project called foobar, then we will have once again to modify the regexp\n\nb) every OSA project uses the same bindep.txt file. As such we really want EPEL enanbled in all of them\n\nI am not even sure why the regexp was there before since these jobs are supposed to be used only by openstack-ansible projects. As such, even before this patch, EPEL was always enabled. But now, we are also using ansible-hardening which doesn\u0027t match the regexp anymore\n\nI can also remove the || true statement because it seems like yum-config-manager always returns 0\n\nFor example\n\n[root@localhost vagrant]# yum-config-manager --enable epel 2\u003e\u00261 \u003e /dev/null                \n[root@localhost vagrant]# echo $?            \n0                     \n[root@localhost vagrant]# yum-config-manager --enable foobar123 2\u003e\u00261 \u003e /dev/null\n[root@localhost vagrant]# echo $?\n0\n\nI hope that clarifies my approach. If you still need me to have the regexp around I am happy to respin it.","commit_id":"173d33a3fbd0921a46d788091b1bae5c6a85dd6f"}]}