)]}'
{"jenkins/jobs/networking-l2gw.yaml":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"5b75deacd603ed830814f53098cf32fb84b12e1b","unresolved":false,"context_lines":[{"line_number":102,"context_line":"          export -f gate_hook"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"          function post_test_hook {{"},{"line_number":105,"context_line":"             bash -xe $BASE/new/networking-l2gw/networking_l2gw/tests/contrib/post_test_hook.sh api"},{"line_number":106,"context_line":"          }}"},{"line_number":107,"context_line":"          export -f post_test_hook"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_c497fa39","side":"PARENT","line":105,"updated":"2017-06-27 19:57:24.000000000","message":"you really don\u0027t need the hooks?","commit_id":"4f24673d401ccbea23ef82c98bf60b0865dd9a27"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"24c5130878466a4b61b1857db2d80c46855dcb56","unresolved":false,"context_lines":[{"line_number":102,"context_line":"          export -f gate_hook"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"          function post_test_hook {{"},{"line_number":105,"context_line":"             bash -xe $BASE/new/networking-l2gw/networking_l2gw/tests/contrib/post_test_hook.sh api"},{"line_number":106,"context_line":"          }}"},{"line_number":107,"context_line":"          export -f post_test_hook"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_0f498bb5","side":"PARENT","line":105,"in_reply_to":"5f201791_4f3c232e","updated":"2017-06-27 20:27:51.000000000","message":"I will add a comment on the commit message. Thanks","commit_id":"4f24673d401ccbea23ef82c98bf60b0865dd9a27"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"3feb769fdaba3afbf0621a859bdb2532a5f267d4","unresolved":false,"context_lines":[{"line_number":102,"context_line":"          export -f gate_hook"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"          function post_test_hook {{"},{"line_number":105,"context_line":"             bash -xe $BASE/new/networking-l2gw/networking_l2gw/tests/contrib/post_test_hook.sh api"},{"line_number":106,"context_line":"          }}"},{"line_number":107,"context_line":"          export -f post_test_hook"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_af8177c5","side":"PARENT","line":105,"in_reply_to":"5f201791_c497fa39","updated":"2017-06-27 20:26:06.000000000","message":"As per conversations with Luigi on IRC, I don\u0027t. Enabling tempest service and adding the regex will run the tests, right?","commit_id":"4f24673d401ccbea23ef82c98bf60b0865dd9a27"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b6c70954c1a53c7b69f72bf55fea6f3dc593b8c","unresolved":false,"context_lines":[{"line_number":102,"context_line":"          export -f gate_hook"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"          function post_test_hook {{"},{"line_number":105,"context_line":"             bash -xe $BASE/new/networking-l2gw/networking_l2gw/tests/contrib/post_test_hook.sh api"},{"line_number":106,"context_line":"          }}"},{"line_number":107,"context_line":"          export -f post_test_hook"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_4f3c232e","side":"PARENT","line":105,"in_reply_to":"5f201791_c497fa39","updated":"2017-06-27 20:25:39.000000000","message":"The hook is a duplicate of functionality already covered by the tempest features offered by devstack.\nhttp://git.openstack.org/cgit/openstack/networking-l2gw/tree/networking_l2gw/tests/contrib/post_test_hook.sh\n\nThat said, explaining this in the commit message is definitely a good thing.","commit_id":"4f24673d401ccbea23ef82c98bf60b0865dd9a27"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"5b75deacd603ed830814f53098cf32fb84b12e1b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"          conf: |"},{"line_number":78,"context_line":"            [[local|localrc]]"},{"line_number":79,"context_line":"            ENABLED_SERVICES\u003d\"\""},{"line_number":80,"context_line":"            # Neutron services"},{"line_number":81,"context_line":"            enable_service q-agt"},{"line_number":82,"context_line":"            enable_service q-dhcp"},{"line_number":83,"context_line":"            enable_service q-l3"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_64926659","line":80,"updated":"2017-06-27 19:57:24.000000000","message":"alternatively: Disable what you don\u0027t need - might be easier than manually adding these and catching up.","commit_id":"5107d8e166b4288c35c1d0e8192efb8d8981a5b8"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4b6c70954c1a53c7b69f72bf55fea6f3dc593b8c","unresolved":false,"context_lines":[{"line_number":77,"context_line":"          conf: |"},{"line_number":78,"context_line":"            [[local|localrc]]"},{"line_number":79,"context_line":"            ENABLED_SERVICES\u003d\"\""},{"line_number":80,"context_line":"            # Neutron services"},{"line_number":81,"context_line":"            enable_service q-agt"},{"line_number":82,"context_line":"            enable_service q-dhcp"},{"line_number":83,"context_line":"            enable_service q-l3"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_2f20c7f6","line":80,"in_reply_to":"5f201791_64926659","updated":"2017-06-27 20:25:39.000000000","message":"Yes, I would likely try with all services and just add your own, at least in the first iteration. Check more the example from sahara-tests and other templates; the the example of kuryr is a bit extreme in the way it requires a minimal list of services.","commit_id":"5107d8e166b4288c35c1d0e8192efb8d8981a5b8"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"5b75deacd603ed830814f53098cf32fb84b12e1b","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            enable_service q-l3"},{"line_number":84,"context_line":"            enable_service q-svc"},{"line_number":85,"context_line":"            enable_service q-meta"},{"line_number":86,"context_line":"            # Keyston"},{"line_number":87,"context_line":"            enable_service key"},{"line_number":88,"context_line":"            # Dependencies"},{"line_number":89,"context_line":"            enable_service rabbit"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_24c34e59","line":86,"updated":"2017-06-27 19:57:24.000000000","message":"nit: typo keystone","commit_id":"5107d8e166b4288c35c1d0e8192efb8d8981a5b8"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"3feb769fdaba3afbf0621a859bdb2532a5f267d4","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            enable_service q-l3"},{"line_number":84,"context_line":"            enable_service q-svc"},{"line_number":85,"context_line":"            enable_service q-meta"},{"line_number":86,"context_line":"            # Keyston"},{"line_number":87,"context_line":"            enable_service key"},{"line_number":88,"context_line":"            # Dependencies"},{"line_number":89,"context_line":"            enable_service rabbit"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f201791_4f6ae319","line":86,"in_reply_to":"5f201791_24c34e59","updated":"2017-06-27 20:26:06.000000000","message":"Done","commit_id":"5107d8e166b4288c35c1d0e8192efb8d8981a5b8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"c2171afc8d0b46266416aa881761569a96ab2d68","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            NETWORKING_L2GW_SERVICE_DRIVER\u003dL2GW:l2gw:networking_l2gw.services.l2gateway.service_drivers.L2gwDriver:default"},{"line_number":83,"context_line":"            # Tempest"},{"line_number":84,"context_line":"            enable_service tempest"},{"line_number":85,"context_line":"            TEMPEST_PLUGINS\u003d\u0027/opt/stack/new/networking-l2gw/networking_l2gw/tests/tempest\u0027"},{"line_number":86,"context_line":"      - shell: |"},{"line_number":87,"context_line":"          #!/bin/bash -xe"},{"line_number":88,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_505b91f4","line":85,"range":{"start_line":85,"start_character":12,"end_line":85,"end_character":27},"updated":"2017-06-28 10:07:37.000000000","message":"i think it\u0027s expected to be the path of the repository.\nie. /opt/stack/new/networking-l2gw","commit_id":"a532bcc41b5a36170939186036a4ce40904b4c4c"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"7ef49f402072c1b0bce63d4d8e2d71ed5fe05cc1","unresolved":false,"context_lines":[{"line_number":82,"context_line":"            NETWORKING_L2GW_SERVICE_DRIVER\u003dL2GW:l2gw:networking_l2gw.services.l2gateway.service_drivers.L2gwDriver:default"},{"line_number":83,"context_line":"            # Tempest"},{"line_number":84,"context_line":"            enable_service tempest"},{"line_number":85,"context_line":"            TEMPEST_PLUGINS\u003d\u0027/opt/stack/new/networking-l2gw/networking_l2gw/tests/tempest\u0027"},{"line_number":86,"context_line":"      - shell: |"},{"line_number":87,"context_line":"          #!/bin/bash -xe"},{"line_number":88,"context_line":"          export PYTHONUNBUFFERED\u003dtrue"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f201791_90cc8935","line":85,"range":{"start_line":85,"start_character":12,"end_line":85,"end_character":27},"in_reply_to":"5f201791_505b91f4","updated":"2017-06-28 10:20:44.000000000","message":"I think you might be right. Since there is not a separate repo for networking-l2gw tempest plugin, we should be pointing to the root of the repo. Thanks","commit_id":"a532bcc41b5a36170939186036a4ce40904b4c4c"},{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"4e8339f4e9a2fed4278a5c09a456e4df11ba5f91","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            enable_plugin networking-l2gw git://git.openstack.org/openstack/networking-l2gw"},{"line_number":81,"context_line":"            enable_service l2gw-plugin"},{"line_number":82,"context_line":"            NETWORKING_L2GW_SERVICE_DRIVER\u003dL2GW:l2gw:networking_l2gw.services.l2gateway.service_drivers.L2gwDriver:default"},{"line_number":83,"context_line":"            # Tempest"},{"line_number":84,"context_line":"            enable_service tempest"},{"line_number":85,"context_line":"            TEMPEST_PLUGINS\u003d\u0027/opt/stack/new/networking-l2gw\u0027"},{"line_number":86,"context_line":"      - shell: |"},{"line_number":87,"context_line":"          #!/bin/bash -xe"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f201791_f39067ef","line":84,"range":{"start_line":83,"start_character":9,"end_line":84,"end_character":34},"updated":"2017-06-28 10:53:57.000000000","message":"tempest is enabled by default, no need to add it.","commit_id":"e1c6860b885c526cd5b1bc1b21fe9fa6bfe5a12e"},{"author":{"_account_id":21626,"name":"Ricardo","email":"rnoriega@redhat.com","username":"rnoriega"},"change_message_id":"25103f5cce5d671f448fd6e1e65a99ba84bc3435","unresolved":false,"context_lines":[{"line_number":80,"context_line":"            enable_plugin networking-l2gw git://git.openstack.org/openstack/networking-l2gw"},{"line_number":81,"context_line":"            enable_service l2gw-plugin"},{"line_number":82,"context_line":"            NETWORKING_L2GW_SERVICE_DRIVER\u003dL2GW:l2gw:networking_l2gw.services.l2gateway.service_drivers.L2gwDriver:default"},{"line_number":83,"context_line":"            # Tempest"},{"line_number":84,"context_line":"            enable_service tempest"},{"line_number":85,"context_line":"            TEMPEST_PLUGINS\u003d\u0027/opt/stack/new/networking-l2gw\u0027"},{"line_number":86,"context_line":"      - shell: |"},{"line_number":87,"context_line":"          #!/bin/bash -xe"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f201791_2edaf276","line":84,"range":{"start_line":83,"start_character":9,"end_line":84,"end_character":34},"in_reply_to":"5f201791_f39067ef","updated":"2017-06-28 11:04:48.000000000","message":"You mean by default once the following line is added, right? \n\nexport DEVSTACK_GATE_TEMPEST\u003d1","commit_id":"e1c6860b885c526cd5b1bc1b21fe9fa6bfe5a12e"}]}
